[issue45865] Old syntax in unittest

Serhiy Storchaka added the comment: Not worth the hassle. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45865] Old syntax in unittest

Adam Johnson added the comment: Okay, I updated the PR to only remove inheritance from object. Should I reopen the ticket? (Not sure of the etiquette.) Perhaps I could later submit a second patch for use of `super()`, and so on? -- ___ Python

[issue45865] Old syntax in unittest

Serhiy Storchaka added the comment: Concur with Eric. -- nosy: +serhiy.storchaka resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue45865] Old syntax in unittest

Eric V. Smith added the comment: As a general rule, we don't accept large patches with changes like this. The chance for breakage somewhere in the 27 files is too high. I could see maybe dropping inheriting from object, since that's relatively safe. -- nosy: +eric.smith

[issue45865] Old syntax in unittest

Change by Adam Johnson : -- keywords: +patch pull_requests: +27934 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29698 ___ Python tracker ___

[issue45865] Old syntax in unittest

New submission from Adam Johnson : I often browse the unittest code in order to write extensions. It still uses some Python 2-isms like classes inheriting from object, it would be nice to clean that up. -- components: Tests messages: 406757 nosy: adamchainz priority: normal severity: