[issue45931] Directory.Build.props/targets leaks from folders above the repo

miss-islington added the comment: New changeset b91805ec0283f0642aa3311ec617c8596f65b7b4 by Miss Islington (bot) in branch '3.9': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)

[issue45931] Directory.Build.props/targets leaks from folders above the repo

miss-islington added the comment: New changeset 5a6d9ed700ecc6984387e0533b11d81692c40469 by Miss Islington (bot) in branch '3.10': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Steve Dower added the comment: Looks like it's gone through. Thanks! -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 ___ Python tracker

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Steve Dower added the comment: New changeset 734ed3538314c9651ae64d5e2e0e98aae3aec17b by David Federman in branch 'main': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +28083 pull_request: https://github.com/python/cpython/pull/29855 ___ Python tracker

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Change by miss-islington : -- pull_requests: +28084 pull_request: https://github.com/python/cpython/pull/29856 ___ Python tracker ___

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Steve Dower added the comment: Nice catch, thanks! Did you start the CLA process already? (I personally would exempt this PR from it as "not sufficiently creative", but I'm not sure I'm allowed to do that anymore...) -- ___ Python tracker

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Change by Eric V. Smith : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue45931] Directory.Build.props/targets leaks from folders above the repo

Change by David Federman : -- keywords: +patch pull_requests: +28082 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29854 ___ Python tracker ___

[issue45931] Directory.Build.props/targets leaks from folders above the repo

New submission from David Federman : When building with Visual Studio 2017+, any Directory.Build.props/targets above the repo in the file structure (eg. in the parent repo when the python repo is a submodule) will be imported automatically. -- components: Build messages: 407320 nosy: