[issue46233] Minor speedup for bigint squaring

[Tim Peters]

Change by Tim Peters :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46233] Minor speedup for bigint squaring

[Tim Peters]

Tim Peters  added the comment:


New changeset 3aa5242b54b0627293d95cfb4a26b2f917f667be by Tim Peters in branch 
'main':
bpo-46233: Minor speedup for bigint squaring (GH-30345)
https://github.com/python/cpython/commit/3aa5242b54b0627293d95cfb4a26b2f917f667be


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46233] Minor speedup for bigint squaring

[Tim Peters]

Change by Tim Peters :


--
keywords: +patch
pull_requests: +28557
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30345

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46233] Minor speedup for bigint squaring

[Tim Peters]

New submission from Tim Peters :

longobject.c's x_mul()'s special code for squaring gets kind of sloppy at the 
end of a digit pass, doing a useless add of 0 and an "extra" test for carry. 
Easily cleaned up.

I think the underlying cause is that the HAC algorithm description it was 
modeled on was quite "hand wavy" about how badly, and exactly when, the carry 
can exceed a single digit. Things are better-behaved at the end of a digit pass.

--
assignee: tim.peters
components: Interpreter Core
messages: 409534
nosy: tim.peters
priority: normal
severity: normal
stage: needs patch
status: open
title: Minor speedup for bigint squaring
type: performance
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com