[issue46396] `Concatenate` should not raise any semantic errors

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: No, that would make the behavior normative. Let sleeping dogs lie. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-25 Thread Nikita Sobolev
Nikita Sobolev added the comment: I think that in case when we preserve the runtime checks, they should be covered by tests. Right now - they are not. So, I will switch my PR to the initial version with a new test case. Does this sound right? :) -- _

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-24 Thread Guido van Rossum
Guido van Rossum added the comment: "When in doubt, the status quo wins." Maybe we should just close this and the PR without merging. -- ___ Python tracker ___ __

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-24 Thread Ken Jin
Ken Jin added the comment: I'm a little conflicted on this specific use case (but maybe I'm biased because I wrote the checks :). I'm a strong proponent of less runtime checks. However, in this case, the exceptions serve as easy hints to the user, and they're meant to catch the most basic o

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-24 Thread Nikita Sobolev
Nikita Sobolev added the comment: PR is updated, now `Concatenate` does not raise any semantic errors: https://github.com/python/cpython/pull/30619 -- components: +Library (Lib) -Tests title: Typing: test invalid usages of `Concatenate` -> `Concatenate` should not raise any semantic