[issue46437] Non-required `hasattr` checks in `test_typing`

[Alex Waygood]

Change by Alex Waygood :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[miss-islington]

miss-islington  added the comment:


New changeset 07b12fdf5545a20e0fb7be9d6ad35344337e00ae by Miss Islington (bot) 
in branch '3.10':
bpo-46437: remove useless `hasattr` from `test_typing` (GH-30704)
https://github.com/python/cpython/commit/07b12fdf5545a20e0fb7be9d6ad35344337e00ae


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[miss-islington]

miss-islington  added the comment:


New changeset 3b51926ee9838e746a5cdb08c7eb985646bd133c by Miss Islington (bot) 
in branch '3.9':
bpo-46437: remove useless `hasattr` from `test_typing` (GH-30704)
https://github.com/python/cpython/commit/3b51926ee9838e746a5cdb08c7eb985646bd133c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[miss-islington]

Change by miss-islington :


--
pull_requests: +28906
pull_request: https://github.com/python/cpython/pull/30714

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 263c0dd16017613c5ea2fbfc270be4de2b41b5ad by Nikita Sobolev in 
branch 'main':
bpo-46437: remove useless `hasattr` from `test_typing` (#30704)
https://github.com/python/cpython/commit/263c0dd16017613c5ea2fbfc270be4de2b41b5ad


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +28905
pull_request: https://github.com/python/cpython/pull/30713

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[Nikita Sobolev]

Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +28900
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30704

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[Nikita Sobolev]

Change by Nikita Sobolev :


--
nosy: +kj

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46437] Non-required `hasattr` checks in `test_typing`

[Nikita Sobolev]

New submission from Nikita Sobolev :

There are several legacy `hasattr` checks that are always `True` in newer 
Python versions:

1. 
https://github.com/python/cpython/blob/d45cd2d20770f72a000ba6dfa9ac88dd49423c27/Lib/test/test_typing.py#L3516
2. 
https://github.com/python/cpython/blob/d45cd2d20770f72a000ba6dfa9ac88dd49423c27/Lib/test/test_typing.py#L5133

I think it is safe to delete them.

--
components: Tests
messages: 410974
nosy: sobolevn
priority: normal
severity: normal
status: open
title: Non-required `hasattr` checks in `test_typing`
type: behavior
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com