[issue46748] Python.h includes stdbool.h

STINNER Victor added the comment: > Thank you, Kumar & Victor, for fixing up the issue! You're welcome. I'm happy to see that you reduced the number of #include in the C API ;-) I made similar changes in bpo-45434. -- ___ Python tracker

[issue46748] Python.h includes stdbool.h

Petr Viktorin added the comment: Thank you, Kumar & Victor, for fixing up the issue! I meant to check the buildbots before closing the issue, but got side-tracked. -- stage: patch review -> resolved status: pending -> closed ___ Python tracker

[issue46748] Python.h includes stdbool.h

Erlend E. Aasland added the comment: Can we close this? -- nosy: +erlendaasland status: open -> pending ___ Python tracker ___ ___

[issue46748] Python.h includes stdbool.h

STINNER Victor added the comment: New changeset e182c660b63bc23420fb9f0593d77a3fa3b7f1c7 by Kumar Aditya in branch 'main': bpo-46748: Fix ctypes test_frozentable() (GH-31600) https://github.com/python/cpython/commit/e182c660b63bc23420fb9f0593d77a3fa3b7f1c7 --

[issue46748] Python.h includes stdbool.h

Change by Kumar Aditya : -- nosy: +kumaraditya303 nosy_count: 5.0 -> 6.0 pull_requests: +29723 pull_request: https://github.com/python/cpython/pull/31600 ___ Python tracker

[issue46748] Python.h includes stdbool.h

STINNER Victor added the comment: > New changeset 2c228a7b8f89e9ed8d390370abd771d4993b79d8 by Petr Viktorin in > branch 'main': > bpo-46748: Don't import in public headers (GH-31553) It seems like this change broke ctypes on some architectures like s390x:

[issue46748] Python.h includes stdbool.h

Petr Viktorin added the comment: New changeset 2c228a7b8f89e9ed8d390370abd771d4993b79d8 by Petr Viktorin in branch 'main': bpo-46748: Don't import in public headers (GH-31553) https://github.com/python/cpython/commit/2c228a7b8f89e9ed8d390370abd771d4993b79d8 --

[issue46748] Python.h includes stdbool.h

Change by Petr Viktorin : -- keywords: +patch pull_requests: +29674 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31553 ___ Python tracker ___

[issue46748] Python.h includes stdbool.h

Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46748] Python.h includes stdbool.h

Petr Viktorin added the comment: It is in C99, but in an optional header. IMO, including the header in the internals is perfectly OK, but opting everyone else in isn't very nice. i.e. it would probably be OK to use `_Bool`, the actual C99 keyword that `bool` is defined as. But that's ugly

[issue46748] Python.h includes stdbool.h

Eric Snow added the comment: On Mon, Feb 14, 2022 at 2:28 AM Petr Viktorin wrote: > Eric, is this necessary? Would an old-school `int` do? > Or should we say it's 2022 already and everyone needs to use stdbool.hfore > bools? I started using ``bool`` (stdbool.h) when I saw it specified in

[issue46748] Python.h includes stdbool.h

Petr Viktorin added the comment: Yes, stdbool.h is essentially a backport of C++'s bool type to C. -- ___ Python tracker ___ ___

[issue46748] Python.h includes stdbool.h

Serhiy Storchaka added the comment: Is it compatible with C++? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue46748] Python.h includes stdbool.h

New submission from Petr Viktorin : In main, cpython/pystate.h newly includes stdbool.h, providing a definition for `bool` that might be incompatible with other software. See here: https://github.com/cmusphinx/sphinxbase/pull/90 Eric, is this necessary? Would an old-school `int` do? Or