[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Enji Cooper]

Enji Cooper  added the comment:

Grégory: that will fix this issue, but what I really need is some of the other 
changes, like moving the getaddrinfo logic into a separate route (connect).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Grégory Starck]

Grégory Starck  added the comment:

Enji : you can use this then:

```
In [6]: class Fixed(logging.handlers.SysLogHandler):
   ...: def __init__(self, *a, **kw):
   ...: self.socket = None
   ...: super().__init__(*a, **kw)
   ...: def close(self):
   ...: if self.socket is None:
   ...: return
   ...: super().close()
```

that looks to be enough to prevent the issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Vinay Sajip]

Vinay Sajip  added the comment:

The 3.8 branch is security-fix-only now, I'm afraid. And I'm not sure it's 
worth backporting this.

--
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Enji Cooper]

Enji Cooper  added the comment:

Grégory: good question.

I would personally advocate for doing it out of selfish interests. 

I'm working with middleware based on 3.8 (moving to 3.9+ is non-trivial), and 
we have a common fault scenario where the system breaks if 
logging.handlers.SysLogHandler is instantiated and the target host cannot be 
resolved, like seen in the first comment.

Backporting the changes you referenced would make addressing the above issue 
easier, since the logic in connect(..) was moved into its own routine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Ned Deily]

Change by Ned Deily :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Grégory Starck]

Grégory Starck  added the comment:

I guess it could be done relatively easily.

but the question is more: should it be done ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Enji Cooper]

Enji Cooper  added the comment:

Yup! Looks like it! Just needs a back port.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Grégory Starck]

Grégory Starck  added the comment:

I think this is fixed in main, thanks to this:

https://github.com/python/cpython/blob/main/Lib/logging/handlers.py#L862-L863

--
nosy: +gstarck

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

[Enji Cooper]

New submission from Enji Cooper :

Something I noticed when trying to repro another issue:

% python
Python 3.8.13 (default, Mar 16 2022, 17:28:59)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import logging.handlers
>>> logging.handlers.SysLogHandler(address=("something-completely-bogus-doncha-know",
>>>  514))
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib/python3.8/logging/handlers.py", line 829, in __init__
ress = socket.getaddrinfo(host, port, 0, socktype)
  File "/usr/lib/python3.8/socket.py", line 918, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known
>>>
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python3.8/logging/__init__.py", line 2127, in shutdown
h.close()
  File "/usr/lib/python3.8/logging/handlers.py", line 892, in close
self.socket.close()
AttributeError: 'SysLogHandler' object has no attribute 'socket'
% python3.9
Python 3.9.11 (main, Mar 16 2022, 17:27:06)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import logging.handlers
>>> logging.handlers.SysLogHandler(address=("something-completely-bogus-doncha-know",
>>>  514))
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib/python3.9/logging/handlers.py", line 873, in __init__
ress = socket.getaddrinfo(host, port, 0, socktype)
  File "/usr/lib/python3.9/socket.py", line 954, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known
>>>
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python3.9/logging/__init__.py", line 2142, in shutdown
h.close()
  File "/usr/lib/python3.9/logging/handlers.py", line 936, in close
self.socket.close()
AttributeError: 'SysLogHandler' object has no attribute 'socket'

This is happening because logging.Handler is calling logging._addHandlerRef in 
logging.Handler.__init__ and _removeHandlerRef at exit via logging.shutdown(..).

--
components: Library (Lib)
messages: 416309
nosy: ngie
priority: normal
severity: normal
status: open
title: logging.handlers.SysLogHandler doesn't get cleaned up properly on exit 
if it throws an exception
type: behavior
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com