[issue4788] two bare except clauses are used in the ssl module

2008-12-30 Thread Giampaolo Rodola'

New submission from Giampaolo Rodola' billiej...@users.sourceforge.net:

From PEP-8:

 When catching exceptions, mention specific exceptions
 whenever possible instead of using a bare 'except:' clause.
 [...] 
 A bare 'except:' clause will catch SystemExit and KeyboardInterrupt
 exceptions, making it harder to interrupt a program with Control-C,
 and can disguise other problems.

The patch in attachment removes two bare except clauses used in ssl 
module.

--
components: Library (Lib)
files: ssl.patch
keywords: patch
messages: 78575
nosy: giampaolo.rodola
severity: normal
status: open
title: two bare except clauses are used in the ssl module
versions: Python 2.6, Python 2.7, Python 3.0, Python 3.1
Added file: http://bugs.python.org/file12499/ssl.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4788
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4788] two bare except clauses are used in the ssl module

2008-12-30 Thread Giampaolo Rodola'

Changes by Giampaolo Rodola' billiej...@users.sourceforge.net:


Added file: http://bugs.python.org/file12500/ssl-py3k.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4788
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4788] two bare except clauses are used in the ssl module

2008-12-30 Thread Giampaolo Rodola'

Changes by Giampaolo Rodola' billiej...@users.sourceforge.net:


--
nosy: +janssen

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4788
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4788] two bare except clauses are used in the ssl module

2008-12-30 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

socket.getpeername() can only raises an error of type socket.error, so 
the patch is valid and needed!

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4788
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4788] two bare except clauses are used in the ssl module

2008-12-30 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Fixed in r68089 and r68091.

--
nosy: +benjamin.peterson
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4788
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com