[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Roundup Robot added the comment: New changeset 66398e1307f4 by Tim Golden in branch 'default': Issue4905: use INVALID_FILE_ATTRIBUTES where appropriate. (Patch by Ulrich Eckhardt) http://hg.python.org/cpython/rev/66398e1307f4 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Tim Golden added the comment: Fixed on tip. Thanks for the issue and the original patch. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Changes by Tim Golden m...@timgolden.me.uk: -- assignee: - tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Changes by Tim Golden m...@timgolden.me.uk: -- versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Changes by Antoine Pitrou pit...@free.fr: -- components: +Extension Modules, Windows -Interpreter Core nosy: +brian.curtin, tim.golden stage: - patch review versions: +Python 3.2 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment: The patch looks fine to me -- nosy: +gagenellina ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
New submission from Ulrich Eckhardt eckha...@satorlaser.com: GetFileAttributes[W|A] returns a DWORD with this value when it couldn't determine the file's attributes. In the Python codebase, there are basically three values this is compared with, the above macro, 0x and (DWORD)-1, it should only be the macro. However, this macro isn't defined in some SDKs (I don't remember if those were early MSVC versions or some MS Windows CE SDKs), so we also need to work around that. I'm currently preparing a patch that resolves those including the workaround when the macro isn't defined. -- components: Interpreter Core messages: 79535 nosy: eckhardt severity: normal status: open title: Use INVALID_FILE_ATTRIBUTES instead of magic numbers versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers
Ulrich Eckhardt eckha...@satorlaser.com added the comment: The patch replaces remaining magic numbers with INVALID_FILE_ATTRIBUTES. -- keywords: +patch Added file: http://bugs.python.org/file12673/python-2.7-fileattrib-magic.0.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4905 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
