[issue5256] rlcompleter adds builtins when custom dict is used

STINNER Victor added the comment: This issue is not newcomer friendly, I remove the easy keyword. -- keywords: -easy nosy: +vstinner ___ Python tracker ___ ___

[issue5256] rlcompleter adds builtins when custom dict is used

Michele Orrù added the comment: Updated. Note that removing `eval` is necessary for the new logic of the function. -- Added file: http://bugs.python.org/file27586/issue5256.1.patch ___ Python tracker __

[issue5256] rlcompleter adds builtins when custom dict is used

Ezio Melotti added the comment: I would make the argument keyword-only. Changing the logic to avoid eval() might be OK, but IIUC is not related to this issue, and it should be done separately. The markup in the doc could be better (`...` should be ``...`` or a more specific directive that gener

[issue5256] rlcompleter adds builtins when custom dict is used

Michele Orrù added the comment: Updated with tip, and merged with documentation. -- Added file: http://bugs.python.org/file27569/issue5256.patch ___ Python tracker ___ ___

[issue5256] rlcompleter adds builtins when custom dict is used

Éric Araujo added the comment: Looks good to me. I wrote one comment on the doc patch review. -- ___ Python tracker ___ ___ Python-bug

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Éric Araujo : -- keywords: +needs review versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list maili

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Michele Orrù : Added file: http://bugs.python.org/file18427/rlcompleter_docs.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Michele Orrù : Removed file: http://bugs.python.org/file18426/rlcompleter_docs.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue5256] rlcompleter adds builtins when custom dict is used

Michele Orrù added the comment: Yes, it is. I think the user would expect that kind of behaviour. The attached patch updates the Doc. -- Added file: http://bugs.python.org/file18426/rlcompleter_docs.patch ___ Python tracker

[issue5256] rlcompleter adds builtins when custom dict is used

Éric Araujo added the comment: The report says “This behaviour may sometimes be unwanted. It would be nice to have an option”, so I’m requalifying as a RFE and adjusting versions. The patch changes behavior (search order was builtins, self.namespace and is now reversed), is this wanted? The

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Michele Orrù : -- nosy: +ezio.melotti, mark.dickinson, pitrou, r.david.murray ___ Python tracker ___ ___ Python-bugs-list ma

[issue5256] rlcompleter adds builtins when custom dict is used

Michele Orrù added the comment: The attached patch fixes this issue and provides some tests. -- keywords: +patch nosy: +maker Added file: http://bugs.python.org/file18421/rlcompleter.patch ___ Python tracker __

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Mark Lawrence : -- components: +Library (Lib) -None versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0 ___ Python tracker ___ ___

[issue5256] rlcompleter adds builtins when custom dict is used

Changes by Daniel Diniz : -- keywords: +easy stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue5256] rlcompleter adds builtins when custom dict is used

New submission from Armandas : When custom dictionary is used to create a completer, rlcompleter still uses __builtins__.__dict__ to search for completions (rlcompleter.py, global_matches()): for nspace in [builtins.__dict__, self.namespace]: ... This behaviour may sometimes be unwanted. It wou