[issue5287] logging package on IronPython
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Fixes checked into trunk py3k. -- resolution: accepted - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: I know - I just thought 2.6 was the priority for Michael, so I checked that in first, then got sidetracked...I'll get on it shortly. I should have left the issue as Open to remind me - correcting that now. -- resolution: fixed - accepted status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Antoine Pitrou pit...@free.fr added the comment: Rather than explicit testing for sys.platform, a try...except would be more flexible and more future-proof. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
STINNER Victor victor.stin...@haypocalc.com added the comment: IronPython provides sys._getframe but it throws an exception if you call it with a non-zero depth. Stupid question: why not fixing sys._getframe()? -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Michael Foord mich...@voidspace.org.uk added the comment: @Victor IronPython doesn't use Python stack frames, so tracking them and then constructing the objects on demand would add about a ~10% performance hit to IronPython. Even when it is done it is likely to be an option rather than on by default - using _getframe is usually a hack anyway. :-) @Antoine Could do that - it would have to trap ValueError. I'd be slightly worried about it masking other bugs. In previous versions of logging setting _srcfile to None was *the* mechanism for stopping the use of _getframe. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Michael Foord mich...@voidspace.org.uk added the comment: Attached is an alternative patch that wraps the call to findCaller in a try:...except. Added file: http://bugs.python.org/file13116/logging2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Fix checked into release26-maint. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Antoine Pitrou pit...@free.fr added the comment: Vinay, the fix should also be committed to trunk (unless the relevant code doesn't exist anymore), and to py3k. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5287] logging package on IronPython
Changes by Benjamin Peterson benja...@python.org: -- assignee: - vsajip nosy: +vsajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
