[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.7 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[A.M. Kuchling]

Changes by A.M. Kuchling a...@amk.ca:


--
nosy:  -akuchling

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[R. David Murray]

Changes by R. David Murray rdmur...@bitdance.com:


--
stage:  - patch review
type:  - feature request

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[A.M. Kuchling]

Changes by A.M. Kuchling li...@amk.ca:


--
assignee: akuchling - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[A.M. Kuchling]

A.M. Kuchling li...@amk.ca added the comment:

Thanks for the patches!  Two comments on the addchstr change:

* I think that, instead of checking for a list, the method should accept any 
Python sequence; a tuple is perfectly reasonable, for example, and if the code 
is changed to use PyCurses_ConvertToChType() instead of PyInt_Check(), it will 
accept a list of integers, a mixed list of ints and character strings, and even 
just strings.

* the documentation and error messages currently try to paper over all of the 
curses variants of addchstr(), waddchstr(), mvwaddchstr(), ..., covering them 
all up under the addchstr name.  This means that your submitted documentation 
patch is too detailed; it should look more like the insnstr() docs, which has 
[y,x,] as optional, and the text says something like Moves to y,x if 
specified, and then ...'.

The color_set() changes look OK; I'm going to try to break them out into a 
separate patch and commit them on their own.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[A.M. Kuchling]

Changes by A.M. Kuchling li...@amk.ca:


--
assignee: georg.brandl - akuchling

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

I am attaching the diff file for the Docs/library/curses.rst as 
lib_curses_rst.diff

Added file: http://bugs.python.org/file13204/lib_curses_rst.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

I am attaching the Docs/howto/curses.rst file as howto_curses_rst.diff

Added file: http://bugs.python.org/file13205/howto_curses_rst.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Changes by Steve Owens st...@integrityintegrators.net:


Removed file: http://bugs.python.org/file13205/howto_curses_rst.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Changes by Steve Owens st...@integrityintegrators.net:


Added file: http://bugs.python.org/file13206/howto_curses_rst.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Changes by Steve Owens st...@integrityintegrators.net:


Added file: http://bugs.python.org/file13207/whatsnew_2_7_rst.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Changes by Steve Owens st...@integrityintegrators.net:


Removed file: http://bugs.python.org/file13196/curses.rst

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Changes by Steve Owens st...@integrityintegrators.net:


Removed file: http://bugs.python.org/file13174/color_set_patch.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

I am not familiar with the process here, but I would like to continue 
to add additional support to the _cursesmodule.c file.  However, I am 
loathe to put too much functionality into any one patch.  Is there any 
way I can find out when this patch will be applied so that I can get 
latest and then move forward incrementally?

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

I have also added the addchstr family of functions.  The updated patch2
should include the previos patch since it has not been applied to the
repository as of this writing.  See also the unittest for the addchstr
method family.

I will update the docs and add those as well, but there is quite alot of
documentation that needs to be done and it is late, please let me know
if this will be an acceptable patch. I'm still new.

--
title: curses patch add color_set and wcolor_set functions - curses patch add 
color_set and wcolor_set , and addchstr family of functions
Added file: http://bugs.python.org/file13194/curses_patch2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

This is the addchstr unit test.

Added file: http://bugs.python.org/file13195/test_curses_addchstr.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

[Steve Owens]

Steve Owens st...@integrityintegrators.net added the comment:

This is a start on the documentation efforts.  I have updated the
recently modified curses.rst (how to) file.  Need direction in locating
all of the docs that are impacted by the changes I have introduced and I
will write them up.

Added file: http://bugs.python.org/file13196/curses.rst

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com