[issue5463] Compiler warning get_ulong is never used 3.x
Mark Dickinson dicki...@gmail.com added the comment: The latest patch looks good to me, and results in a much cleaner looking _struct.c. Thank you! One worry: the issue 4228 discussion suggests that the zipfile module still relies on the deprecated wrapping. I think this needs to be investigated (and fixed if necessary) before this patch can be applied. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5463] Compiler warning get_ulong is never used 3.x
Andreas Schawo andreas.sch...@gmail.com added the comment: Hi Mark, I've removed all overflow masking from _struct.c. Running the regression test test_struct failed for test_issue4228 wich I think have to be removed too because it tests the deprecated feature. I've tested the constraints with some values and got the expected overflow errors. So here's the new patch without overflow masking and deleted test_issue4228. The patch is just tested on windows. So when I get home I'll give it a try on Linux. -- Added file: http://bugs.python.org/file13304/struct_overflow_patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5463] Compiler warning get_ulong is never used 3.x
Changes by Andreas Schawo andreas.sch...@gmail.com: Removed file: http://bugs.python.org/file13288/get_ulong_patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5463] Compiler warning get_ulong is never used 3.x
Mark Dickinson dicki...@gmail.com added the comment: Thanks for the patch! Certainly it's desirable to get rid of this warning, especially as in this case the warning indicates a genuine problem: namely that there's unused code floating around. I think it would not be unreasonable to simply remove the code that's #ifdef'd away. It was there for backwards compatibility, and should no longer be needed in 3.0 and 3.1. -- message_count: 1.0 - 2.0 nosy: +marketdickinson nosy_count: 1.0 - 2.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5463] Compiler warning get_ulong is never used 3.x
New submission from Andreas Schawo andr...@schawo.de: When compiling the newest 3.x trunk I've got a compiler warning that get_ulong is defined but never used. I moved the function near the only place where it is used (disabled code). Now I have no more warnings. I don't know if it's of any use. -- components: Extension Modules files: get_ulong_patch.diff keywords: patch message_count: 1.0 messages: 83406 nosy: andreas.schawo nosy_count: 1.0 severity: normal status: open title: Compiler warning get_ulong is never used 3.x type: compile error versions: Python 3.1 Added file: http://bugs.python.org/file13288/get_ulong_patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
