Roundup Robot added the comment:
New changeset 5f8fe382f9db by Senthil Kumaran in branch '3.3':
#5609 - test_urllib coverage for url2pathname and pathname2url. Patch
http://hg.python.org/cpython/rev/5f8fe382f9db
New changeset 7b3f1c6a67d9 by Senthil Kumaran in branch 'default':
merge from 3.3
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
Thomas Fenzl added the comment:
The authoritative implementation of this functionality would be Microsoft's
PathCreateFromUrl
(http://msdn.microsoft.com/en-us/library/windows/desktop/bb773581%28v=vs.85%29.aspx)
and UrlCreateFromPath
Senthil Kumaran added the comment:
Thanks for the patch and test coverage. LGTM. I shall verify further and commit
it.
--
assignee: - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
Thomas Fenzl added the comment:
The tests work on linux, so I removed the check for nt.
Also I adapted them to the latest implementation using ':' instead of '|' as
drive letter separator.
--
keywords: +patch
nosy: +Thomas Fenzl
Added file:
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Maksim could you please respond to the comments on Rietveld, thanks.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
priority: - normal
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
___
New submission from Maksim Kozyarchuk maksim_kozyarc...@yahoo.com:
Added Unit Tests for nturl2path module.
http://codereview.appspot.com/32072/show
--
components: Tests
messages: 84590
nosy: Kozyarchuk
severity: normal
status: open
title: Create Unit Tests for nturl2path module
Maksim Kozyarchuk maksim_kozyarc...@yahoo.com added the comment:
Patch is available on Appshot, please review/approve.
http://codereview.appspot.com/32072/show
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
