[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Roundup Robot]

Roundup Robot added the comment:

New changeset 14d1018940cb by Serhiy Storchaka in branch '2.7':
Issue #5633: Fixed timeit when the statement is a string and the setup is not.
https://hg.python.org/cpython/rev/14d1018940cb

New changeset 89de73c0d848 by Serhiy Storchaka in branch '3.4':
Issue #5633: Fixed timeit when the statement is a string and the setup is not.
https://hg.python.org/cpython/rev/89de73c0d848

New changeset faea7c8bcb13 by Serhiy Storchaka in branch '3.5':
Issue #5633: Fixed timeit when the statement is a string and the setup is not.
https://hg.python.org/cpython/rev/faea7c8bcb13

New changeset fd01cbe4336e by Serhiy Storchaka in branch 'default':
Issue #5633: Fixed timeit when the statement is a string and the setup is not.
https://hg.python.org/cpython/rev/fd01cbe4336e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is more complicated patch, that not only fixes handling of callable setup, 
but also simplifies the implementation of timeit constructor.

--
Added file: 
http://bugs.python.org/file39360/timeit_callable_setup_refactor.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file39358/timeit_callable_setup.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Definitely there is a bug. The code of timeit is written to support string stmt 
and callable setup. Expected that locals available when the function is 
created, would be available when the function is executed. But this doesn't 
work. May be it worked in the earlier Python, I don't know. Due to the lack of 
tests this was unnoticed.

Here is simpler patch that fixes the support of callable setup with string stmt.

But I like Tim's approach (compile testing function using the single template), 
it makes the implementation simpler. I'll try to adapt it for current sources.

--
nosy: +serhiy.storchaka
stage:  -> patch review
versions: +Python 2.7, Python 3.4, Python 3.5 -Python 3.1, Python 3.2, Python 
3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Georg Brandl]

Changes by Georg Brandl :


--
assignee: georg.brandl -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5633] fix for timeit when the statement is a string and the setup is not (and tests)

[Tshepang Lekhonkhobe]

Changes by Tshepang Lekhonkhobe :


--
title: fix for timeit  when the statment is a string and the setup is not (and 
tests) -> fix for timeit when the statement is a string and the setup is not 
(and tests)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com