Kushal Das added the comment:
Here is a patch along with test case update which can be cleanly applied into
default.
--
nosy: +kushaldas
Added file: http://bugs.python.org/file29507/issue5713.patch
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
I think this should be considered a bug fix. While it is true that we are
handling something that is a more advanced feature of the smpt protocl than
what we are (currently) formally supporting in the module, the reality is that
if one uses smtplib to
Terry J. Reedy added the comment:
Given that David is usually more conservative about calling things bugs than I
am, knows more about this subject than me, and has explained that the change
will make smptlib act more sanely in the face of external errors, I am
reversing myself and agreeing
R. David Murray added the comment:
Sure, a new issue for making sure smtplib conforms to 5321 would be good (we
already did it for smptd; hopefully we didn't miss anything).
For the moment 5321 is the standard. There's a new one coming, where utf-8
will be allowed, but we're not quite ready
R. David Murray added the comment:
I had to rewrite the tests for 3.2, and I added tests to test all three cases
where 421 is returned. I'm in the process of merging this, but I'll upload the
patch so that Kushal can see the test structure for the followon patch.
--
Added file:
Roundup Robot added the comment:
New changeset bc538bc8e65d by R David Murray in branch '3.2':
#5713: Handle 421 error codes during sendmail by closing the socket.
http://hg.python.org/cpython/rev/bc538bc8e65d
New changeset cf5c40025af2 by R David Murray in branch '3.3':
Merge: #5713: Handle
Roundup Robot added the comment:
New changeset fbf54209de75 by R David Murray in branch '3.2':
#5713: fix timing issue in smtplib tests.
http://hg.python.org/cpython/rev/fbf54209de75
New changeset 0de74602692f by R David Murray in branch '3.3':
Merge: #5713: fix timing issue in smtplib tests.
R. David Murray added the comment:
Thanks Mark and Kushal.
--
assignee: barry -
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d068fcbe5009 by R David Murray in branch '3.3':
#5713: One more test_smtplib timing fix.
http://hg.python.org/cpython/rev/d068fcbe5009
New changeset fcef6a33de17 by R David Murray in branch 'default':
Merge: #5713: One more test_smtplib timing fix.
Barry A. Warsaw ba...@python.org added the comment:
The latest relevant RFC is 5321:
http://www.faqs.org/rfcs/rfc5321.html
smtplib should be reviewed for compliance with this updated spec.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy tjre...@udel.edu added the comment:
Smptlib is documented as RFC821/1869 based. So this is a request for a new
feature. I presume more would be required to bring it up to 2821/5321. Assuming
so, what is the rationale for adding just one new feature. This would mean
tacking
Mark Sapiro m...@msapiro.net added the comment:
I'm not completely sure about this, but here's my thoughts. In the
scenarios I've seen, the 421 reply/disconnect only occurs in response to
a RCPT which has an invalid address and follows several prior refused
RCPTs. In this case, I think the
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5713
___
___
Python-bugs-list mailing list
Jesús Cea Avión j...@jcea.es added the comment:
So, if I understand the issue and the RFC correctly, when receiving a
421, we should close the connection and, if the 421 was received in the
rcpt phase, give back a dictionary with all pending directions as
421 code, so the sending code knows they
New submission from Mark Sapiro m...@msapiro.net:
RFC821 upon which smtplib was originally based does not define a 421
status code and implies the server should only disconnect in response to
a QUIT command.
Subsequent extensions in RFC2821 (and now RFC5321) define situations
under which the
15 matches
Mail list logo
