[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Mitar]

Change by Mitar :


--
nosy: +mitar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy:  -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Daniele Varrazzo]

Daniele Varrazzo added the comment:

Added separate issue #17582 as ElementTree implementation doesn't depend on 
whatever causes the bug in xml.dom.minidom.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc added the comment:

minidom may be broken, but what's the issue with ElementTree?

 import xml.etree.cElementTree as etree
 doc = etree.fromstring('xml /')
 doc.set('attr', multiline\nvalue)
 etree.tostring(doc)
'xml attr=multiline#10;value /'

--
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Daniele Varrazzo]

Daniele Varrazzo added the comment:

ElementTree issue is with tabs:

In [1]: import xml.etree.cElementTree as etree

In [2]: doc = etree.fromstring('xml /')

In [4]: doc.set('attr', here\tthere)

In [5]: etree.tostring(doc)
Out[5]: 'xml attr=here\tthere /'

In [6]: etree.fromstring(_5).attrib['attr']
Out[6]: 'here there'

bye bye tab.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Daniele Varrazzo]

Daniele Varrazzo added the comment:

I was going to open an issue on itself about etree and tabs, but I've found 
this and thought it would have been marked as duplicate. If you don't think 
it's the case I will open it anyway.

I've added my comment because ElementTree is not reported in this page at all: 
I've been googling forever about ElementTree tabs attributes without result. 
I've found this (and the network of duplicates) only searching for less generic 
xml tabs into the python bug tracker, when I was already filing the bug.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Daniele Varrazzo]

Daniele Varrazzo added the comment:

Just got bitten by this bug, which affects xml.etree.ElementTree and 
cElementTree too. Any chance to have it fixed?

Note that lxml.etree is not affected by the bug and can be used as a 
replacement for the stdlib module if you happen to have some work to do.

--
nosy: +piro

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Yap Sok Ann]

Yap Sok Ann sok...@gmail.com added the comment:

Just want to mention that until the patch get included, it will be impossible 
to use the standard library to generate a working BCP (Bulk Copy Program) XML 
format file for SQL Server, which always requires a TERMINATOR=\r\n or 
TERMINATOR=#13;#10; attribute.

--
nosy: +sayap

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Jens Grivolla]

Changes by Jens Grivolla jens.grivo...@gmail.com:


--
nosy: +Jens.Grivolla

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Ralph Gauges]

Ralph Gauges ralph.gau...@bioquant.uni-heidelberg.de added the comment:

I tried to apply the minidom.diff patch below, but it seems that removing the 
two lines that replace the  and  characters is not a good idea.
It least in some files I now suddenly get  and  characters in text 
elements where there should be gt; and lt;

At least the part with the tabs seems to work now and if I add the two lines 
with the replace calls that got deleted by the patch, everything seems fine.

--
nosy: +gauges

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[W. Trevor King]

W. Trevor King wk...@drexel.edu added the comment:

And while we're at it, we should also

   .replace('', 'amp;').replace('', quot;).replace('', 'lt;')

which would have to go at the beginning to avoid double-escaping the ''.

We could use xml.sax.saxutils.escape to do all the escaping rather than 
chaining replaces:

   data = escape(data, {'':'quot;', '\r':'#xD;', '\n':'#xA;', '\t':'#x9;'})

which also escapes '' (not strictly required for attribute values, but 
shouldn't be harmful either).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[W. Trevor King]

W. Trevor King wk...@drexel.edu added the comment:

As a workaround until the patch gets included, you can import this monkey patch 
module.

--
nosy: +labrat
Added file: http://bugs.python.org/file18325/minidom.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Ezio Melotti]

Ezio Melotti ezio.melo...@gmail.com added the comment:

#7139 has been closed as duplicate of this and contains a few messages that 
might be worth reading.

--
nosy: +effbot, ezio.melotti, moriyoshi

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

minidom.patch had the new file listed before the old, so I've uploaded 
minidom.diff.  The patch is tiny and looks clean.  Tests have been repeated on 
Windows against 2.7 and are fine, so I believe this can be committed.

--
Added file: http://bugs.python.org/file18184/minidom.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Patched test_minidom and ran it test failed.  Went to patch minidom.py and it 
appears up to date, so no idea why the test failed, can someone please take a 
look as it's 04:30 BST, thanks.

--
nosy: +BreamoreBoy
versions: +Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Tomalak]

Tomalak m8r-t1tu...@mailinator.com added the comment:

@devon: Thanks for pointing  linking back here.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Devon]

Devon devon.rueck...@temboo.com added the comment:

see also a similar issue in etree: #6492

--
nosy: +devon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Tomalak]

Changes by Tomalak m8r-t1tu...@mailinator.com:


--
title: xml.dom.minidom does not escape newline characters within attribute 
values - xml.dom.minidom does not escape CR, LF and TAB characters within 
attribute values

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5752] xml.dom.minidom does not escape CR, LF and TAB characters within attribute values

[Francesco Sechi]

Changes by Francesco Sechi francesco.se...@iet.unipi.it:


--
nosy:  -sechi_francesco

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5752
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com