[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: The active issue for this is now 23441. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5845] rlcompleter should be enabled automatically

Victor Varvariuc added the comment: Here is the new issue (putting the link here for reference): http://bugs.python.org/issue22086 -- nosy: +Victor.Varvariuc ___ Python tracker _

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: This issue should have gone back to being a release blocker after the alpha release to fix the tab-as-indent issue, but obviously that didn't happen (I forgot about it myself). Please open a new issue requesting a fix for this bug (that tab doesn't work as i

[issue5845] rlcompleter should be enabled automatically

David Beazley added the comment: Funny thing, this feature breaks the interactive interpreter in the most basic way on OS X systems. For example, the tab key won't even work to indent. You can't even type the most basic programs into the interactive interpreter. For example: >>> for i in r

[issue5845] rlcompleter should be enabled automatically

Roundup Robot added the comment: New changeset 69c451851c71 by R David Murray in branch 'default': whatsnew: sys.__interactivehook__. (#5845) http://hg.python.org/cpython/rev/69c451851c71 -- ___ Python tracker _

[issue5845] rlcompleter should be enabled automatically

Jason R. Coombs added the comment: Added issue20411, revealed in 3.4b2. -- nosy: +jason.coombs ___ Python tracker ___ ___ Python-bugs-l

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: I would say it's now closed. If there's some fine tuning needed, separate issues should be opened. -- status: open -> closed ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Serhiy Storchaka added the comment: What is the status of this issue? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > The patch fixes the problem on my setup. A very minor glitch: after > manually emptying or removing the PYTHONSTARTUP history file, the > history is loaded with the content of ~/.python_history on the next > session. Yes, the only way to know if a history file

[issue5845] rlcompleter should be enabled automatically

Xavier de Gaye added the comment: The patch fixes the problem on my setup. A very minor glitch: after manually emptying or removing the PYTHONSTARTUP history file, the history is loaded with the content of ~/.python_history on the next session. -- ___

[issue5845] rlcompleter should be enabled automatically

Roundup Robot added the comment: New changeset 687dd81cee3b by Antoine Pitrou in branch 'default': Issue #5845: In site.py, only load readline history from ~/.python_history if no history has been read already. This avoids double writes to the history file at shutdown. http://hg.python.org/cpy

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: Attaching patch to only load history file if no history exists. -- keywords: -needs review resolution: -> fixed Added file: http://bugs.python.org/file31914/rl_history_guard.patch ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > When a user is not aware of this new feature and has been implementing > up to now her/his PYTHONSTARTUP file with the first example given in > python 3.3 documentation at > > http://docs.python.org/3/library/readline.html?highlight=readline#example > > then

[issue5845] rlcompleter should be enabled automatically

Xavier de Gaye added the comment: There is a backward compatibility issue with changeset d5ef330bac50 that enables tab-completion in the interactive interpreter by default. When a user is not aware of this new feature and has been implementing up to now her/his PYTHONSTARTUP file with the first

[issue5845] rlcompleter should be enabled automatically

Serhiy Storchaka added the comment: Do you know that the readline module first force rebind of TAB to insert-tab? -- ___ Python tracker ___ ___

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: Yeah, deferred blocker is fine with me. -- priority: release blocker -> deferred blocker ___ Python tracker ___

[issue5845] rlcompleter should be enabled automatically

Martin v. Löwis added the comment: If R. David agrees (assuming no patch is coming forward), it could be degrated to deferred-blocker, and the alpha phases could be used to see how annoyed people are with "tab not working". -- ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Steven D'Aprano added the comment: On 31/07/13 17:14, Larry Hastings wrote: > IMO the optimal solution is that tab preceded by only whitespace indents, and > tab preceded by any non-whitespace character attempts to complete. Can we > goad readline into behaving this way? Yes we can. Attached

[issue5845] rlcompleter should be enabled automatically

Larry Hastings added the comment: This issue seems to have stalled. But it's still marked as a release blocker, which means I can't release Python 3.4a1 in two days if this issue is still open. One of three things will happen: 1) This issue is marked "closed". 2) This issue is downgraded from

[issue5845] rlcompleter should be enabled automatically

Changes by anatoly techtonik : -- nosy: +techtonik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue5845] rlcompleter should be enabled automatically

Tshepang Lekhonkhobe added the comment: Also made it to the front-page of Hacker News[1], with better quality comments than the reddit thread. [1] https://news.ycombinator.com/item?id=5658062 -- ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: Take it with a large grain of Internet salt, but Ezio pointed me to the following reactions: http://www.reddit.com/r/Python/comments/1dq7sh/python_repl_finally_gets_tab_completion_by_default/ -- ___ Python tracker <

[issue5845] rlcompleter should be enabled automatically

Alexander Belopolsky added the comment: I am in AP's camp on the tab issue, but I think we can preserve "tab inserts tab" behavior at the continuation prompt. I don't like "indent at beginning of line." I have rlcompleter enabled in Python 2.6 and i get the following when I press tab: Pytho

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > I expect that a lot of users use the tab key to indent in the repl > (as well as in editors, smart enough editors can convert the tab > presses to spaces) The interpreter prompt is not a text editor at all. You can misuse it as one, but that's a loss of time a

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > Well, post it to python-dev and see what reaction you get :) I'm not interested in python-dev reactions here. For this kind of issue, we'll have hundreds of messages for and against the change without any useful content. The commit adds an often-requested fea

[issue5845] rlcompleter should be enabled automatically

Ronald Oussoren added the comment: I expect that a lot of users use the tab key to indent in the repl (as well as in editors, smart enough editors can convert the tab presses to spaces) -- ___ Python tracker __

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > It is a release blocker because it is a major usability regression. Really? You can press the space key to indent, it works as well as the tab key... -- ___ Python tracker __

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: Well, post it to python-dev and see what reaction you get :) I could be wrong, but I don't think I am (obviously). -- ___ Python tracker ___ __

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: Just to be clear how important I consider this, I would advocate for backing out this patch rather than releasing 3.4 with a broken tab key at the interactive prompt. But I'd rather have the patch *and* a working tab key. --

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: It is a release blocker because it is a major usability regression. -- ___ Python tracker ___ ___ Py

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > The tab-doesn't-indent still needs to be fixed before 3.4 is > released. I don't really understand why this would be a release blocker? The interpreter prompt is a convenience, we don't guarantee compatibility like with stdlib APIs. -- __

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: The tab-doesn't-indent still needs to be fixed before 3.4 is released. -- nosy: +larry priority: normal -> release blocker resolution: fixed -> status: closed -> open ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Mark Dickinson added the comment: Applied the OS X fix; reclosing. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue5845] rlcompleter should be enabled automatically

Roundup Robot added the comment: New changeset 82e92da929eb by Mark Dickinson in branch 'default': Issue #5845: avoid an exception at startup on OS X if no .editrc file exists. http://hg.python.org/cpython/rev/82e92da929eb -- ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > Now I don't know if I'm missing something painfully obvious, but > having to bang out space-space-space-space for every indent is > surely not going to be a win for usability ;-) Even if I am missing > something, surely so will a lot of other users. What *look

[issue5845] rlcompleter should be enabled automatically

Steven D'Aprano added the comment: I'm not able to test the patch at the moment, but since it essentially just uses the recipe in the docs, I expect it will have the same side-effect. Namely, it prevents you using the tab key to indent in the interactive interpreter. Now I don't know if I'm m

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > The attached fixes the issue for me. I'm not sure whether the try / > except should only be done on Apple, though. What's the behaviour > on Linux if there's no .inputrc file? Everything works fine under Linux (as usual :-)). There's no need to restrict the

[issue5845] rlcompleter should be enabled automatically

Mark Dickinson added the comment: The attached fixes the issue for me. I'm not sure whether the try / except should only be done on Apple, though. What's the behaviour on Linux if there's no .inputrc file? -- Added file: http://bugs.python.org/file30148/issue5845_osx_fix.patch _

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > So I'm failing to find any documentation for libedit, but it looks as > though this error occurs if rl_read_init_file fails to find an > .editrc file in the appropriate place. If I create an empty .editrc > file in my home directory, the error disappears. (Ha

[issue5845] rlcompleter should be enabled automatically

Mark Dickinson added the comment: So I'm failing to find any documentation for libedit, but it looks as though this error occurs if rl_read_init_file fails to find an .editrc file in the appropriate place. If I create an empty .editrc file in my home directory, the error disappears. (Having

[issue5845] rlcompleter should be enabled automatically

Mark Dickinson added the comment: More information: readline.read_init_file() produced the same traceback before this commit, so all that's changed is that we're now calling this at interpreter startup. It looks like I'm using the system libedit: iwasawa:cpython mdickinson$ otool -L build/li

[issue5845] rlcompleter should be enabled automatically

Mark Dickinson added the comment: On OS X 10.6, I now get the following message at interpreter startup: iwasawa:cpython mdickinson$ ./python.exe Python 3.4.0a0 (default:d5ef330bac50, May 6 2013, 13:05:57) [GCC 4.2.1 (Apple Inc. build 5664)] on darwin Type "help", "copyright", "credits" or "li

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: End-users will hopefully rejoice :) -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Roundup Robot added the comment: New changeset d5ef330bac50 by Antoine Pitrou in branch 'default': Issue #5845: Enable tab-completion in the interactive interpreter by default, thanks to a new sys.__interactivehook__. http://hg.python.org/cpython/rev/d5ef330bac50 -- nosy: +python-dev _

[issue5845] rlcompleter should be enabled automatically

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: In the spirit of pushing this forward, here is an updated patch using the sys.__interactivehook__ approach. I didn't add any tests since it doesn't seem very easy to write any. If nobody objects, I would like to commit this soon. -- Added file: http:/

[issue5845] rlcompleter should be enabled automatically

Changes by Antoine Pitrou : Added file: http://bugs.python.org/file30098/c43e264256e4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5845] rlcompleter should be enabled automatically

Changes by Tshepang Lekhonkhobe : -- versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue5845] rlcompleter should be enabled automatically

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5845] rlcompleter should be enabled automatically

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue5845] rlcompleter should be enabled automatically

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue5845] rlcompleter should be enabled automatically

Changes by Steven D'Aprano : -- nosy: +stevenjd ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: FTR, I tried checking sys.ps1 instead of argv but it’s the same problem. -- ___ Python tracker ___ ___

[issue5845] rlcompleter should be enabled automatically

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: > sys.__interactivehook__ has the benefit of being cleanly settable from python > code. > But it might well be a YAGNI idea. I’ll ask python-dev about that. For the moment, I prefer the idea of a new sys.interactive attribute (boolean). >> $PYTHONSTARTUP doesn'

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : -- Removed message: http://bugs.python.org/msg143617 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Removed file: http://bugs.python.org/file23108/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue5845] rlcompleter should be enabled automatically

Cherniavsky Beni added the comment: [sorry, html mail was bad idea] On Tue, Sep 6, 2011 at 17:54, Antoine Pitrou wrote: Éric Araujo added the comment: > > It's more useful to have a hook called when entering interactive mode, > > rather than a flag > > that's set from the beginning: > We alr

[issue5845] rlcompleter should be enabled automatically

Cherniavsky Beni added the comment: On Tue, Sep 6, 2011 at 17:54, Antoine Pitrou wrote: It covers the user's desire customization very well (esp. if it worked with -i). sys.__interactivehook__ has the benefit of being cleanly settable from python code. But it might well be a YAGNI idea. $PYTH

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: > Easily detecting interactive mode is of general interest for > customization. Thanks for the feedback. We could open a feature request for that, and/or ask python-ideas. > What if C also set sys.flags.interactive in "python" mode, or exposed > sys.flags.implic

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > > It's more useful to have a hook called when entering interactive mode, > > rather than a flag > > that's set from the beginning: > We already have such a hook: $PYTHONSTARTUP $PYTHONSTARTUP doesn't work with -i --

[issue5845] rlcompleter should be enabled automatically

Cherniavsky Beni added the comment: Easily detecting interactive mode is of general interest for customization. 1. What if C also set sys.flags.interactive in "python" mode, or exposed sys.flags.implicit_interactive (but with better name)? 2. It's more useful to have a hook called when ente

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: We can’t just decide to enable completion by checking “'readline' in sys.modules” in site, because it always returns False. site is imported in Python/pythonrun.c, and I guess that Modules/main.c is run afterwards. More importantly, I think the import of readl

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: > Updated patch (not using Mercurial, looks like I haven’t enough > bandwidth to push all those changesets). I think there's a bug in the way you are detecting interactive mode: $ ./python -c "import sys; print(sys.stdin.isatty())" True -- __

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: Interestingly, there's already the following code in Modules/main.c: if ((Py_InspectFlag || (command == NULL && filename == NULL && module == NULL)) && isatty(fileno(stdin))) { PyObject *v; v = PyImport_ImportModule("readline");

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: Updated patch (not using Mercurial, looks like I haven’t enough bandwidth to push all those changesets). -- Added file: http://bugs.python.org/file22936/fix-5845.diff ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Removed file: http://bugs.python.org/file21399/fix-5845.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Removed file: http://bugs.python.org/file21402/d1cbf0347eb4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Removed file: http://bugs.python.org/file21401/c43e264256e4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Removed file: http://bugs.python.org/file21397/a5bded1b8db4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Added file: http://bugs.python.org/file21402/d1cbf0347eb4.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5845] rlcompleter should be enabled automatically

Changes by Martin v. Löwis : Added file: http://bugs.python.org/file21401/c43e264256e4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5845] rlcompleter should be enabled automatically

Changes by Martin v. Löwis : Removed file: http://bugs.python.org/file21398/c43e264256e4.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: Please ignore the generated patches, left here for Martin’s benefit, and review the manually attached fix-5845.diff. I have used read_init_file instead of hard-coding tab (it’s anyway the default for readline). I may have repeated the same info in too much doc

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : Added file: http://bugs.python.org/file21398/c43e264256e4.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : -- keywords: +patch Added file: http://bugs.python.org/file21397/a5bded1b8db4.diff ___ Python tracker ___ ___

[issue5845] rlcompleter should be enabled automatically

Changes by Éric Araujo : -- hgrepos: +9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue5845] rlcompleter should be enabled automatically

Ned Deily added the comment: readline.read_init_file() does work with libedit. The directives read have to be in libedit format. -- ___ Python tracker ___ _

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: Ned, does readline.read_init_file() with libedit? -- versions: -Python 3.2 ___ Python tracker ___ ___

[issue5845] rlcompleter should be enabled automatically

Martin v. Löwis added the comment: There is no readline support on Windows at all, so I don't think the Windows installer can be affected. I'm uncertain what the proposed change to Python is at this point, though. -- ___ Python tracker

[issue5845] rlcompleter should be enabled automatically

Ned Deily added the comment: Nosying Martin: any Windows installer concerns? -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-l

[issue5845] rlcompleter should be enabled automatically

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg123702 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue5845] rlcompleter should be enabled automatically

Ned Deily added the comment: Keep in mind that the Python readline module may be linked to either GNU readline or the BSD editline (libedit) library and they have different command strings. Note the warning here: http://docs.python.org/dev/py3k/library/readline.html Here's a snippet of what

[issue5845] rlcompleter should be enabled automatically

Ned Deily added the comment: Keep in bind that there the Python readline module may be linked to either GNU readline or the BSD editline (libedit) library and they have different command strings. Note the warning here: http://docs.python.org/dev/py3k/library/readline.html Here's a snippet o

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: I think TAB is the key expected by most people, so let's make it the default. As for the location, site.py is an adequate one IMO. -- components: +Library (Lib) -Interpreter Core versions: +Python 3.2 ___ Python trac

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: Okay, that’s one question answered. Still to solve: How to bind the right key? (“But perhaps tab isn’t the right key to bind. I think inputrc could set it to something different, perhaps shell rc files too. Is there an API to get this setting, does readline.so

[issue5845] rlcompleter should be enabled automatically

R. David Murray added the comment: for what it is worth, I am +1 on having completion and history file work by default. The sqlite3 command line does this, for example. I think it is what unix user expect nowadays, and I think it is reasonable. Looking at my home directory, it would appear

[issue5845] rlcompleter should be enabled automatically

Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue5845] rlcompleter should be enabled automatically

Changes by lesmana : -- nosy: +lesmana ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/ma

[issue5845] rlcompleter should be enabled automatically

Antoine Pitrou added the comment: He, adding completion is also something I find myself adding on every box on which I use Python... -- nosy: +pitrou ___ Python tracker ___ _

[issue5845] rlcompleter should be enabled automatically

Éric Araujo added the comment: What would be the right place for this to happen? I first thought of site.py, but -S would then turn off readline support. Does it have to be done somewhere in C land? But perhaps tab isn’t the right key to bind. I think inputrc could set it to something different

[issue5845] rlcompleter should be enabled automatically

Changes by Cherniavsky Beni : -- components: +Interpreter Core type: -> feature request versions: +Python 2.7, Python 3.1 ___ Python tracker ___ _

[issue5845] rlcompleter should be enabled automatically

New submission from Cherniavsky Beni : An interactive prompt should offer working completion out-of-the-box, without requiring every Python user on earth to create a $PYTHONSTARTUP with '''import readline; readline.parse_and_bind("tab: complete")'''. Note that it should work not only when Python