[issue5940] Wrong type check in check_library_list

[Tarek Ziadé]

Tarek Ziadé ziade.ta...@gmail.com added the comment:

fixed in r72379 

Thanks David !

Notice that this bug exists in Python 3.0 too unfortunately.

So I have applied the fix in the 3.0 release branch as well (r72380)

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5940
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5940] Wrong type check in check_library_list

[Cournapeau David]

New submission from Cournapeau David da...@ar.media.kyoto-u.ac.jp:

There is a bug in the function check_library_list. Assuming there are
some libraries in the distribution instance, the function checks that
lib[0] is a string, but the test checks exactly the contrary (line 137
of build_clib.py).

This is pretty serious, as any code using libraries will fail to build
on python3. The fix is trivial, though. I think this should be fixed for
python 3.1

--
assignee: tarek
components: Distutils
messages: 87224
nosy: cdavid, tarek
severity: normal
status: open
title: Wrong type check in check_library_list
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5940
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5940] Wrong type check in check_library_list

[Tarek Ziadé]

Tarek Ziadé ziade.ta...@gmail.com added the comment:

Good catch !

Obviously this was introduced when the Python 2 version was
refactored for Python 3

(in python 2 its if type(lib[0]) is not StringType)

I shall fix this today or tonite (I need to add test coverage
for this command)

--
priority:  - critical

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5940
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com