[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Tal Einat added the comment: Please do, Ananthakrishnan! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Ananthakrishnan added the comment: I want to do a PR,if this is still needeed. -- nosy: +Ananthakrishnan ___ Python tracker ___ ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Tal Einat added the comment: Ivan, can you supply a PR or would you like someone else to do so? -- nosy: +taleinat ___ Python tracker ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: LGTM. > What should I write instead of _? (ValueError, OSError) > And will the next call be effective (do anything), if we have already set the > limit with the testing call? This doesn't matter. We test that it doesn't crash

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Ivan Zakharyaschev added the comment: And will the next call be effective (do anything), if we have already set the limit with the testing call? -- ___ Python tracker

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Ivan Zakharyaschev added the comment: Thanks! I also thought about this simplest way. What about this: diff --git a/Python/Lib/test/test_resource.py b/Python/Lib/test/test_resource.py index de29d3b..bec4440 100644 --- a/Python/Lib/test/test_resource.py +++

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: The simplest way is to try passing the limit as a tuple resource.setrlimit(resource.RLIMIT_CPU, (100, 100)) and skip the test if it failed. -- ___ Python tracker

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Ivan Zakharyaschev added the comment: >>> import resource >>> resource.getrlimit(resource.RLIMIT_CPU) (7200, 7260) -- ___ Python tracker

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: What does resource.getrlimit(resource.RLIMIT_CPU) return? -- ___ Python tracker ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Ivan Zakharyaschev added the comment: > New changeset a4c85f9b8f58 by Serhiy Storchaka in branch '2.7': Issue #6083: Fix multiple segmentation faults occured when PyArg_ParseTuple http://hg.python.org/cpython/rev/a4c85f9b8f58 This test has a problem: though it tests not the

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Martin Panter : -- dependencies: +resource.prlimit(int, int, str) crashs ___ Python tracker ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Stefan Krah stefan-use...@bytereef.org: -- nosy: -skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___ ___ Python-bugs-list

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Serhiy Storchaka storch...@gmail.com: -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___ ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: Accepting an arbitrary sequence when (...) is used in the format string was introduced in changeset 0ef1071cb7fe. -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: FreeBSD 6.4 and Windows test failures was fixed in changesets 8fb98fb758e8 and ec70abe8c886. -- assignee: - serhiy.storchaka resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: Oh, I shouldn't close this until this dangerous feature will be deprecated. -- assignee: serhiy.storchaka - resolution: fixed - stage: committed/rejected - needs patch status: closed - open ___ Python tracker

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Stefan Krah added the comment: The FreeBSD 6.4 bot is failing, too. Note that the other functions in test_returnfuncptrs.py do this in order to get strchr(): dll = CDLL(_ctypes_test.__file__) get_strchr = dll.get_strchr get_strchr.restype = CFUNCTYPE(c_char_p, c_char_p, c_char)

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: There are 6 different ways to get a function (see comment around PyCFuncPtr_new() in Modules/_ctypes/_ctypes.c). The other tests just use other ways. I'm more carefully read ctype code and found my mistake. Need to import my_strchr, and not strchr.

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Roundup Robot added the comment: New changeset a4c85f9b8f58 by Serhiy Storchaka in branch '2.7': Issue #6083: Fix multiple segmentation faults occured when PyArg_ParseTuple http://hg.python.org/cpython/rev/a4c85f9b8f58 New changeset 4bac47eb444c by Serhiy Storchaka in branch '3.2': Issue #6083:

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: I do not have possibility and desires blind-repair a test on alien platform, so just temporarily disable a new test in Lib/ctypes/test/test_returnfuncptrs.py on Windows. If someone has a desire to fix it fell free to do this. I do not close this issue

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: serhiy.storchaka - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___ ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Gregory P. Smith added the comment: Serhiy's patch looks good to me. -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___ ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Serhiy Storchaka added the comment: Here is a patch which get rid of all three PyArg_ParseTuple usage with parsing nested sequences. Thanks Evgeny for reproducers. -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file27567/PyArg_ParseTuple_refcount.patch

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___ ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Let me summarize the issue: the PyArg_ParseTuple format code 'O' returns a borrowed reference. However, when the 'O' code appears inside parenthesis, there may not be an object to hold the reference to borrow from. This

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Attached patch passes the regrtest and makes test-functools.py raise an exception rather than crash. The proposed change will make functions like partial.__setstate__ require tuple argument even though currently it would

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Eugene Kapun abacabadabac...@gmail.com added the comment: Actually, this can't be fixed without modifying C API methods PyArg_ParseTuple and PyArg_ParseTupleAndKeywords, because it's possible to make an object deallocated before PyArg_ParseTuple returns, so Py_INCREF immediately after parsing

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Eugene Kapun abacabadabac...@gmail.com: Added file: http://bugs.python.org/file19617/test-ctypes.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

Changes by Eugene Kapun abacabadabac...@gmail.com: Added file: http://bugs.python.org/file19618/test-functools.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6083 ___