[issue6500] urllib2 maximum recursion depth exceeded

Roundup Robot added the comment: New changeset d34fdd1736f2 by Serhiy Storchaka in branch '2.7': Issue #6500: Fixed infinite recursion in urllib2.Request.__getattr__(). https://hg.python.org/cpython/rev/d34fdd1736f2 -- ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

Serhiy Storchaka added the comment: Thank you for the review Senthil. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

Berker Peksag added the comment: Thank you Ezio, I'll commit this tomorrow. -- assignee: jhylton -> berker.peksag ___ Python tracker ___

[issue6500] urllib2 maximum recursion depth exceeded

Changes by Ezio Melotti : -- stage: patch review -> commit review ___ Python tracker ___

[issue6500] urllib2 maximum recursion depth exceeded

Berker Peksag added the comment: Here is a patch for 2.7. I don't think backporting 9eceb618274a to 2.7 is worth the effort for this, so I just fixed the __getattr__ method and added a test. -- keywords: +patch nosy: +berker.peksag stage: needs patch - patch review Added file:

[issue6500] urllib2 maximum recursion depth exceeded

Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6500 ___ ___

[issue6500] urllib2 maximum recursion depth exceeded

Jeremy Hylton jer...@alum.mit.edu added the comment: Ok. I'll take a look, too. Jeremy On Sat, Feb 27, 2010 at 4:30 AM, Ezio Melotti rep...@bugs.python.org wrote: Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +orsenthil status: pending - open

[issue6500] urllib2 maximum recursion depth exceeded

New submission from simon nku...@gmail.com: def __getattr__(self, attr): # XXX this is a fallback mechanism to guard against these # methods getting called in a non-standard order. this may be # too complicated and/or unnecessary. # XXX should the __r_XXX

[issue6500] urllib2 maximum recursion depth exceeded

Ezio Melotti ezio.melo...@gmail.com added the comment: That __getattr__ was removed in r70815 and in Python 3.1 it's OK. The change wasn't backported to the trunk though. Assigning to Jeremy to see what he thinks about it. -- assignee: - jhylton nosy: +ezio.melotti, jhylton priority: