[issue6519] Reorder 'with' statement for files in Python Tutorial

Mariatta Wijaya added the comment: New changeset 81c05ccc10d044584dff3a69ee531094ed76ee2c by Mariatta in branch '3.6': bpo-6519: Improve Python Input Output Tutorial (GH-2143) (GH-2145) https://github.com/python/cpython/commit/81c05ccc10d044584dff3a69ee531094ed76ee2c --

[issue6519] Reorder 'with' statement for files in Python Tutorial

Mariatta Wijaya added the comment: Thanks everyone! I merged the PR and backported to 3.6 and 3.5. There are a bunch of conflicts when trying to backport to 2.7, so I decided not to bother. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions:

[issue6519] Reorder 'with' statement for files in Python Tutorial

Mariatta Wijaya added the comment: New changeset 5a86154a931083e6a9f9bdf9cc8b3bc33abb673d by Mariatta in branch '3.5': bpo-6519: Improve Python Input Output Tutorial (GH-2143) (GH-2146) https://github.com/python/cpython/commit/5a86154a931083e6a9f9bdf9cc8b3bc33abb673d --

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Mariatta Wijaya : -- pull_requests: +2195 ___ Python tracker ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Mariatta Wijaya : -- pull_requests: +2196 ___ Python tracker ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Mariatta Wijaya added the comment: New changeset bd4e9e0ca96dabf33605d9b1fd1e0562ece8ae18 by Mariatta (Andrew Kuchling) in branch 'master': bpo-6519: Improve Python Input Output Tutorial (GH-2143) https://github.com/python/cpython/commit/bd4e9e0ca96dabf33605d9b1fd1e0562ece8ae18 --

[issue6519] Reorder 'with' statement for files in Python Tutorial

A.M. Kuchling added the comment: PR filed against master: https://github.com/python/cpython/pull/2143 -- pull_requests: +2193 ___ Python tracker ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Mariatta Wijaya added the comment: @akuchling Can you prepare a PR on GitHub? -- nosy: +Mariatta ___ Python tracker ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Berker Peksag : -- versions: +Python 2.7 ___ Python tracker ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Berker Peksag added the comment: The patch looks good to me. I think we can tweak the content a bit. I left some comments on Rietveld. Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 -Python 2.7, Python 3.2, Python 3.3,

[issue6519] Reorder 'with' statement for files in Python Tutorial

A.M. Kuchling added the comment: Good suggestion -- here's a patch that moves it and rewrites a little. -- nosy: +akuchling Added file: http://bugs.python.org/file45374/issue6519.txt ___ Python tracker

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +chris.jerdonek versions: +Python 3.3, Python 3.4 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6519 ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6519 ___ ___ Python-bugs-list

[issue6519] Reorder 'with' statement for files in Python Tutorial

Ezio Melotti ezio.melo...@gmail.com added the comment: All the examples there assume that a file object called f has already been created. Using a 'with' there it's not a good idea because the users will have to keep the instructions indented under the 'with'. However I agree that it would be

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti priority: - low ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6519 ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

New submission from Jerzy Jalocha N jjalo...@gmail.com: Actually, the Python Tutorial recommends the use of the 'with' statement in Section 7.2.1. Methods of File Objects: It is good practice to use the with keyword when dealing with file objects. [etc.] But the example and description are