Serhiy Storchaka added the comment:
I have opened a new issue16760 for regex HOWTO.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
___
Georg Brandl ge...@python.org added the comment:
Should be fixed now in r83218. I've removed the class directives, and put
generic class name substitutes regex and pattern in the method
descriptions, like we do for contextmanager.__enter__. I've also removed the
compatibility info, and
Terry J. Reedy tjre...@udel.edu added the comment:
I believe these patches are wrong, at least in part, and should be reverted.
1.The re module no longer has either a class RegexObject or a class
MatchObject. (They are now _sre.SRE_Pattern and _sre.SRE_Match.) So
the previous reference to
Brian Curtin cur...@acm.org added the comment:
I'm guessing assigning to Christian was accidental - taking it back for myself.
--
assignee: christian.heimes - brian.curtin
priority: low - normal
stage: committed/rejected -
___
Python tracker
Brian Curtin cur...@acm.org added the comment:
How does this patch look? It changes RegexObject to _sre.SRE_Pattern and
MatchObject to _sre.SRE_Match. Additionally, references are used to link to
those classes generically as match objects or compiled regular expressions
rather than the fake
Ezio Melotti ezio.melo...@gmail.com added the comment:
The patch looks good to me, but I'm not sure if it's a good idea to use
_sre.SRE_*. I think these are implementation details and even if they should be
mentioned somewhere, they clutter the doc IMHO.
2. I believe it is the policy that
Brian Curtin cur...@acm.org added the comment:
I didn't actually want to use _sre.SRE_* but I'm not exactly sure how to hide
it. It's more correct that way, but it takes this issue the wrong direction by
exposing it.
I think it should be denoted as a class but with a generic name, if that's
R. David Murray rdmur...@bitdance.com added the comment:
Please note that my original suggestion was to make them *section* links
(:ref:s). As Terry says, they are not real classes and should not be marked up
as such. Nor should the internal class names be exposed.
Terry: [] notation is
Brian Curtin cur...@acm.org added the comment:
Fixed in trunk (r79430), release26-maint (r79631), py3k (r79434), and
release31-maint (r79435). Thanks for the patch.
--
assignee: georg.brandl - brian.curtin
resolution: - fixed
stage: needs patch - committed/rejected
status: open -
Asheesh Laroia ashe...@asheesh.org added the comment:
Er, ignore my comment then!
If this is reviewed, can it get committed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
___
Asheesh Laroia ashe...@asheesh.org added the comment:
Hey Ryan,
I took a look at the diff you attached here. It looks like you did
There are some whitespace-only changes -- for example, you remove and then
re-insert the line beginning with The name of the last matched capturing
group.
Can
Brian Curtin cur...@acm.org added the comment:
I've reviewed the patch and do not see any unnecessary whitespace changes in
his patch.
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
Changes by Ryan Arana ryan.ar...@gmail.com:
Removed file: http://bugs.python.org/file16274/MatchObjectLinksFix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
___
Ryan Arana ryan.ar...@gmail.com added the comment:
I tried to format the methods of the class(es) as they are formatted in other
files, which is why I added the whitespace.
I can go back and remove that if that's what would be preferred.
--
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
___
___
Python-bugs-list
Ryan Arana ryan.ar...@gmail.com added the comment:
Added .. class:: MatchObject and .. class:: RegexObject directives.
--
Added file: http://bugs.python.org/file16427/MatchObjectLinksFix.diff
___
Python tracker rep...@bugs.python.org
Asheesh Laroia ashe...@asheesh.org added the comment:
Hey all,
I think this is ready. Can someone review the patch?
--
nosy: +Asheesh.Laroia
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
It would be simpler to add a .. class:: MatchObject directive.
Also, RegexpObject should be handled as well.
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
Asheesh Laroia ashe...@asheesh.org added the comment:
Ryan -- would you take a further look at this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6538
___
Ryan Arana ryan.ar...@gmail.com added the comment:
Changed all occurrences of :class:`MatchObjects` to :ref:`match-objects` in
/Doc/library/re.rst
These changes were made to rev 78277.
--
keywords: +patch
nosy: +rarana
Added file:
New submission from R. David Murray rdmur...@bitdance.com:
In the re documentation MatchObject is marked up as a class, but since
there's no declaration of it as a class (it's a section instead) it
doesn't get turned into a hyperlink. It would be useful if it did link
to the appropriate
21 matches
Mail list logo
