Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset e64bec91ac91 by Richard Oudkerk in branch 'default':
Issue #14669: Skip multiprocessing connection pickling test on MacOSX
http://hg.python.org/cpython/rev/e64bec91ac91
--
Changes by Andrew Grover andy.gro...@gmail.com:
--
nosy: -Andrew.Grover
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Bill Janssen bill.jans...@gmail.com added the comment:
I'm guessing these things are due to interaction with some Apple
security update, as the buildbots were working well 8 months ago.
Bill
On Wed, Sep 7, 2011 at 4:01 PM, Nick Coghlan rep...@bugs.python.org wrote:
Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment:
The feature patch for sendmsg/recvmsg support came with a swathe of new tests,
and the failures are in those new tests rather than anything breaking in the
old ones.
As Charles-François noted though, it doesn't look like the feature
Changes by Michael Schurter m...@schmichael.com:
--
nosy: +schmichael
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
Closing the feature request as complete. The remaining Mac OS X buildbot issues
now have their own tracker item: #12958
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
superseder: - test_socket
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Python-bugs-list mailing list
Nick Coghlan ncogh...@gmail.com added the comment:
If Bill gets a chance to investigate this before the weekend, great, otherwise
my plan to stop making noise in the buildbot results will be to:
1. Create a separate issue specifically for the errors reported by the Mac OS X
buildbots
Bill Janssen bill.jans...@gmail.com added the comment:
I'll take a look at this next week, when I'm more on-line again.
Bill
2011/8/25 Charles-François Natali rep...@bugs.python.org:
Charles-François Natali neolo...@free.fr added the comment:
The OS X buildbots show some failures:
It
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
resolution: fixed -
stage: committed/rejected - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
Nick Coghlan ncogh...@gmail.com added the comment:
Putting this back to open until we decide what to do about the OS X test
failures. It sounds like it could really do with some more poking and prodding
to figure out whether or not it poses a potential security risk or is just a
relatively
Charles-François Natali neolo...@free.fr added the comment:
The OS X buildbots show some failures:
It seems to fail consistently on every OS X version.
I've had another look both at the code and the test, and couldn't find anything
wrong with it.
Since there are a number of known bugs
Charles-François Natali neolo...@free.fr added the comment:
Here's a patch skipping testFDPassSeparate and
testFDPassSeparateMinSpace on OS X 10.5, due to known kernel bugs
(see http://developer.apple.com/library/mac/#qa/qa1541/_index.html).
For InterruptedSendTimeoutTest and
Charles-François Natali neolo...@free.fr added the comment:
As noted by Antoine, the OS X 10.5 buildbots are also failing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
David Watson bai...@users.sourceforge.net added the comment:
On Tue 23 Aug 2011, Nick Coghlan wrote:
As you can see, I just pushed a change that removed the new
methods from SSLSocket objects. If anyone wants to step up with
a valid use case (not already covered by wrap_socket),
preferably
Charles-François Natali neolo...@free.fr added the comment:
However, in doing this, I noticed that these methods will, at best, work
during the time between connection and the socket going secure and were not
added to the list of methods that the SSL is documented as exposing. Perhaps
we
Antoine Pitrou pit...@free.fr added the comment:
However, in doing this, I noticed that these methods will, at best,
work during the time between connection and the socket going secure
and were not added to the list of methods that the SSL is documented
as exposing. Perhaps we should just
Nick Coghlan ncogh...@gmail.com added the comment:
That's the part I'm questioning though. I'm not clear why you'd ever do that
instead of doing everything on the original socket before invoking
ssl.wrap_socket.
What I missed on the original patch before committing it (mea culpa) is that
the
Antoine Pitrou pit...@free.fr added the comment:
That's the part I'm questioning though. I'm not clear why you'd ever do
that instead of doing everything on the original socket before invoking
ssl.wrap_socket.
What I missed on the original patch before committing it (mea culpa) is
that
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset fd10d042b41d by Nick Coghlan in branch 'default':
Remove the SSLSocket versions of sendmsg/recvmsg due to lack of proper tests
and documentation in conjunction with lack of any known use cases (see issue
#6560 for
Nick Coghlan ncogh...@gmail.com added the comment:
As you can see, I just pushed a change that removed the new methods from
SSLSocket objects. If anyone wants to step up with a valid use case (not
already covered by wrap_socket), preferably with a patch to add them back that
includes proper
Nick Coghlan ncogh...@gmail.com added the comment:
Regarding the 'missing methods' aspect, the SSL docs are already pretty clear
that SSLSocket objects don't expose the full socket API:
http://docs.python.org/dev/library/ssl#ssl-sockets
Those docs are actually what really got me started down
Nick Coghlan ncogh...@gmail.com added the comment:
And the Windows buildbots are now happy (at least with respect to this change,
anyway - they're still griping about a few other issues).
I don't know if it's feasible to support these new APIs at the socket module
level on Windows, but any
Antoine Pitrou pit...@free.fr added the comment:
The OS X buildbots show some failures:
http://www.python.org/dev/buildbot/all/builders/AMD64%20Snow%20Leopard%202%203.x
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 37721ee145a2 by Nick Coghlan in branch 'default':
Credit patch authors in NEWS for #6560
http://hg.python.org/cpython/rev/37721ee145a2
--
___
Python tracker
Charles-François Natali neolo...@free.fr added the comment:
New changeset c64216addd7f by Nick Coghlan in branch 'default':
Add support for the send/recvmsg API to the socket module. Patch by David
Watson and Heiko Wundram. (Closes #6560)
http://hg.python.org/cpython/rev/c64216addd7f
I
Nick Coghlan ncogh...@gmail.com added the comment:
Someone here at the sprints pointed out a redundant unsigned comparison to 0
that I missed, so a second set of eyes to double-check things like that would
be good.
--
___
Python tracker
Nick Coghlan ncogh...@gmail.com added the comment:
Reopening to track buildbot failures (at least on Windows) - at a glance, it
looks like the SSL socket wrapper is still adding (and trying to test) the
send/receivemsg methods even when they're missing from the socket object on the
current
Nick Coghlan ncogh...@gmail.com added the comment:
Attached patch (ssl_fixes_v1) makes the presence of the sendmsg/recvmsg methods
in the ssl module conditional on their being present in the underlying socket
module.
However, in doing this, I noticed that these methods will, at best, work
Changes by Brian May br...@microcomaustralia.com.au:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c64216addd7f by Nick Coghlan in branch 'default':
Add support for the send/recvmsg API to the socket module. Patch by David
Watson and Heiko Wundram. (Closes #6560)
http://hg.python.org/cpython/rev/c64216addd7f
Antoine Pitrou pit...@free.fr added the comment:
What needs to happen to get recvmsg() supported in Python?
Well, I guess that the only reason is that no committer is motivated
enough to bring this into Python: it's a rather large patch, and
honestly, I'm not sure that many people are
Brian May br...@microcomaustralia.com.au added the comment:
To address some of the comments above:
* Yes, the patch is large. However, most of this is in the tests. Only A
relatively small part is in the code that implements the required
functionality. I don't care much myself about the test
Charles-François Natali neolo...@free.fr added the comment:
What needs to happen to get recvmsg() supported in Python?
Well, I guess that the only reason is that no committer is motivated
enough to bring this into Python: it's a rather large patch, and
honestly, I'm not sure that many people
Brian May br...@microcomaustralia.com.au added the comment:
Have tested my code with this patch, the recvmsg(...) call seems to work fine.
Also had a half-hearted attempt at porting to Python 2.7, but didn't get past
compiling, the code requires BEGIN_SELECT_LOOP and END_SELECT_LOOP macros
Gergely Kálmán kalman.gerg...@duodecad.hu added the comment:
No, indeed this is a lot better.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
Gergely Kálmán kalman.gerg...@duodecad.hu added the comment:
On 05/22/11 03:14, Brian May wrote:
Brian Maybr...@microcomaustralia.com.au added the comment:
What needs to happen to get recvmsg() supported in Python?
recvmsg() is required to get get transparent UDP proxies working under
David Watson bai...@users.sourceforge.net added the comment:
On Mon 23 May 2011, Gergely Kálmán wrote:
It's been a while I had a look at that code. As far as I remember though
the code is fairly decent not
taking the missing unit tests into account. There are a few todos, and
also a pretty
Brian May br...@microcomaustralia.com.au added the comment:
Hello,
Are there any problems applying the v5 version of the patch to 3.3?
Also is there any remote chance for a backport to 2.7?
Thanks
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +charles-francois.natali, rosslagerwall
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
Brian May br...@microcomaustralia.com.au added the comment:
What needs to happen to get recvmsg() supported in Python?
recvmsg() is required to get get transparent UDP proxies working under Linux
using tproxy, the code needs to run recvmsg() to be able to find out what the
original
David Watson bai...@users.sourceforge.net added the comment:
New version with minor changes. Will also upload at
http://codereview.appspot.com/1487041/show
--
Added file: http://bugs.python.org/file17659/baikie-hwundram-v4.diff
___
Python tracker
David Watson bai...@users.sourceforge.net added the comment:
Optional patch to replace SocketTCPTest, etc. with the classes from the sendmsg
patch.
--
Added file: http://bugs.python.org/file17660/v4-replace-existing-classes.diff
___
Python tracker
David Watson bai...@users.sourceforge.net added the comment:
OK. I don't like creating/using a Google account, but here it is:
http://codereview.appspot.com/1487041/show
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
Antoine Pitrou pit...@free.fr added the comment:
Would you like to upload your patch to http://codereview.appspot.com/? It would
make reviewing easier.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
Changes by Andrew Grover andy.gro...@gmail.com:
--
nosy: +Andrew.Grover
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
David Watson bai...@users.sourceforge.net added the comment:
Here is a new version of the patch; I've added some tests which
use the RFC 3542 interface (IPv6 advanced API) and am now quite
happy with it generally.
As well as Linux, I've tested it on an old (unsupported) FreeBSD
5.3
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +haypo
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +exarkun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
___
___
Python-bugs-list mailing
David Watson bai...@users.sourceforge.net added the comment:
I just found that the IPv6 tests don't get skipped when IPv6 is
available but disabled in the build - you can create IPv6
sockets, but not use them :/ This version fixes the problem.
--
Added file:
David Watson bai...@users.sourceforge.net added the comment:
OK, here's a new version as a work in progress. A lot of the new
stuff is uncommented (particularly the support code for the
tests), but there are proper docs this time and a fairly complete
test suite (but see below).
There are a
David Watson bai...@users.sourceforge.net added the comment:
Thanks for your interest! I'm actually still working on the
patch I posted, docs and a test suite, and I'll post something
soon.
Yes, you could just use b.join() with sendmsg() (and get
slightly annoyed because it doesn't accept
Wim w...@.org added the comment:
I just ran across yet another implementation of sendmsg support for python
sockets, whose feature set seems to complement Kalman Gergely's implementation:
http://www.pps.jussieu.fr/~ylg/PyXAPI by Yves Legrandgerard
(Out of curiosity, people have been
Jack Diederich jackd...@gmail.com added the comment:
I've been digging into the patch. Is there a reason sendmsg() wants an
iterable of buffers instead of just accepting a str? The list-of-buffers more
closely matches the underlying syscall but I'm not sure what the python benefit
is,
Jack Diederich jackd...@gmail.com added the comment:
one of the other sprinters just pointed out that Modules/_multiprocessing.c
(py3k branch) uses sendmsg/recvmsg internally to pass file descriptors back and
forth. The code is very short and readable.
--
David Watson bai...@users.sourceforge.net added the comment:
Hi, I'm afraid there may have been some duplication of effort
here - I set about reworking Heiko Wundram's original patch
(issue #1194378) without knowing about this one. I don't have
unit tests yet either, but I saw this and thought
New submission from Kálmán Gergely kalman.gerg...@duodecad.hu:
This is the rewritten-from-scratch implementation of the
sendmsg()/recvmsg() methods.
Any comments / suggestions / flames are very welcome. Currently it
supports what I need
and I'm only releasing it because I don't have much time to
Kálmán Gergely kalman.gerg...@duodecad.hu added the comment:
the tester application
--
Added file: http://bugs.python.org/file14557/sendrecvmsgtest.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
Thomas Herve the...@free.fr added the comment:
This is a duplicate (although updated patch) from bug #1194378. It would
still need unit tests...
--
nosy: +therve
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6560
61 matches
Mail list logo
