[issue6584] gzip module has no custom exception

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue6584] gzip module has no custom exception

Serhiy Storchaka added the comment: New changeset cf599f6f6f1c392d8f12936982a370d533782195 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-6584: Add a BadGzipFile exception to the gzip module. (GH-13022) https://github.com/python/cpython/commit/cf599f6f6f1c392d8f12936982a370d53378

[issue6584] gzip module has no custom exception

Zackery Spytz added the comment: I'd like to see this issue move forward, so I've created a PR. -- nosy: +ZackerySpytz versions: +Python 3.8 -Python 3.4 ___ Python tracker ___

[issue6584] gzip module has no custom exception

Change by Zackery Spytz : -- pull_requests: +12944 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue6584] gzip module has no custom exception

Serhiy Storchaka added the comment: read32() should raise BadGzipFile when less than 4 bytes read. Also you should introduce read8() function which raises BadGzipFile when less than 1 byte read. See also issue4844 and issue14315 for zipfile. -- stage: commit review -> needs patch

[issue6584] gzip module has no custom exception

Serhiy Storchaka added the comment: I added some comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue6584] gzip module has no custom exception

Michele Orrù added the comment: Well, I specified the word ``files`` everywhere for that reason. Looking at Doc/library/zlib.rst I see: For reading and writing .gz files see the gzip module. Also, I specified 'the gzip module' on the whatsnew section. Is there anything more specific I could

[issue6584] gzip module has no custom exception

Serhiy Storchaka added the comment: Not all invalid gzip files raise BadGzipFile. Some of them raises ZlibError. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue6584] gzip module has no custom exception

Michele Orrù added the comment: done! -- Added file: http://bugs.python.org/file27943/issue6584_6.patch ___ Python tracker ___ ___ Pyth

[issue6584] gzip module has no custom exception

Ezio Melotti added the comment: The new exception should also be documented, and a versionadded and Doc/whatsnew/3.4.rst entry added. -- versions: +Python 3.4 -Python 3.3 ___ Python tracker

[issue6584] gzip module has no custom exception

Changes by Michele Orrù : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue6584] gzip module has no custom exception

Changes by Michele Orrù : Added file: http://bugs.python.org/file22958/6584_5.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue6584] gzip module has no custom exception

Michele Orrù added the comment: The attached patch follows Ezio's hints. -- nosy: +maker Added file: http://bugs.python.org/file22956/6584_4.patch ___ Python tracker ___

[issue6584] gzip module has no custom exception

Éric Araujo added the comment: Ezio has found a few other things to improve (follow the “review” link to the right of the patch link). -- nosy: +eric.araujo ___ Python tracker _

[issue6584] gzip module has no custom exception

Terry J. Reedy added the comment: Your changes appear to address all three of Antoine's 'nits'. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: Bump! Antoine, do you think the patch is acceptable and can be committed now? -- ___ Python tracker ___

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: I had some time today, so I managed to fix the patch. I hope now everything is ok. -- Added file: http://bugs.python.org/file21209/6584_3.patch ___ Python tracker

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: I'll be very happy to fix this after Friday. Thanks for your comments. -- ___ Python tracker ___ ___

[issue6584] gzip module has no custom exception

Antoine Pitrou added the comment: Since the patch makes BadGzipFile a subclass of IOError, it doesn't look unreasonable. Some nits: - a gzipped file is not an "archive" - the unit tests should use either the "with" statement, or try/finally blocks to properly close the file even when the test

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: Bump! How about commiting this patch? Or maybe there is something missing? I'll be happy to fix it. -- ___ Python tracker ___ _

[issue6584] gzip module has no custom exception

Changes by Antoine Pitrou : -- stage: needs patch -> patch review versions: +Python 3.3 -Python 2.7, Python 3.2 ___ Python tracker ___

[issue6584] gzip module has no custom exception

Changes by David Stanek : -- nosy: +dstanek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: Modified patch with test, that catches both BadGzipFile and IOError exceptions. -- Added file: http://bugs.python.org/file16566/6584_2.patch ___ Python tracker

[issue6584] gzip module has no custom exception

Filip Gruszczyński added the comment: I have created a small patch, that introduces BadGzipFile exception. It is a subclass of IOError, so it would be backward compatible and will be still caught by old code, but this way is distinct from IOError. -- keywords: +patch nosy: +gruszczy A

[issue6584] gzip module has no custom exception

Terry J. Reedy added the comment: Unless something in the docs claims that there is/should be such a thing, this is a feature request, not a bug ('behavior') report, and only applicable to future x.y versions. -- nosy: +tjreedy type: behavior -> feature request versions: +Python 2.7 -Py

[issue6584] gzip module has no custom exception

Changes by Amaury Forgeot d'Arc : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue6584] gzip module has no custom exception

Changes by Sridhar Ratnakumar : -- versions: +Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue6584] gzip module has no custom exception

New submission from Sridhar Ratnakumar : Much like zipfile.BadZipfile, we need a base custom exception for the gzip module. At least, catch gzip-related exceptions and throw a tarfile.TarError when used *via* tarfile.*. See the following example (the exception escaped the "try... except tarfi