[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset b5f0ce4ddf0c by Éric Araujo in branch '2.7': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/b5f0ce4ddf0c -- ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset edcdef70c44e by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/edcdef70c44e -- ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: I’ve been recommended VirtualBox, but I don’t have Qt libs on my machine (I don’t have much disk space and I don’t like Qt :) Happily closing as fixed. -- status: open -> closed ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset 4d6a9f287543 by Éric Araujo in branch 'default': Fix bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/distutils2/rev/4d6a9f287543 New changeset 7d1a7251d771 by Éric Araujo in branch 'python3': Merge fixes for #13974, #6884 and

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: > Yep, I have one of these and downloaded an ISO, but I haven’t yet managed to > set it up with qemu. You might want to give VirtualBox a try - I've found it very easy to set up. > Please file reports for the bugs you’ve found, on this tracker. Will do.

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: [Nadeem] > Not sure about a CI service, but if you want Windows for your own machine > I believe you can get a free MSDN subscription: Yep, I have one of these and downloaded an ISO, but I haven’t yet managed to set it up with qemu. [Adam] > ZTK (Zope toolkit) en

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: Well... testing distutils2 on Windows has been quite an adventure. When I ran the test suite before applying the patch, I got a bunch of failures on all of the Python versions I tested (except the ones that had issues preventing me from running the tests at all).

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Adam Groszer added the comment: Hello, On Sun, 26 Feb 2012 03:37:06 + you wrote: > BTW if someone knows about a continuous integration service which provides > Windows and Mac OS X VMs I’m all ears. ZTK (Zope toolkit) ended up with renting a windows (server) VM. http://winbot.zope.org/ T

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: > For distutils2 however I have no tester and no bot, so could someone test > this patch? I'll take a look at it. > BTW if someone knows about a continuous integration service which provides > Windows and Mac OS X VMs I’m all ears. Not sure about a CI servic

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: I’ve ported the fix to packaging without testing, the buildbots will shout at me if I made a mistake. For distutils2 however I have no tester and no bot, so could someone test this patch? (repo is at http://hg.python.org/distutils2) BTW if someone knows about

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset 937b1613d0e6 by Éric Araujo in branch 'default': Port the #6884 fix to packaging http://hg.python.org/cpython/rev/937b1613d0e6 -- ___ Python tracker __

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Most buildbots are green, one has a test_subprocess failure, others are still building, but I have to go soon. Release managers, please graft this fix when the bots are all green. -- resolution: -> fixed stage: patch review -> committed/rejected _

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset 73aa4c9305b3 by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/73aa4c9305b3 -- ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Roundup Robot added the comment: New changeset 47788c90f80b by Éric Araujo in branch '2.7': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/47788c90f80b -- nosy: +python-dev ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: 3.2 patch looks good on Windows. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: I’ll commit the 2.7 patch, see how buildbots fare, then commit the 3.2 version (also attached in case someone wants to test it). -- Added file: http://bugs.python.org/file24638/filelist-regex-bugs-3.2.diff ___ Python t

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Georg Brandl added the comment: Be sure to notify me when you have committed a fix, as changes made now in the 3.2 branch will *not* show up in the final release. -- ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: >>> Fix merged. I don’t fully understand why one place needs two escapes and >>> the others just one. >> The places that use one level of escaping are the ones that deal with the >> regex string directly. >> In glob_to_re() itself, the string you're building is

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Thanks a bunch. I’ll offer you cookies when we meet :) >> Fix merged. I don’t fully understand why one place needs two escapes and >> the others just one. > The places that use one level of escaping are the ones that deal with the > regex string directly. > In

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: >> - test_glob_to_re() was doing two levels of escaping (r'\' -> r'') >> for its expected output when it should only do one (r'\' -> r'\\'). > Fix merged. I don’t fully understand why one place needs two escapes and the > others just one. I agree that thi

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: There are some minor errors in your v3 patch. I've attached a v4 that fixes them (as usual, tested on Windows and Linux): - s/special/sep/ in glob_to_re() - Add missing l(.) to filenames in test_process_template under 'graft d' >> - test_glob_to_re() was doin

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: > - test_glob_to_re() was doing two levels of escaping (r'\' -> r'') > for its expected output when it should only do one (r'\' -> r'\\'). Fix merged. I don’t fully understand why one place needs two escapes and the others just one. > - test_process_templa

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: There were bugs in two of the updated tests: - test_glob_to_re() was doing two levels of escaping (r'\' -> r'') for its expected output when it should only do one (r'\' -> r'\\'). - test_process_template() was not converting some of its expected results

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Escalated to release blocker, as bugfix releases are about to go out of the door and I’d prefer they weren’t published with the buggy fixes committed for #13193. -- nosy: +benjamin.peterson, georg.brandl priority: normal -> release blocker _

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Thanks for testing and confirming that this code never worked. I am now confident that we’re about to fix once and for all this basket of bugs in the correct way. I updated the tests to make them hopefully pass on Windows, and while doing that I realized that

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: > (2.7.2 doesn’t include neither Antoine’s changeset nor mine, right?) Correct; it dates back to June last year, before issue 13193 was filed. > Can you reproduce the “include buildout.cfg” bug too? Yes, that problem is present in 2.7.2, but not in the current

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: > The original code never worked properly on Windows - that's what the XXX > comment in glob_to_re() is > about. I've been able to reproduce the problem (erroneously including > ".hg\last-message.txt") on > v2.7.2 (8527427914a2). Can you reproduce the “include bu

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: > It’s strange that glob_to_re needs fixing too; at this point I’m not sure if > we’re still fixing my commit or if the original code never worked properly on > Windows. Could you run the same tests with a Python < 2.7? The original code never worked properly

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: It’s strange that glob_to_re needs fixing too; at this point I’m not sure if we’re still fixing my commit or if the original code never worked properly on Windows. Could you run the same tests with a Python < 2.7? BTW I wonder if #9691 is yet another manifestat

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: Test output: test test_distutils failed -- Traceback (most recent call last): File "C:\Users\Nadeem\Code\python2\python27\lib\distutils\tests\test_filelist.py", line 230, in test_process_template self.assertEqual(file_list.files, ['d/b.py', 'd

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Could you post the test output (and the output of DISTUTILS_DEBUG=1 ./python.exe setup.py sdist if you have it)? -- ___ Python tracker ___ ___

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Nadeem Vawda added the comment: With the patch applied, the problem from issue 14004 still occurs. There is also a failure in test_distutils, but I'm not sure whether that's just the test itself needing to be updated. Anyway, it's late for me now; I'll give it a more detailed look tomorrow. --

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Can someone test this patch on Windows? -- nosy: +jason.coombs Added file: http://bugs.python.org/file24553/filelist-regex-bug.diff ___ Python tracker

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: I’m sorry I couldn’t fix this one in 3.1. I didn’t take the time to download and install a Windows to test this year, and right now I don’t have the bandwidth. I’ll get to it as soon as possible. -- status: pending -> open versions: +Python 3.3 -Python

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Changes by Éric Araujo : -- keywords: +patch -needs review resolution: -> accepted stage: needs patch -> patch review status: open -> pending ___ Python tracker ___ _

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: My feeling was that there was a logic bug in filelist (something explicitly added should not be filtered out by a default exclude pattern), so I’m glad to learn it’s just a regex bug. I’ll add a test for the add/filter logic just in case. Thanks a lot for the

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Chris Withers added the comment: Okay, so here's the patch: Change line 352 on distutils/filelist.py from: pattern_re = "^" + os.path.join(prefix_re, ".*" + pattern_re) To: pattern_re = "^"+prefix_re+re.escape(os.sep)+".*"+pattern_re os.path.join is is not always the saviour ;-) --

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Chris Withers added the comment: So, the workaround I gave doesn't work, because this stupid regex still knocks out all the egg-info. The only solution is to use that accidentally employed by http://svn.plone.org/svn/collective/buildout/buildout.dumppickedversions/trunk/ and put any files sta

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Chris Withers added the comment: This is a regex bug, and it just bit me again :-( Because of this bug, you cannot currently build a bdist_egg (and therefore cannot install with easy_install) http://pypi.python.org/pypi/buildout-versions on windows. The only choice I have is to rename the 'b

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Test by haypo on win32: - ['README', 'setup.py', 'somecode\\__init__.py'] ? ^^ + ['README', 'buildout.cfg', 'setup.py', 'somecode/__init__.py'] ? ^ The bug is confirmed. I’ll use os.s

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Attaching a unit test translation of Chris’ report. The test pass on POSIX (linux2), can someone test on win32? Tracing the flow from sdist to filelist, it seems to be not a regex error but a logic error. A file explicitly added should not be removed by the excl

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: I’ll write a unit test shortly. -- assignee: tarek -> eric.araujo versions: +Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker ___

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Éric Araujo added the comment: Sorry for the lag. There are a lot of bugs and Tarek is very busy. The steps you describe need to be turned in a new test in py3k’s test_sdist. -- nosy: +merwok ___ Python tracker __

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Changes by Tarek Ziadé : -- components: +Distutils2 versions: -Python 2.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Chris Withers added the comment: I guess not... Maybe try catching Tarek on irc or drop him a mail? -- ___ Python tracker ___ ___ Pyth

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

Adam Groszer added the comment: This seems to be a major flaw, noone caring about it? -- components: +Distutils nosy: +Adam.Groszer versions: +Python 2.5 ___ Python tracker ___ _

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

New submission from Chris Withers : With a simple setup.py: from distutils.core import setup setup(name='packagename') And a MANIFEST.in containing: include buildout.cfg The result of a debug run of python setup.py sdist on Windows is: Distribution.parse_config_files(): options (after parsi