[issue7063] Memory errors in array.array

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue7063] Memory errors in array.array

Roundup Robot added the comment: New changeset ab28676df655 by Martin Panter in branch 'default': Issue #7063: Remove dead code from array slice handling https://hg.python.org/cpython/rev/ab28676df655 -- nosy: +python-dev ___ Python tracker

[issue7063] Memory errors in array.array

Martin Panter added the comment: The patch looks good to me (assuming it still applies). Should also remove the “b” macro. -- components: +Extension Modules -Library (Lib), Tests nosy: +martin.panter stage: patch review -> commit review ___ Python tr

[issue7063] Memory errors in array.array

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue7063] Memory errors in array.array

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker ___

[issue7063] Memory errors in array.array

Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue7063] Memory errors in array.array

Mark Lawrence added the comment: I've tested the reworked patch on Windows 7, ran 718 tests with 1 skipped both before and after applying the patch. -- nosy: +BreamoreBoy Added file: http://bugs.python.org/file35926/Issue7063.diff ___ Python tracker

[issue7063] Memory errors in array.array

Chuck added the comment: I attached a patch, in which I removed v and all code having to do with inserting elements. In particular, I changed the value of b to being positive, since there is no distinction between increasing and decreasing size anymore. -- keywords: +patch nosy: +Chuck

[issue7063] Memory errors in array.array

Stefan Krah added the comment: I think msg93598 sums it up: array_ass_slice() is only called with v==NULL, so the issue can't be triggered. However, it's pretty dirty to leave the code as is (IIRC Coverity also had some complaints), so Chuck's suggestion to rewrite the function as array_del_slic

[issue7063] Memory errors in array.array

R. David Murray added the comment: Stefan, IIRC you reworked some of the buffer/memoryview code. Do you know if what is reported here is still an issue, and if so if it is worth fixing? -- nosy: +r.david.murray, skrah ___ Python tracker

[issue7063] Memory errors in array.array

Jan Hosang added the comment: The mp_ass_subscript function looks fine in contrast to array_ass_slice(). So if array_ass_slice() is not accessible from the outside and is only called with NULL as replacement parameter from the inside, I won't be able to cause trouble with those two issues. S

[issue7063] Memory errors in array.array

Amaury Forgeot d'Arc added the comment: The array type also defines tp_as_mapping->mp_ass_subscript, which has priority in PyObject_SetItem(). A way to call array_ass_slice() is to use PySequence_SetItem(), but this is hard to trigger from python code (it should be possible with ctypes). --

[issue7063] Memory errors in array.array

New submission from Jan Hosang : While I was backporting the new buffer API to 2.7 I noticed some issues in array_ass_slice() in Modules/arraymodule.c in the python 3k branch. 1) Manual memory reallocation had been replaced by calls to array_resize. But I think when PyMem_RESIZE is called the