Philip Jenvey pjen...@underboss.org added the comment:
py3k should be taken care of as of r80066+r80075
--
resolution: accepted - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
Stefan Krah stefan-use...@bytereef.org added the comment:
The changes in main.c in r79881 don't look right:
strtok() is used on the string returned by getenv(), which must not
be modified.
Also (and this admittedly cosmetic), perhaps use a static buffer like
wchar_t warning[128] or use a
Philip Jenvey pjen...@underboss.org added the comment:
The pending patch for py3k fixes the modification of the env value (trunk
already has a fix for that).
That patch is also doing the conversion to wchar_t via the char2wchar function
now, with that reusing a single buffer seems out of the
Antoine Pitrou pit...@free.fr added the comment:
The tests don't look good to me. You should use p.communicate() rather than
p.stdout.read(). Also, check the error return code and raise an error if it's
non-zero.
--
nosy: +pitrou
___
Python tracker
Philip Jenvey pjen...@underboss.org added the comment:
I committed a somewhat different version of this patch to py3k to handle the
warn options now calling for wchars, but this needs more work. Some of the
buildbots are unhappy
Seems like the py3k version either needs to fully decode the env
Philip Jenvey pjen...@underboss.org added the comment:
Here's a patch for py3k using the same char2wchar as the argv decoder for
posix, and better windows handling. Plus an additional nonascii value test.
Patch is against r79980 for clarity
--
Added file:
Philip Jenvey pjen...@underboss.org added the comment:
Looks good to me. Updated patch with a couple whitespace changes
--
Added file: http://bugs.python.org/file16791/issue7301-2.diff
___
Python tracker rep...@bugs.python.org
Barry A. Warsaw ba...@python.org added the comment:
Patch looks good to me too. Do any of you have commit privileges? If so,
please commit this. If not assign the issue to me and I'll do it.
--
resolution: - accepted
___
Python tracker
Philip Jenvey pjen...@underboss.org added the comment:
applied in r79878 - r79881, thanks!
--
resolution: accepted - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +Merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
___
Python-bugs-list mailing
Changes by Brian Curtin cur...@acm.org:
Removed file: http://bugs.python.org/file15889/issue7301.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
Brian Curtin cur...@acm.org added the comment:
Updated patch, tests weren't working.
--
Added file: http://bugs.python.org/file16157/issue7301.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
Changes by Brian Curtin cur...@acm.org:
Removed file: http://bugs.python.org/file15324/issue7301_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
Changes by Brian Curtin cur...@acm.org:
Removed file: http://bugs.python.org/file15322/issue7301.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
Brian Curtin cur...@acm.org added the comment:
fixed a tab/space issue
--
Added file: http://bugs.python.org/file15889/issue7301.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
Changes by Brian Curtin cur...@acm.org:
--
keywords: +needs review
priority: - normal
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
Brian Curtin cur...@acm.org added the comment:
I attached a patch against trunk r76237 which seems to cover this, sans
official tests. I looked around and didn't find a good place for
specifically testing environment variables. I could add test code in
test_warnings if that's the best place.
Philip Jenvey pjen...@underboss.org added the comment:
test_warnings is probably the best place since test_cmd_line ignores
environment variables
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
Brian Curtin cur...@acm.org added the comment:
Added a patch which includes tests in test_warnings. There are tests for
a single warning, two comma separated warnings, and one env var warning
and one command line warning at the same time.
--
Added file:
New submission from Barry A. Warsaw ba...@python.org:
It would be very useful to have an environment variable $PYTHONWARNINGS,
tied to the -W option for silencing various warnings (most importantly,
DeprecationWarnings).
Use case: a test suite running many subprocesses, testing that those
Changes by Philip Jenvey pjen...@underboss.org:
--
nosy: +pjenvey
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7301
___
___
Python-bugs-list
21 matches
Mail list logo
