Georg Brandl ge...@python.org added the comment:
Fixed in r80433.
--
assignee: r.david.murray - georg.brandl
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7507
Georg Brandl ge...@python.org added the comment:
I'm attaching a patch that changes quote() logic. It also fixes #7476, the
empty argument case.
Strings with unsafe characters are now always quoted with single quotes. Single
quotes themselves are replaced by a single quote in double quotes,
Georg Brandl ge...@python.org added the comment:
Really adding the patch now.
--
keywords: +patch
Added file: http://bugs.python.org/file15803/pipes.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7507
R. David Murray rdmur...@bitdance.com added the comment:
The patch looks good to me, except that one test fails. You seem to have
inadvertently deleted the '=' from the safe chars list in the test.
We should also add a test for the '' case. And presumably the docs requested
in the other
New submission from Ben Gertzfield bgertzfi...@gmail.com:
The undocumented (but unit tested!) pipes.quote does not correctly
escape '!', which cannot be passed to the shell outside of single-
quotes:
sh-3.2$ python
Python 2.6.1 (r261:67515, Jul 7 2009, 23:51:51)
[GCC 4.2.1 (Apple Inc. build
