Roundup Robot devnull@devnull added the comment:
New changeset 80971f71b0d9 by Brian Curtin in branch '3.1':
Further fix #7838. CREATE_NEW_CONSOLE was exposed, but none of the
http://hg.python.org/cpython/rev/80971f71b0d9
--
nosy: +python-dev
___
Brian Curtin cur...@acm.org added the comment:
Fixed with r80439-r80442.
--
assignee: georg.brandl - brian.curtin
components: +Extension Modules -Documentation
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Georg Brandl ge...@python.org added the comment:
I agree. Docstrings never hurt.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7838
___
___
Brian Curtin cur...@acm.org added the comment:
Here's a patch which keeps docstrings, and explicitly qualifies the Windows
specific functions from _subprocess rather than using import * (which causes a
couple of lines just over 79 chars). Now the functions are more hidden than
before.
Ran
New submission from Brian Curtin cur...@acm.org:
On Windows, the subprocess module makes use of functions publicly exposed by
PC/_subprocess.c to interact with Win32 API functions. However, no
documentation exists for these functions, neither in the online docs nor in
docstrings.
--
Brian Curtin cur...@acm.org added the comment:
Attached is a patch which adds docstrings to the functions in PC/_subprocess.c,
documents the functions in Doc/library/subprocess.rst, and removes a chunk of
unneeded import code from Lib/subprocess.py
--
keywords: +needs review, patch
Changes by Brian Curtin cur...@acm.org:
Removed file: http://bugs.python.org/file16110/issue7838.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7838
___
Changes by Brian Curtin cur...@acm.org:
Added file: http://bugs.python.org/file16111/issue7838.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7838
___
Benjamin Peterson benja...@python.org added the comment:
This is likely because these functions are meant to be undocumented
implementation details.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
Brian Curtin cur...@acm.org added the comment:
True. Is there value in eventually privatizing these functions?
It feels weird having them exposed but not documented at all...maybe just keep
the docstrings around?
--
status: open - pending
___
Benjamin Peterson benja...@python.org added the comment:
Actually, I consider them private now, given that they aren't in __all__ or
documented. I'd prefer if the code was changed to qualify their use with
_subprocess.X actually. Docstrings are fine, I suppose.
--
status: pending -
11 matches
Mail list logo
