[issue7863] platform module doesn't detect Windows 7

2010-05-06 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: Now that I have access to a Server 2008 R2 machine, I've verified that this fix works there. Committed in r80857 through r80860. Thanks, Brian. --

[issue7863] platform module doesn't detect Windows 7

2010-05-05 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Now that I have access to a Server 2008 R2 machine, I've verified that this fix works there. Committed in r80857 through r80860. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: +Python 3.1,

[issue7863] platform module doesn't detect Windows 7

2010-04-21 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Any thoughts on this last bit about using the registry to identify between workstation and server? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7863

[issue7863] platform module doesn't detect Windows 7

2010-04-21 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: Any thoughts on this last bit about using the registry to identify between workstation and server? I can't comment on that since I don't know anything much about the

[issue7863] platform module doesn't detect Windows 7

2010-04-21 Thread Brian Curtin
Changes by Brian Curtin cur...@acm.org: Removed file: http://bugs.python.org/file16371/issue7863.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7863 ___

[issue7863] platform module doesn't detect Windows 7

2010-04-21 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Updated patch to remove the function. MSDN says nothing about available registry keys or their information, at least from what I could tell. I guess it is possible that future versions might not have the value we are looking for, but I kind of

[issue7863] platform module doesn't detect Windows 7

2010-02-25 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: This patch should cover everything, and it works with 2.6 as well. In order to figure out workstation vs. server, it uses the ProductName from the registry when it can't the info from getwindowsversion. If it finds a server name, it's a server,

[issue7863] platform module doesn't detect Windows 7

2010-02-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: Here is the patch which checks whether the new info is available and uses it, otherwise it falls back to the original way. Thanks. Could you apply the same logic to

[issue7863] platform module doesn't detect Windows 7

2010-02-23 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Whoops, sorry. Here is the change as requested. It reverts to the old way when needed, which hardcodes the version to VER_NT_WORKSTATION as it effectively used to. Outside of a hackish and incredibly slow method, I have no idea how to figure

[issue7863] platform module doesn't detect Windows 7

2010-02-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: I'll look into whatever other trickery could be applied to 2.6/3.1. The patch against trunk works correctly for Win7, Win 2003 Server SP1, Win XP SP2, and Win 2000

[issue7863] platform module doesn't detect Windows 7

2010-02-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Marc-Andre Lemburg wrote: Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: I'll look into whatever other trickery could be applied to 2.6/3.1. The patch

[issue7863] platform module doesn't detect Windows 7

2010-02-10 Thread Marc-Andre Lemburg
Marc-Andre Lemburg m...@egenix.com added the comment: Brian Curtin wrote: Brian Curtin cur...@acm.org added the comment: Here's a patch which fixes this on trunk. 2.6/3.1 is a different story as there doesn't appear to be a way to get the platform type to differentiate

[issue7863] platform module doesn't detect Windows 7

2010-02-10 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: I'll look into whatever other trickery could be applied to 2.6/3.1. The patch against trunk works correctly for Win7, Win 2003 Server SP1, Win XP SP2, and Win 2000 Server SP2. platform.platform() outputs the same info for the latter three OSes

[issue7863] platform module doesn't detect Windows 7

2010-02-05 Thread Adal Chiriliuc
New submission from Adal Chiriliuc adal.chiril...@gmail.com: Running python 32 bit on Windows 7 64 bit: import platform platform.platform() 'Windows-post2008Server-6.1.7600' Should be corrected to display 'Windows-7-6.1.7600' Fix: elif maj == 6: if min == 0:

[issue7863] platform module doesn't detect Windows 7

2010-02-05 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +lemburg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7863 ___ ___ Python-bugs-list mailing

[issue7863] platform module doesn't detect Windows 7

2010-02-05 Thread Ezio Melotti
Ezio Melotti ezio.melo...@gmail.com added the comment: Confirmed on Python 2.7a2. -- nosy: +brian.curtin, ezio.melotti priority: - normal stage: - test needed type: - behavior versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org

[issue7863] platform module doesn't detect Windows 7

2010-02-05 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Note that this will also need the Workstation check that 6.0 has right above this, because both Windows 7 and Windows Server 2008 R2 are version 6.1.x. Also of note is that sys.getwindowsversion (renamed as GetVersionEx here) has been expanded to

[issue7863] platform module doesn't detect Windows 7

2010-02-05 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Here's a patch which fixes this on trunk. 2.6/3.1 is a different story as there doesn't appear to be a way to get the platform type to differentiate workstation/server. #7766 is what makes it easy on trunk, but it's a new feature and isn't