[issue7992] Backport capsule object

Jesús Cea Avión added the comment: For future reference: http://mail.python.org/pipermail/python-committers/2010-April/000875.html The final consensus was not to integrate bsddb Capsule for Python 2.7, since CObject is not actually deprecated in python 2.7. -- __

[issue7992] Backport capsule object

Larry Hastings added the comment: Marking closed, as promised; 2.7b1 has been out for nine days and there hasn't been a peep. If new problems crop up from the capsule backport, please create a new issue and assign it to me. For posterity: 2.7b1 shipped with a bsddb that still publishes a COb

[issue7992] Backport capsule object

Larry Hastings added the comment: The patch is a bit more involved than that. Capsules didn't exist in 3.0, and the bsddb module published a CObject in 3.1. So bsddb must continue to use CObject for those two releases. Therefore the patch to the line you were addressing looks like this: -#

[issue7992] Backport capsule object

Florent Xicluna added the comment: Ok, I put Jésus in the nosy list. It makes the test___all__ fail on trunk because it checks the warnings raised during import. AFAIU, the patch is something like: -#if (PY_VERSION_HEX < 0x0302) +#if (PY_VERSION_HEX < 0x0207) -- nosy: +jcea

[issue7992] Backport capsule object

Larry Hastings added the comment: Oh, and, last night I checked in r79590. This is the checkin that ameliorates the backwards compatibility issues. Specifically, I changed four things: * PyCObject_AsVoidPtr() can now open capsules. This addresses most of the remaining backwards-compatibil

[issue7992] Backport capsule object

Larry Hastings added the comment: Yes. I was told it was inappropriate for me to change the bsddb module, as it's independently maintained by Jesus Cea. I sent Mr. Cea a patch last night; I hope he chooses to merge it soon. Since CObjects are marked Pending Deprecation, and bsddb is using a

[issue7992] Backport capsule object

Florent Xicluna added the comment: The PendingDeprecationWarning is still spit by the bsddb module. $ ./python -Wd -m test.regrtest test_bsddb test_bsddb ./Lib/importlib/__init__.py:37: PendingDeprecationWarning: The CObject type is marked Pending Deprecation in Python 2.7. Please use capsule

[issue7992] Backport capsule object

Brian Curtin added the comment: (adding myself to the nosy list as a Windows dev) -- nosy: +brian.curtin ___ Python tracker ___ ___ Py

[issue7992] Backport capsule object

Larry Hastings added the comment: Florent: that's because the Windows build projects don't build capsule.c. I don't have an appropriate Windows development environment; I'll try to fix them by hand tonight, but if that doesn't work we'll have to call for help from some Windows core developer

[issue7992] Backport capsule object

Larry Hastings added the comment: This is also (naturally) being discussed on python-dev. I've posted a long message there about it; you can find that message here: http://mail.python.org/pipermail/python-dev/2010-March/098904.html I don't know whether it's best to conduct such a discussion

[issue7992] Backport capsule object

STINNER Victor added the comment: PyCapsule comes from issues #5630 and #5872. -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-

[issue7992] Backport capsule object

Antoine Pitrou added the comment: (if you want to be perfectionist, you can have those modules provide both a PyCObject and a PyCapsule interface...) -- ___ Python tracker ___ _

[issue7992] Backport capsule object

Antoine Pitrou added the comment: As Marc-André pointed out, you shouldn't have converted old uses of PyCObject. It breaks compatibility, and I don't think there's any point since 2.7 will probably be the last in the 2.x line. -- nosy: +lemburg, pitrou ___

[issue7992] Backport capsule object

Florent Xicluna added the comment: All windows buildbots fail to compile: http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%20trunk http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%20trunk http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%20trunk -- keyw