[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Petri Lehtinen added the comment: Thanks for the patches, Philippe! I committed the latest one after some modifications. -- ___ Python tracker ___ __

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Roundup Robot added the comment: New changeset e67715b87131 by Petri Lehtinen in branch '3.2': sqlite3: Fix 64-bit integer handling in user functions on 32-bit architectures http://hg.python.org/cpython/rev/e67715b87131 New changeset cf12fe9ce2b0 by Petri Lehtinen in branch 'default': Merge bra

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Changes by Petri Lehtinen : -- nosy: +petri.lehtinen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Philippe Devalkeneer added the comment: Here a new patch with sqlite3_int64 type, and unit test. -- Added file: http://bugs.python.org/file20313/broken_long_sqlite_userfunctions.diff ___ Python tracker ___

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Philippe Devalkeneer added the comment: Ok I will redo a patch in the next few days with possibly type sqlite3_int64, and include tests. Thank you for the review. -- ___ Python tracker ___

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Martin v. Löwis added the comment: Alternatively, val_int should have type sqlite3_int64, which is the return type of sqlite3_value_int64. -- nosy: +loewis ___ Python tracker __

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Amaury Forgeot d'Arc added the comment: - unit tests are needed. - Py_LONG_LONG should be used instead of "long long", and the cast removed. - The patch assumes that longlong == int64, but is it true on all platforms? -- nosy: +amaury.forgeotdarc ___

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Changes by Éric Araujo : -- components: +Extension Modules -Library (Lib) stage: needs patch -> unit test needed versions: +Python 2.7, Python 3.2 -Python 2.6 ___ Python tracker _

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Philippe Devalkeneer added the comment: No, I made a mistake in my build, test_sqlite runs actually fine before and after the patch. -- ___ Python tracker ___ __

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Philippe Devalkeneer added the comment: The regression tests do not work anymore in test_sqlite with the patch, I will check more in details why... sorry. -- ___ Python tracker

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Changes by Santoso Wijaya : -- nosy: +santa4nt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Philippe Devalkeneer added the comment: Hello, Here is a patch to fix it :) ( and don't blame me too much if something is not correct, it's the first patch I submit :) ) Philippe -- keywords: +patch nosy: +flupke Added file: http://bugs.python.org/file19511/broken_long_int_sqlite_fu

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Fred Fettinger added the comment: I've never really looked at the python source before, but this is my best guess at the problem: For the standard SELECT query: In Modules/_sqlite/cursor.c, _pysqlite_fetch_one_row() has this code: PY_LONG_LONG intval; ... } else if (coltype == SQLITE_INTEGER)

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

New submission from Fred Fettinger : Handling of long integers is broken for arguments to sqlite functions created with the create_function api. Integers passed to a sqlite function are always converted to int instead of long, which produces an incorrect value for integers outside the range of