[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2014-03-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset b72615222c98 by R David Murray in branch 'default': whatsnew: sunau/aifc/wave writeframes[raw] accept any bytes-like (#8311) http://hg.python.org/cpython/rev/b72615222c98 -- ___ Python tracker

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8311 ___

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed in changeset b96f4ee1b08b. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8311 ___ ___

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 932db179585d by Serhiy Storchaka in branch 'default': Fixed issue number for issue #8311. http://hg.python.org/cpython/rev/932db179585d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is simplified patch. Added versionchanged tags in the documentation. -- Added file: http://bugs.python.org/file32567/audio_write_nonbytes_2.patch ___ Python tracker rep...@bugs.python.org

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-10-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch for all three audio modules. After dropping support of string (which is meanless) in the audioop module (issue16685) it can be simplified. I doubt that this should be applied in maintenance releases. Support of non-bytes arguments in

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-09-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It's because you write an array of integers while writeframes() expects a bytes object. Here is a test. -- keywords: +patch stage: test needed - needs patch versions: +Python 2.7, Python 3.3, Python 3.4 -Python 2.6 Added file:

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-09-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8311 ___ ___

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2010-04-04 Thread Jeff Pursell
New submission from Jeff Pursell jpurs...@gmail.com: I tried to create a 4 second file and only heard the first 2 seconds. The file size was correct for a 44.1 kHz, 16 bit mono file at 4 seconds, but both aplay and audactiy ignored the second half of the file. I went to this page

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2010-04-04 Thread Jeff Pursell
Jeff Pursell jpurs...@gmail.com added the comment: Here's my fix. The left file is the original and the right file is my version. Perhaps someone should check this patch on a big endian machine to make sure there are no issues there. I do not anticipate any issues. 416c416 nframes

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2010-04-04 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Any chance you could create a unit test for this? (The current set of tests is...pretty minimal.) Also, having the patch in unified diff format relative to the top of the source three would be helpful (although this one is small enough