[issue8630] Keepends param in codec readline(s)

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8630] Keepends param in codec readline(s)

Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.4, Python 3.5 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___

[issue8630] Keepends param in codec readline(s)

Jeffrey Falgout added the comment: Wrote tests -- hgrepos: +259 nosy: +jeffrey.falgout ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___ ___

[issue8630] Keepends param in codec readline(s)

Changes by Jeffrey Falgout jeffrey.falg...@gmail.com: Added file: http://bugs.python.org/file35729/45139b30afef.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___

[issue8630] Keepends param in codec readline(s)

Mark Lawrence added the comment: As codecs.py has changed I've generated a patch file which adds the missing parameters. I looked at test_codecs.py but could only find one reference to the StreamReaderWriter class in WithStmtTest. I'm sorry but I'll have to leave writing tests for

[issue8630] Keepends param in codec readline(s)

Benjamin Peterson benja...@python.org added the comment: I think this can qualify as a bug fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___

[issue8630] Keepends param in codec readline(s)

Marc-Andre Lemburg m...@egenix.com added the comment: We can add those to 3.2. Not sure about 2.7 - it's already in feature freeze. -- versions: +Python 2.7, Python 3.2 -Python 2.6 ___ Python tracker rep...@bugs.python.org

[issue8630] Keepends param in codec readline(s)

Marc-Andre Lemburg m...@egenix.com added the comment: Benjamin: Would the added parameter be a new feature or not ? It looks like an oversight when adding the parameter to the standard codec classes, so could be viewed as a bug. -- assignee: - benjamin.peterson nosy:

[issue8630] Keepends param in codec readline(s)

Marc-Andre Lemburg m...@egenix.com added the comment: André: Could you provide a patch ? Thanks. -- assignee: benjamin.peterson - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___

[issue8630] Keepends param in codec readline(s)

André M. C. Campos amccam...@gmail.com added the comment: The parameter would not be a new feature since the codecs docs states that: The StreamReaderWriter allows wrapping streams which work in both read and write modes. The reader (StreamReader) accepts the parameter, so it's expected that

[issue8630] Keepends param in codec readline(s)

Changes by André M. C. Campos amccam...@gmail.com: Added file: http://bugs.python.org/file17235/codecs.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___

[issue8630] Keepends param in codec readline(s)

New submission from André M. C. Campos amccam...@gmail.com: Some methods in StreamReaderWriter class (codecs library) has different signatures from StreamReader methods. More precisely it's missing the keepends parameter in readline and readlines methods. So, we cannot code: fp =

[issue8630] Keepends param in codec readline(s)

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +lemburg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8630 ___ ___ Python-bugs-list