Pascal Chambon chambon.pas...@gmail.com added the comment:
I guess it should, shouldn't it ?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
Antoine Pitrou pit...@free.fr added the comment:
Ok, I've committed the patch in r84506 (3.x), r84507 (3.1) and r84508 (2.7).
Thank you!
--
resolution: accepted - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python
Antoine Pitrou pit...@free.fr added the comment:
Should this be checked in?
--
nosy: +pitrou
versions: +Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
Pascal Chambon chambon.pas...@gmail.com added the comment:
My bad, here is a better patch...
--
Added file: http://bugs.python.org/file17382/msvcrt_crash2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
Changes by Pascal Chambon chambon.pas...@gmail.com:
Removed file: http://bugs.python.org/file17369/msvcrt_crash.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
The second patch looks good to me.
--
resolution: - accepted
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
New submission from Pascal Chambon chambon.pas...@gmail.com:
In python trunk, _set_invalid_parameter_handler() has been dropped and replaced
by custom checking functions, but in msvcrt.get_osfhandle() these checks aren't
present, so providing a bad FD leads to a crash.
Here is the little fix
