[issue8956] Incorrect ValueError message for subprocess.Popen.send_signal() on Windows
Brian Curtin cur...@acm.org added the comment: Fixed in r84559 (py3k) and r84560 (release27-maint). -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8956 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8956] Incorrect ValueError message for subprocess.Popen.send_signal() on Windows
New submission from Giampaolo Rodola' g.rod...@gmail.com: def send_signal(self, sig): Send a signal to the process if sig == signal.SIGTERM: self.terminate() elif sig == signal.CTRL_C_EVENT: os.kill(self.pid, signal.CTRL_C_EVENT) elif sig == signal.CTRL_BREAK_EVENT: os.kill(self.pid, signal.CTRL_BREAK_EVENT) else: raise ValueError(Only SIGTERM is supported on Windows) Just noticed right now while I was reading subprocess source code. I guess that should be Only SIGTERM, CTRL_C_EVENT or CTRL_BREAK_EVENT are supported on Windows. -- components: Library (Lib) messages: 107408 nosy: astrand, giampaolo.rodola priority: normal severity: normal status: open title: Incorrect ValueError message for subprocess.Popen.send_signal() on Windows versions: Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8956 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8956] Incorrect ValueError message for subprocess.Popen.send_signal() on Windows
Brian Curtin cur...@acm.org added the comment: Good catch, I forgot to update that message when adding the other signal support. Would you rather see something more generic like Unsupported signal rather than start listing all of the signals? Another alternative is to allow any signal through including integers, which are then just passed to os.kill (ints passed to kill get set as the proc exit code). However, we can't do that with 2.7, but could with 3.2. -- assignee: - brian.curtin components: +Windows nosy: +brian.curtin stage: - needs patch type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8956 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
