[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: On 21.10.2013 02:07, Ezio Melotti wrote: > > Ezio Melotti added the comment: > > Fixed, thanks for the patch! Thanks, Ezio, for the check-in. -- ___ Python tracker __

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Roundup Robot added the comment: New changeset 04a163f93ad4 by Ezio Melotti in branch '2.7': #8964: fix platform._sys_version to handle IronPython 2.6+. http://hg.python.org/cpython/rev/04a163f93ad4 New changeset 10a261824b62 by Ezio Melotti in branch '3.3': #8964: fix platform._sys_version to h

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: On 19.10.2013 13:37, Martin Matusiak wrote: > > Martin Matusiak added the comment: > > Double checked that the test passes against both default and 2.7 branches. > > Is there anything else that needs to happen here or are you satisfied, > Marc-Andre? No,

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: Double checked that the test passes against both default and 2.7 branches. Is there anything else that needs to happen here or are you satisfied, Marc-Andre? -- ___ Python tracker

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: On 19.10.2013 12:11, Martin Matusiak wrote: > > Attaching a v3 which uses "in" and "startswith". > > > Just for good measure I ran this module on IronPython 1.0 and it fails on > import: > > - bytes literal: b'(__libc_init)' > - "if" as infix operator: l

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: Attaching a v3 which uses "in" and "startswith". Just for good measure I ran this module on IronPython 1.0 and it fails on import: - bytes literal: b'(__libc_init)' - "if" as infix operator: line 177 - "unexpected token open": use of "with" context manager o

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: On 19.10.2013 07:06, Martin Matusiak wrote: > > Martin Matusiak added the comment: > > It seems the versions of IronPython 1.0 mentioned in test cases do actually > support the "in" keyword, so the first version of the patch is probably > sufficient. > >

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: It seems the versions of IronPython 1.0 mentioned in test cases do actually support the "in" keyword, so the first version of the patch is probably sufficient. Example session: >>> sys.version IronPython 1.0.60816 on .NET 2.0.50727.3643 >>> "IronPython" in s

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: Hm, I see. Actually, "in" is already used in this function a little further down: elif "PyPy" in sys_version: So we should change both occurrences then. I'm attaching a v2 with these changes. -- Added file: http://bugs.python.org/file32154/issue

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: The patch looks good, except one nit: if 'IronPython' in sys_version is probably not supported in IronPython 2.0, since support for "n-char in m-char" tests were added after Python 2.1. Now, you can either leave this in and remove the IronPython 2.0 suppo

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Changes by Berker Peksag : -- stage: needs patch -> patch review versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bu

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: I've checked sys.version on IronPython 2.6.1, 2.6.2 (same format) and 2.7.4 (slightly different). The patch includes two new test cases. I've also taken the liberty of adding some newlines in between the items in the dict as I found this code very hard to re

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Changes by Ezio Melotti : -- keywords: +easy versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Éric Araujo added the comment: This is the tracker for CPython, not IronPython, but I assume they synchronize their standard modules with ours, so I think this bug should be fixed here (not in 2.6 though, this old version only gets security fixes). Guidelines for patches: http://www.python.or

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Frederic Torres added the comment: Eric, Yes I like to. But I am not familiar how to submit a patch. The file that need to be patched is "C:\Program Files (x86)\IronPython 2.6\Lib\platform.py" for IronPython 2.6. I thought this file was maintained by Marc-Andre Lemburg wrote: > > Éric Araujo

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Éric Araujo added the comment: Do you want to work on a patch? -- nosy: +eric.araujo stage: -> needs patch title: Method _sys_version() module Lib\platform.py does not parse correctly IronPython 2.x version -> platform._sys_version does not parse correctly IronPython 2.x version