[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Stefan Krah stefan-use...@bytereef.org: -- nosy: -skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Zachary Ware added the comment: With the popup-supression context manager from #11732 in use and the buildbots using the regrtest '-n' option, I think we're at the point of being fixed enough and vote to close this issue. I'll leave the final decision to someone with a deeper understanding of the issue, though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: +steve.dower, tim.golden, zach.ware versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Ezio Melotti added the comment: Vinay commit made the test pass, but the popup is still present. Removing the popup is discussed in #11732. -- nosy: +ezio.melotti versions: +Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 4d74d275224d by Vinay Sajip in branch 'default': Issue #9116: Allowed test to pass on Windows by adjusting the test condition slightly to allow for a Windows-specific error message. http://hg.python.org/cpython/rev/4d74d275224d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: The AssertionError in Brian's initial post indicates that the test is too restrictive. Though the discussion here has talked about removing the popups altogether, the test passes on Windows with a small change: instead of assertEqual(), I used self.assertTrue(err.rstrip().startswith( b'Fatal Python error:' b' PyThreadState_Get: no current thread')) Patch attached. As this seems to be a sufficiently specific test, but not too specific, I'd like to apply this patch soon, unless someone thinks the test needs to stay exactly like it is. -- nosy: +vinay.sajip Added file: http://bugs.python.org/file25457/test_capi.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Stefan Krah stefan-use...@bytereef.org added the comment: I tested the patch, it works fine. I can't test the popup situation since I currently only have ssh access. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Terry J. Reedy tjre...@udel.edu added the comment: I just got 'fatal error' running python_d 3.3.a0 checked out yesterday. When I closed message, test continued (but really crashed later). -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Stefan Krah stefan-use...@bytereef.org added the comment: I just tried out http://www.bitvise.com/winsshd , which is free for personal and noncommercial use. If you run the tests via an ssh connection, WinSSHD automatically translates pop-ups into error messages: C:\Users\stefan\cdecimal\PCbuildpython.exe -m test -uall test_capi [1/1] test_capi Warning -- threading._dangling was modified by test_capi test test_capi failed -- Traceback (most recent call last): File C:\Users\stefan\cdecimal\lib\test\test_capi.py, line 51, in test_no_FatalError_infinite_loop b'Fatal Python error:' AssertionError: bFatal Python error: PyThreadState_Get: no current thread\n\r\nThis application has requested the Runtime to terminate it in an unusual way.\nPlease contact the application's support team for more information. != b'Fatal Python error: PyThreadState_Get: no current thread' 1 test failed: test_capi Thus, by using ... self.assertIn(b'Fatal Python error:', err.rstrip()) in test_capi, the tests pass without any further intervention! This is most interesting, to the point that I'm considering setting up a buildbot. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by STINNER Victor victor.stin...@haypocalc.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Catalin Iacob iacobcata...@gmail.com: -- nosy: +catalin.iacob ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Brian Curtin cur...@acm.org added the comment: The patch works for me. Unfortunately my knowledge on this particular area is very low so I can't really evaluate the patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Stefan Krah stefan-use...@bytereef.org added the comment: Hirokazu's patch works for me. Could this approach be taken in general to suppress all buildbot pop-ups? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Maybe is #5619 related? -- dependencies: +Pass MS CRT debug flags into subprocesses ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Here is the patch. On VS8.0 or above, * Avoid DebugBreak() call by IsDebuggerPresent(). * Tell abort() not to print message to console or window. -- keywords: +patch Added file: http://bugs.python.org/file18809/py3k_fix_test_capi_crash.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: After creating experimental patch, I could supress dialog and error message on VS8.0. But it seems there is no way to suppress error message on VC6. That is, FAILED (failures=1) Traceback (most recent call last): File e:\python-dev\py3k\lib\runpy.py, line 160, in _run_module_as_main __main__, fname, loader, pkg_name) File e:\python-dev\py3k\lib\runpy.py, line 73, in _run_code exec(code, run_globals) File e:\python-dev\py3k\lib\test\test_capi.py, line 182, in module test_main() File e:\python-dev\py3k\lib\test\test_capi.py, line 143, in test_main support.run_unittest(CAPITest) File e:\python-dev\py3k\lib\test\support.py, line 1127, in run_unittest _run_suite(suite) File e:\python-dev\py3k\lib\test\support.py, line 1110, in _run_suite raise TestFailed(err) test.support.TestFailed: Traceback (most recent call last): File e:\python-dev\py3k\lib\test\test_capi.py, line 50, in test_no_FatalErro r_infinite_loop b'Fatal Python error:' AssertionError: b'Fatal Python error: PyThreadState_Get: no current thread\r\n\r \nabnormal program termination' != b'Fatal Python error: PyThreadState_Get: no c urrent thread' This happens because abnormal program termination is output to stderr. Another capable sink to output error message into is messagebox, of cause it is not what we want. There is no way to silent this. I think there are a few options to take. * Skip this test on VC6 (And probably VS7.1) * Check not equality, but if stderr starts with Fatal Python -- nosy: +ocean-city priority: release blocker - normal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Georg Brandl ge...@python.org: -- priority: deferred blocker - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Georg Brandl ge...@python.org added the comment: Once again, this is not important enough block 3.2a2. -- priority: release blocker - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Éric Araujo mer...@netwok.org: -- keywords: -patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Stefan Krah stefan-use...@bytereef.org added the comment: I see the same crash in test_capi, qemu, Windows 7, Debug|x64. The function crash_no_current_thread() introduced in r81142 ultimately calls Py_FatalError, which then aborts. -- nosy: +skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Stefan Krah stefan-use...@bytereef.org added the comment: I just see that the test is running as expected: _testcapi.crash_no_current_thread() is running in a subprocess, so the abort() is harmless on Linux. On Windows, abort() causes the pop-ups, apparently even when it occurs in a subprocess. Perhaps we should generally use an ABORT() macro, which translates to exit() on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Florent Xicluna florent.xicl...@gmail.com: -- components: +Windows ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I said I saw same crash on test_threading in msg110902, but there is possibility that this is different problem. So I'll remove my patch and clear dependencies I set. -- dependencies: -Improve condition variable emulation on NT ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Removed file: http://bugs.python.org/file18091/py3k_ceval_gil.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- nosy: -ocean-city ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- dependencies: +Improve condition variable emulation on NT ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- priority: normal - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Antoine Pitrou pit...@free.fr added the comment: The patch shouldn't remove COND_RESET, otherwise there will be spurious wakeups. Also, it would be nice to have more precisions about the issue. At which point does PyThreadState_Get() fail? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Antoine Pitrou pit...@free.fr added the comment: I don't have much time at the moment to investigate, but I find it odd that this isn't occurring on the two Windows py3k buildbots. At least two of them (and perhaps the third -- I've asked Paul about it) are single-core virtual machines. What is your setup? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Georg Brandl ge...@python.org: -- priority: release blocker - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Brian Curtin cur...@acm.org added the comment: Both machines I've seen this on were true multicore, no VMs. One is dual core the other is 16. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Changes by Georg Brandl ge...@python.org: -- priority: deferred blocker - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I experienced this crash on test_thread.py. I created a patch hopefully to fix this issue. My knowleage about threading is not so deep, so maybe this patch is not so good. ;-) # I'm worried about COND_RESET which is not used in my patch. But # pthread variant is doing nothing on this macro... Now, test_thread.py runs fine. Reference: http://www.cs.wustl.edu/~schmidt/win32-cv-1.html http://msdn.microsoft.com/en-us/library/ms686293(VS.85).aspx http://www.linux.or.jp/JM/html/glibc-linuxthreads/man3/pthread_cond_init.3.html -- keywords: +patch nosy: +ocean-city Added file: http://bugs.python.org/file18091/py3k_ceval_gil.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
New submission from Brian Curtin cur...@acm.org: Debug and Release builds of py3k both throw up a Visual Studio debugger prompt when running this test on Windows. I don't have much time at the moment to investigate, but I find it odd that this isn't occurring on the two Windows py3k buildbots. Output of the release build after selecting not to debug: C:\python-dev\py3kPCbuild\amd64\python.exe -m test.regrtest test_capi test_capi test test_capi failed -- Traceback (most recent call last): File C:\python-dev\py3k\lib\test\test_capi.py, line 50, in test_no_FatalError_infinite_loop b'Fatal Python error:' AssertionError: bFatal Python error: PyThreadState_Get: no current thread\r\n\r \nThis application has requested the Runtime to terminate it in an unusual way.\ nPlease contact the application's support team for more information. != b'Fatal Python error: PyThreadState_Get: no current thread' 1 test failed: test_capi -- components: Interpreter Core, Tests messages: 108914 nosy: brian.curtin priority: normal severity: normal status: open title: test_capi.test_no_FatalError_infinite_loop crash on Windows type: crash versions: Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows
Brian Curtin cur...@acm.org added the comment: I should also note that this doesn't appear to happen on release31-maint or trunk. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9116 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
