[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Zachary Ware added the comment: With the popup-supression context manager from #11732 in use and the buildbots using the regrtest '-n' option, I think we're at the point of being "fixed enough" and vote to close this issue. I'll leave the final decision to someone with a deeper understanding

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Mark Lawrence : -- nosy: +steve.dower, tim.golden, zach.ware versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___ __

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Ezio Melotti added the comment: Vinay commit made the test pass, but the popup is still present. Removing the popup is discussed in #11732. -- nosy: +ezio.melotti versions: +Python 3.3, Python 3.4 ___ Python tracker

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Roundup Robot added the comment: New changeset 4d74d275224d by Vinay Sajip in branch 'default': Issue #9116: Allowed test to pass on Windows by adjusting the test condition slightly to allow for a Windows-specific error message. http://hg.python.org/cpython/rev/4d74d275224d -- nosy: +p

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Stefan Krah added the comment: I tested the patch, it works fine. I can't test the popup situation since I currently only have ssh access. -- ___ Python tracker ___ _

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Vinay Sajip added the comment: The AssertionError in Brian's initial post indicates that the test is too restrictive. Though the discussion here has talked about removing the popups altogether, the test passes on Windows with a small change: instead of assertEqual(), I used self.assertTr

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Terry J. Reedy added the comment: I just got 'fatal error' running python_d 3.3.a0 checked out yesterday. When I closed message, test continued (but really crashed later). -- nosy: +terry.reedy ___ Python tracker

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Stefan Krah added the comment: I just tried out http://www.bitvise.com/winsshd , which is free for personal and noncommercial use. If you run the tests via an ssh connection, WinSSHD automatically translates pop-ups into error messages: C:\Users\stefan\cdecimal\PCbuild>python.exe -m test -uall

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Catalin Iacob : -- nosy: +catalin.iacob ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Brian Curtin added the comment: The patch works for me. Unfortunately my knowledge on this particular area is very low so I can't really evaluate the patch. -- ___ Python tracker __

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Stefan Krah added the comment: Hirokazu's patch works for me. Could this approach be taken in general to suppress all buildbot pop-ups? -- ___ Python tracker ___

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Hirokazu Yamamoto added the comment: Maybe is #5619 related? -- dependencies: +Pass MS CRT debug flags into subprocesses ___ Python tracker ___ __

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Hirokazu Yamamoto added the comment: Here is the patch. On VS8.0 or above, * Avoid DebugBreak() call by IsDebuggerPresent(). * Tell abort() not to print message to console or window. -- keywords: +patch Added file: http://bugs.python.org/file18809/py3k_fix_test_capi_crash.patch ___

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Hirokazu Yamamoto added the comment: After creating experimental patch, I could supress dialog and error message on VS8.0. But it seems there is no way to suppress error message on VC6. That is, FAILED (failures=1) Traceback (most recent call last): File "e:\python-dev\py3k\lib\runpy.py", lin

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Georg Brandl : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Georg Brandl added the comment: Once again, this is not important enough block 3.2a2. -- priority: release blocker -> deferred blocker ___ Python tracker ___

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Éric Araujo : -- keywords: -patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Stefan Krah added the comment: I just see that the test is running as expected: _testcapi.crash_no_current_thread() is running in a subprocess, so the abort() is harmless on Linux. On Windows, abort() causes the pop-ups, apparently even when it occurs in a subprocess. Perhaps we should general

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Stefan Krah added the comment: I see the same crash in test_capi, qemu, Windows 7, Debug|x64. The function crash_no_current_thread() introduced in r81142 ultimately calls Py_FatalError, which then aborts. -- nosy: +skrah ___ Python tracker

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Florent Xicluna : -- components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Hirokazu Yamamoto : -- nosy: -ocean-city ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file18091/py3k_ceval_gil.patch ___ Python tracker ___ ___ Python-bugs-list

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Hirokazu Yamamoto added the comment: I said I saw same crash on test_threading in msg110902, but there is possibility that this is different problem. So I'll remove my patch and clear dependencies I set. -- dependencies: -Improve condition variable emulation on NT

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Hirokazu Yamamoto : -- dependencies: +Improve condition variable emulation on NT ___ Python tracker ___ ___ Python-bugs-list

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Georg Brandl : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Brian Curtin added the comment: Both machines I've seen this on were true multicore, no VMs. One is dual core the other is 16. -- ___ Python tracker ___

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Georg Brandl : -- priority: release blocker -> deferred blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Antoine Pitrou added the comment: > I don't have much time at the moment to investigate, but I find it odd > that > this isn't occurring on the two Windows py3k buildbots. At least two of them (and perhaps the third -- I've asked Paul about it) are single-core virtual machines. What is your s

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Antoine Pitrou added the comment: The patch shouldn't remove COND_RESET, otherwise there will be spurious wakeups. Also, it would be nice to have more precisions about the issue. At which point does PyThreadState_Get() fail? -- nosy: +pitrou ___ Pyt

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Changes by Hirokazu Yamamoto : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Hirokazu Yamamoto added the comment: I experienced this crash on test_thread.py. I created a patch hopefully to fix this issue. My knowleage about threading is not so deep, so maybe this patch is not so good. ;-) # I'm worried about COND_RESET which is not used in my patch. But # pthread varia

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

Brian Curtin added the comment: I should also note that this doesn't appear to happen on release31-maint or trunk. -- ___ Python tracker ___

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

New submission from Brian Curtin : Debug and Release builds of py3k both throw up a Visual Studio debugger prompt when running this test on Windows. I don't have much time at the moment to investigate, but I find it odd that this isn't occurring on the two Windows py3k buildbots. Output of