[issue9272] CGIHTTPServer poisons os.environ
Senthil Kumaran orsent...@gmail.com added the comment: Fix committed in revision 85202 (py3k), r85203 (release31-maint), r85204(release27-maint). I had change the patch to use copy.deepcopy instead of os.environ.copy() because for the purposes of test os.environ was masked with EnvironmentGuard which does not have copy method. Thanks for the patch. -- resolution: accepted - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
R. David Murray rdmur...@bitdance.com added the comment: Anatoly, last we heard you did not wish to sign the contributor agreement and so were not submitting patches. We are respecting your wishes by not applying this. Have you changed your mind? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
anatoly techtonik techto...@gmail.com added the comment: I still haven't received answers on the licensing questions in developer's mailing list. After the amount of negative feedback received I decided not to continue. But I am still interested in constructive discussion to get satisfying and full answers to the questions I've asked. You should understand that I can not sign agreements which terms are not clear to me, or if I think that other party fails to fulfill the conditions. I see the contributor's agreement text is changed again, but there is no history of changes, and no electronic signature, and looking through the text I still can't find it to be clear. As for this patch - I hereby release it into public domain, or if copyright law in your country doesn't allow that - I hereby grant you the right to use it on the terms of ISC license or WTFP license. If you still can't use the patch and can't explain me why the paragraph above is not enough, it is still possible to resolve the situation if you have some contacts at Google. I can submit my patch to Google and they'll send it to you. This will work, because I've signed http://code.google.com/legal/individual-cla-v1.0.html But this won't work if they didn't sign your form, of course. P.S. I want to see Python more open for contributions as well as you, but with more attention to details. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Georg Brandl ge...@python.org added the comment: ISTM that the attached patch is trivial enough not to require any contributor agreement or copyright assignment, at least if we change Ma Test CGI Server v1.0 to something neutral. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Changes by Éric Araujo mer...@netwok.org: -- stage: unit test needed - patch review versions: -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
anatoly techtonik techto...@gmail.com added the comment: So.. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
anatoly techtonik techto...@gmail.com added the comment: The test is hard to write. The server is launched in a separate thread. Any ideas how to check os.environ there? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
anatoly techtonik techto...@gmail.com added the comment: Ok. os.environ seems to be shared between threads. Here is updated patch. -- Added file: http://bugs.python.org/file18102/9272.CGIHTTPServer-poisons-os.environ.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Senthil Kumaran orsent...@gmail.com added the comment: The patch and the tests look good. I could verify it too. I shall commit it. -- assignee: - orsenthil resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Georg Brandl ge...@python.org added the comment: I don't think a deepcopy of the environment is necessary here. environ.copy() is just fine. Other than that, I agree with Eric. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
New submission from anatoly techtonik techto...@gmail.com: When CGIHTTPServer prepares to start child CGI program it modifies global os.environ. This implicitly changes parents application state if it also relies on some of CGI environment variables. -- messages: 110418 nosy: techtonik priority: normal severity: normal status: open title: CGIHTTPServer poisons os.environ versions: Python 2.6, Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Changes by anatoly techtonik techto...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file18024/9272.CGIHTTPServer-poisons-os.environ.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Changes by R. David Murray rdmur...@bitdance.com: -- components: +Library (Lib) nosy: +orsenthil, r.david.murray type: - behavior versions: +Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
anatoly techtonik techto...@gmail.com added the comment: Patch queue with other minor fixes you may consider useful http://bitbucket.org/techtonik/http.server-patches/qseries -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9272] CGIHTTPServer poisons os.environ
Eric Smith e...@trueblade.com added the comment: The change looks reasonable to me. It needs a test. -- nosy: +eric.smith stage: - unit test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9272 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
