Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
___
Antoine Pitrou added the comment:
Looks good to me.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
___
Serhiy Storchaka added the comment:
Jörg, Lars, can you please submit a contributor form?
http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
Roundup Robot added the comment:
New changeset 0a45896a7cde by Serhiy Storchaka in branch 'default':
Issue #9369: The types of `char*` arguments of PyObject_CallFunction() and
http://hg.python.org/cpython/rev/0a45896a7cde
--
nosy: +python-dev
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: accepted - fixed
stage: commit review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
Lars Buitinck added the comment:
I'm sorry, I really don't understand this refcounts.dat file and I'm not going
to hack it further. Does the patch as it currently stands solve the issue with
CallMethod and CallFunction, or not? (It has the changes to the docs.)
--
Lars Buitinck added the comment:
Any reason why this issue is still open? I just got a lot of compiler warnings
when building Numpy, so this isn't just relevant to C++ programmers.
(Btw., I did RTFM: the issue's Resolution is accepted but that option is not
documented.)
--
nosy:
Christian Heimes added the comment:
Let's try this again for 3.4
--
nosy: +christian.heimes
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
Lars Buitinck added the comment:
Redid the patch.
--
Added file: http://bugs.python.org/file28653/constness.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
Serhiy Storchaka added the comment:
Docs update needed.
Perhaps some other functions which accepts char* (i.e.
PyObject_CallMethodObjArgs or PyDict_GetItemString) should be fixed.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Lars Buitinck added the comment:
Oops, forgot to save changes to Doc/c-api/object.rst.
PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for
reference counting to work?
PyDict_GetItemString already has const, just not in refcounts.dat. Fixed.
--
Added file:
Serhiy Storchaka added the comment:
PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for
reference counting to work?
Then refcounts.dat wrong.
PyDict_GetItemString already has const, just not in refcounts.dat. Fixed.
There are a lot of char* arguments in
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Martin, what do you think about this kind of changes? Are there possible
regressions or incompatibilities?
--
nosy: +amaury.forgeotdarc, loewis
___
Python tracker rep...@bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
AFAICT, they are compatible, so +1.
The typical proposition of an incompatible change either proposes to use const
char* as the return type, or has multi-level pointers that are proposed to be
constified.
--
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Thanks for the confirmation!
--
resolution: - accepted
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
___
New submission from Jörg Müller nex...@gmail.com:
Patch attached
--
components: Interpreter Core
files: patch.diff
keywords: patch
messages: 111437
nosy: neXyon
priority: normal
severity: normal
status: open
title: const char* for PyObject_CallMethod and PyObject_CallFunction
type:
Jörg Müller nex...@gmail.com added the comment:
I've merged the patch with the changes from Armin in issue9368.
--
type: feature request - behavior
Added file: http://bugs.python.org/file18176/patch.diff
___
Python tracker rep...@bugs.python.org
Changes by Jörg Müller nex...@gmail.com:
Removed file: http://bugs.python.org/file18175/patch.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +aronacher
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9369
___
___
21 matches
Mail list logo
