[issue9731] Add ABCMeta.has_methods and tests that use it

Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9731] Add ABCMeta.has_methods and tests that use it

Change by Karthikeyan Singaravelan : -- pull_requests: -9633 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9731] Add ABCMeta.has_methods and tests that use it

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9731] Add ABCMeta.has_methods and tests that use it

Change by Jonathan Gossage : -- pull_requests: +9633 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9731] Add ABCMeta.has_methods and tests that use it

Laura Rupprecht added the comment: Related item: Added a helper function to verify API match of two modules, addressing issue9859. It checks for a closer match but mentioned this ticket from the thread. -- nosy: +laura ___ Python tracker

[issue9731] Add ABCMeta.has_methods and tests that use it

Serhiy Storchaka added the comment: What if abstract class contains not only abstract methods, but default implementation of some methods? Should the predicate test if tested class contain these methods? For example, the Sequence ABC contains default implementation of __iter__. Should the

[issue9731] Add ABCMeta.has_methods and tests that use it

Changes by Claudiu Popa pcmantic...@gmail.com: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9731 ___ ___

[issue9731] Add ABCMeta.has_methods and tests that use it

Mark Lawrence added the comment: Can we have a formal patch review with a view to committing as this issue is referenced from #9859. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9731

[issue9731] Add ABCMeta.has_methods and tests that use it

Claudiu.Popa added the comment: I have updated the previous patch, by documenting the new class method. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file35027/issue9731.patch ___ Python tracker rep...@bugs.python.org

[issue9731] Add ABCMeta.has_methods and tests that use it

Claudiu.Popa added the comment: Hello! Here's a preliminary implementation, with tests for collections ABC. It doesn't have any docs yet, though. I chose the name verify_full_api, but I'm ok with check_methods as well. -- keywords: +patch nosy: +Claudiu.Popa versions: +Python 3.4

[issue9731] Add ABCMeta.has_methods and tests that use it

Changes by Daniel Urban urban.dani...@gmail.com: -- nosy: +durban ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9731 ___ ___ Python-bugs-list

[issue9731] Add ABCMeta.has_methods and tests that use it

Terry J. Reedy tjre...@udel.edu added the comment: Good idea! I see Raymond's point about the name. How about .method_check? To me Sequence.method_check(range) means Abstract Seqeunce class, please method-check the concrete range class. If Sequence.register(range) is in the range source file,

[issue9731] Add ABCMeta.has_methods and tests that use it

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment: I agree that my original name proposal is terrible. :-) method_check and verify_full_api both look fine to me. If all collection registrations were bundled together in collections.py, I think I would expect the tests to be

[issue9731] Add ABCMeta.has_methods and tests that use it

Éric Araujo mer...@netwok.org added the comment: I wanted to propose the name check_methods, but then I thought that some people could read too much in that name, for example that arguments and return value are checked for correct type and value (see how Web people misunderstand “HTML

[issue9731] Add ABCMeta.has_methods and tests that use it

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment: Re-opening and re-titling the issue to that effect. Proposed syntax and usage: # in Lib/abc.py class ABCMeta(type): # ... def has_methods(cls, subclass): Returns True iff subclass implements the appropriate

[issue9731] Add ABCMeta.has_methods and tests that use it

Raymond Hettinger rhettin...@users.sourceforge.net added the comment: +1 for the basic idea. It could use a better name, Sequence.has_methods(range) reads backwards to me. Perhaps something like: Sequence.implemented_by(range) or Sequence.verify_full_api(range) or some such. Also, when the