[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Davin Potts]

Changes by Davin Potts pyt...@discontinuity.net:


--
nosy: +davin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Mark Lawrence]

Mark Lawrence added the comment:

Where do we currently stand with all compiler warnings, I'm still seeing some 
but I recall that we've other open issues about this problem?

--
nosy: +serhiy.storchaka, steve.dower, zach.ware
versions: +Python 3.4, Python 3.5 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Mark Lawrence]

Mark Lawrence added the comment:

I'd assume that these were cleared years ago.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Jon Anglin]

Changes by Jon Anglin jang...@fortresgrand.com:


--
nosy: +janglin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

It seems that multiprocessing is fairly conservative wrt. 64-bit support. For 
example, conn_send_string has a string limit of 0x7fff. Therefore, several 
of the warnings are harmless; the respective lengths fit into int just fine.

I recommend that the size_t parameters are converted to int in the places where 
this is actually known to be correct from control flow (e.g. both cases of 
conn_send_string), along with an assert() that the value being cast is = 
INT_MAX. 

IIUC, _conn_recvall can legitimately return int, no need to return Py_ssize_t: 
it will only return error codes (possibly MP_SUCCESS). Also, it might be 
sufficient to restrict the length of _conn_recvall to MAX_INT.

The alternate route would be to actually widen socket_connection to support 64 
bit transmits (*); this would be Jesse's call. It's probably acceptable to 
defer this until somebody needs this enough to contribute a patch. Copying 2GiB 
over a pipe takes 1.5s on my system.

(*) My protocol proposal would be this: a length with the highest bit set (i.e. 
= 0x8000) indicates a huge message, where another four bytes of of length 
follow, for a total of 63 bits of length (MSB is unavailable as it serves as 
the length-of-length indicator). This would not waste bytes for small messages, 
and be backwards compatible.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9782] _multiprocessing.c warnings under 64-bit Windows

[Antoine Pitrou]

New submission from Antoine Pitrou pit...@free.fr:

There are various warnings when compiling the _multiprocessing extension in 
64-bit mode under Windows. Many seem related to the fact that read() and 
friends under Windows take int size arguments rather than size_t.

20-- Build started: Project: _multiprocessing, Configuration: Release x64 
--
20Compiling...
20multiprocessing.c
20win32_functions.c
20socket_connection.c
20..\Modules\_multiprocessing\socket_connection.c(32) : warning C4267: 
'function' : conversion from 'size_t' to 'int', possible loss of data
20..\Modules\_multiprocessing\socket_connection.c(54) : warning C4267: 
'function' : conversion from 'size_t' to 'int', possible loss of data
20..\Modules\_multiprocessing\socket_connection.c(126) : warning C4244: '=' : 
conversion from 'Py_ssize_t' to 'int', possible loss of data
20..\Modules\_multiprocessing\socket_connection.c(137) : warning C4244: '=' : 
conversion from 'Py_ssize_t' to 'int', possible loss of data
20..\Modules\_multiprocessing\socket_connection.c(145) : warning C4244: '=' : 
conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(139) : warning C4244: 
'=' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(183) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(237) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(285) : warning C4244: 
'=' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(323) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20semaphore.c
20pipe_connection.c
20..\Modules\_multiprocessing\pipe_connection.c(24) : warning C4267: 
'function' : conversion from 'size_t' to 'DWORD', possible loss of data
20..\Modules\_multiprocessing\pipe_connection.c(50) : warning C4267: 
'function' : conversion from 'size_t' to 'DWORD', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(139) : warning C4244: 
'=' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(183) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(237) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(285) : warning C4244: 
'=' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20z:\py3k\__svn__\modules\_multiprocessing\connection.h(323) : warning C4244: 
'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
20Linking...
20   Creating library Z:\py3k\__svn__\PCbuild\\amd64\\_multiprocessing.lib and 
object Z:\py3k\__svn__\PCbuild\\amd64\\_multiprocessing.exp
20Generating code
20Finished generating code
20Build log was saved at 
file://Z:\py3k\__svn__\PCbuild\x64-temp-Release\_multiprocessing\BuildLog.htm
20_multiprocessing - 0 error(s), 17 warning(s)

--
components: Extension Modules, Windows
messages: 115699
nosy: brian.curtin, jnoller, pitrou, tim.golden
priority: normal
severity: normal
stage: needs patch
status: open
title: _multiprocessing.c warnings under 64-bit Windows
type: compile error
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9782
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com