[issue9784] _msi.c warnings under 64-bit Windows

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Steve Dower]

Steve Dower added the comment:

We'd need a contributor agreement from Jon anyway, so unless he rejoins this 
thread and is willing to sign that, there's little point looking at the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
components: +Windows
nosy: +steve.dower, tim.golden, zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Mark Lawrence]

Mark Lawrence added the comment:

Could somebody review the patch please as it's well over my head.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Jon Anglin]

Jon Anglin jang...@fortresgrand.com added the comment:

I have uploaded another patch that replaces CRT API calls with Win32 API calls. 
 It compiles cleanly under 32 and 64 bit Windows. Is there a unit test for 
msilib? I was not able to find one, thus the patch is not fully tested.

--
Added file: http://bugs.python.org/file19065/issue9784.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

 Martin Lowis do you mean API when you type SDK?

When I said SDK examples, then I really meant examples as published
in the SDK, not examples as published in the API (and the SDK
documentation, in turn, is published on msdn).
But yes, the SDK examples use Win32 directly.

 If I understand what you are saying, you would rather use the Win32
 API instead of the CRT API?

Correct.

 It may interest you to know that _open calls CreateFile internally,
 _read calls ReadFile, _write calls WriteFile, _lseek calls
 SetFilePointer, and _close calls CloseHandle. 

I'm fully aware of that.

 We could rewrite the functions using the Win32 API directly but we
 don’t have to.  I realize this is a Windows only module but the use
 of the CRT API is more familiar to a majority of the Python
 developers (I would guess).

I have the long-term plan to eliminate all CRT usage from Python
on Windows. In this case, there is a straight-forward opportunity
to do so. Nothing is really gained from using the CRT (as the cabinet
SDK is probably even less familiar to Python developers than
CreateFile), plus using the CRT causes compiler warnings, as
Microsoft clearly intends that these routines would be implemented
using the Windows API directly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Jon Anglin]

Jon Anglin jang...@fortresgrand.com added the comment:

 I have the long-term plan to eliminate all CRT usage from Python
 on Windows. In this case, there is a straight-forward opportunity
 to do so.

Oh, OK. If that is the plan then I am on board. I will re-code the patch using 
the Win32 API directly.

 It may interest you to know that _open calls CreateFile internally,
 I'm fully aware of that.

I meant no disrespect, I just didn't know if you were a Windows guy. If you 
asked me what system call _open (or others) calls on Linux or Mac, I would have 
no clue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

-1 for the patch. I still maintain that it is better to follow the current SDK.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

Which SDK Example are you referring to? I could not find any example.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

See, for example, the link you gave in msg115750. It has this sample code in it 
(listed in the Examples section):

FNFCIREAD(fnFileRead)
{
DWORD dwBytesRead = 0;

UNREFERENCED_PARAMETER(pv);

if( ReadFile((HANDLE)hf, memory, cb, dwBytesRead, NULL) == FALSE )
{
dwBytesRead = (DWORD)-1;
*err = GetLastError();
}
 
return dwBytesRead;
}

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Jon Anglin]

Jon Anglin jang...@fortresgrand.com added the comment:

Martin Lowis do you mean API when you type SDK?  If I understand what you are 
saying, you would rather use the Win32 API instead of the CRT API?  

It may interest you to know that _open calls CreateFile internally, _read calls 
ReadFile, _write calls WriteFile, _lseek calls SetFilePointer, and _close calls 
CloseHandle.  There is a bit more to it than that but it is not really relevant 
to this discussion.

What is relevant is that inside _open, CreateFile will return an OS HANDLE type 
(64 bits in our case) that is mapped to a 32 bit integer CRT file descriptor 
that is then returned.  The other functions such as _read, etc…, will look up 
the 64 bit OS HANDLE value from the given 32 bit file descriptor and call the 
corresponding Win32 API function.

We could rewrite the functions using the Win32 API directly but we don’t have 
to.  I realize this is a Windows only module but the use of the CRT API is more 
familiar to a majority of the Python developers (I would guess).

I stand by the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Jon Anglin]

Jon Anglin jang...@fortresgrand.com added the comment:

issue9784.diff contains a patch that compiles clean on 32 and 64 bit Windows. 
This patch is exactly what Amaury Forgeot d'Arc recommended in msg115750.

--
keywords: +patch
Added file: http://bugs.python.org/file18989/issue9784.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Jon Anglin]

Changes by Jon Anglin jang...@fortresgrand.com:


--
nosy: +janglin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

It's probably best to rewrite these functions in the way the SDK Example 
section works (i.e. CreateFile/ReadFile) instead of _open/_read (*). As Amaury 
says, the warnings are harmless: the file numbers will always be in range, as 
_open created them that way (in fact, they will most likely be below 20 or so).

(*) They must have changed the SDK docs over time; IIRC, I already copied the 
current text (using _open) from the SDK docs back then.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

FNFCIREAD co are macros to help the definition of callback functions:
http://msdn.microsoft.com/en-us/library/ff797940.aspx

hf is defined as INT_PTR, but the value it receives is the result of 
FNFCIOPEN(), which fits in int.
It is safe to cast hf to an int if you want to disable the warning.

--
keywords: +easy
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9784] _msi.c warnings under 64-bit Windows

[Antoine Pitrou]

New submission from Antoine Pitrou pit...@free.fr:

I'm posting this in case it is a sign of a problem. Apparently some variable 
named hf is an INT_PTR used as an int (according to Visual Studio), but hf 
doesn't seem to be defined or declared in _msi.c at all.

12..\PC\_msi.c(66) : warning C4244: 'function' : conversion from 'INT_PTR' to 
'int', possible loss of data
12..\PC\_msi.c(74) : warning C4244: 'function' : conversion from 'INT_PTR' to 
'int', possible loss of data
12..\PC\_msi.c(82) : warning C4244: 'function' : conversion from 'INT_PTR' to 
'int', possible loss of data
12..\PC\_msi.c(90) : warning C4244: 'function' : conversion from 'INT_PTR' to 
'int', possible loss of data

--
components: Extension Modules
messages: 115701
nosy: loewis, pitrou
priority: normal
severity: normal
status: open
title: _msi.c warnings under 64-bit Windows
type: compile error
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com