[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: I created bpo-35471: "Remove macpath module". -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: Ok, I don't see any open task anymore, so I close this issue. The macpath may or may not be removed in Python 3.8, so not before 2018-01-29. IMHO it's ok to remove the module, macpath was used for MacOS 9, but all macOS users are now running macOS X. Otherwise

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: No, the current code LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: >> I looked at this function, but I don't want to skip the test if the module >> cannot be imported. > > You can pass required_on=('',). ('',) looks mysterious to me. I prefer my current code. If you consider that an helper is required, I would prefer a more e

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: > I looked at this function, but I don't want to skip the test if the module > cannot be imported. You can pass required_on=('',). -- ___ Python tracker

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: New changeset d812eb731d886065bdd9bc94a3f0e5dfdcd671a4 by Victor Stinner in branch 'master': bpo-9850: Document macpath deprecation in Misc/NEWS (#1590) https://github.com/python/cpython/commit/d812eb731d886065bdd9bc94a3f0e5dfdcd671a4 --

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: Serhiy Storchaka: "And please add a Misc/NEWS entry." I created https://github.com/python/cpython/pull/1590 Serhiy: "You can use test.support.import_module(deprecated=True) for importing deprecated module in tests." I looked at this function, but I don't wan

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by STINNER Victor : -- pull_requests: +1683 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue9850] obsolete macpath module dangerously broken and should be removed

Jim Fasarakis-Hilliard added the comment: Great! Also, as Mariatta mentioned in a previous message, shouldn't an entry in PEP-4 be made? -- ___ Python tracker ___ ___

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: And please add a Misc/NEWS entry. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: You can use test.support.import_module(deprecated=True) for importing deprecated module in tests. -- versions: -Python 3.6 ___ Python tracker ___

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: > Bump, any update on what to do with this issue? I just deprecated the macpath module in Python 3.7. It will be removed from Python 3.8. -- ___ Python tracker ___

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: New changeset 89a1c93f046f9726310f8362227be7b8e50eea22 by Victor Stinner in branch 'master': bpo-9850: Deprecate the macpath module (#1540) https://github.com/python/cpython/commit/89a1c93f046f9726310f8362227be7b8e50eea22 -- _

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: > Bump, any update on what to do with this issue? I updated and completed Chi Hsuan Yen's 3.6-deprecate-macpath.patch to create a pull request. I suggest to start by deprecating macpath in 3.7, and remove it from Python 3.8. This module is here for years. mac

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by STINNER Victor : -- pull_requests: +1639 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue9850] obsolete macpath module dangerously broken and should be removed

Jim Fasarakis-Hilliard added the comment: Bump, any update on what to do with this issue? -- nosy: +Jim Fasarakis-Hilliard ___ Python tracker ___ _

[issue9850] obsolete macpath module dangerously broken and should be removed

Mariatta Wijaya added the comment: I'm just reading PEP-4 now for procedure of declaring a module deprecated. Should PEP-4 page be updated with the proposal / info for macpath deprecation? https://www.python.org/dev/peps/pep-0004/ Thanks. -- ___ Pyt

[issue9850] obsolete macpath module dangerously broken and should be removed

Chi Hsuan Yen added the comment: Oops forgot to commit deleted files in the 3.7 patch. -- Added file: http://bugs.python.org/file44932/3.7-remove-macpath_ver2.patch ___ Python tracker ___

[issue9850] obsolete macpath module dangerously broken and should be removed

Chi Hsuan Yen added the comment: Here are my tries. There are more MacOS-specific module names in Tools/freeze/freeze.py. They are unrelated to macpath so I leave them to the next bug. -- Added file: http://bugs.python.org/file44931/3.7-remove-macpath.patch ___

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Chi Hsuan Yen : Added file: http://bugs.python.org/file44930/3.6-deprecate-macpath.patch ___ Python tracker ___ ___ Python-bugs-list

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Berker Peksag : -- keywords: +easy -needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue9850] obsolete macpath module dangerously broken and should be removed

Ned Deily added the comment: It's a bit late in the 3.6 cycle to be removing macpath, but it's not too late to mark it in 3.6 as deprecated and to be removed in 3.7. If someone wants to write two patches, one for 3.6 to add a deprecation warning to the code and to the docs, the other for 3.7

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Scott Macpherson : -- nosy: +macpherson.scott ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: In third-party code the path manipulating functions can be used in unexpected manner than doesn't relate to paths on MacOS. Also "import macpath" can be left even with the use of macpath was eliminated or are dead code. There is a chance to break third-party

[issue9850] obsolete macpath module dangerously broken and should be removed

Ronald Oussoren added the comment: I think it is by now safe to remove macpath, AFAIK there is no real use-case anymore for having classic MacOS9 paths on any recentish version of OSX.] I'm setting the version to 3.6 because it is too late to do this for Python 3.5, but it can be done for 3.6.

[issue9850] obsolete macpath module dangerously broken and should be removed

Serhiy Storchaka added the comment: Committed macpath_join_fix_with_test.patch with some additional tests. Thank you for your contribution Oleg. Needed a patch for deprecating all module or some functions. -- nosy: +serhiy.storchaka stage: commit review -> needs patch type: behavior ->

[issue9850] obsolete macpath module dangerously broken and should be removed

Roundup Robot added the comment: New changeset 2ae2ca9d2b66 by Serhiy Storchaka in branch '2.7': Issue #9850: Fixed macpath.join() for empty first component. Patch by https://hg.python.org/cpython/rev/2ae2ca9d2b66 New changeset 54987723de99 by Serhiy Storchaka in branch '3.4': Issue #9850: Fixe

[issue9850] obsolete macpath module dangerously broken and should be removed

Ned Deily added the comment: The patch appears fine but it really doesn't have anything to do with the gist of this issue. The problem remains that much of macpath is fundamentally broken. In the intervening years since the issue was opened, I contend that any need for OS 9 style paths (aka

[issue9850] obsolete macpath module dangerously broken and should be removed

Jessica McKellar added the comment: Thanks for writing up this issue, ned.deily, and thanks for providing a patch, chortos. I couldn't find documentation clearly specifying what the correct behavior of macpath.join should be (i.e. what are the exact rules for leading and trailing colons), but

[issue9850] obsolete macpath module dangerously broken and should be removed

Oleg Oshmyan added the comment: It is already tested but here is a new version of the patch that expands the existing test to cover the situation that was broken (plus another one). -- Added file: http://bugs.python.org/file22943/macpath_join_fix_with_test.patch __

[issue9850] obsolete macpath module dangerously broken and should be removed

Éric Araujo added the comment: Thanks for the patch. Is the function already tested or does someone need to add a test? -- ___ Python tracker ___ __

[issue9850] obsolete macpath module dangerously broken and should be removed

Oleg Oshmyan added the comment: I fully agree with Ronald’s proposal. And for a start, here is a trivial patch that fixes macpath.join('', ...) [at the moment it just returns its last argument]. By the way, this fix is probably eligible for inclusion in Python 2.7 too. I also have ‘implement

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Éric Araujo : -- versions: +Python 3.3 -Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list maili

[issue9850] obsolete macpath module dangerously broken and should be removed

Éric Araujo added the comment: I agree with Ronald’s proposal. (Re “I don't remember if I redid my OS9-removal work”: Looks like you didn’t.) -- nosy: +eric.araujo ___ Python tracker __

[issue9850] obsolete macpath module dangerously broken and should be removed

Ned Deily added the comment: Patches in progress. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue9850] obsolete macpath module dangerously broken and should be removed

Ronald Oussoren added the comment: MacOS9 is already unsupported, except for macpath all traces of OS9 support are gone with the possible exception of distutils (I removed traces of OS9 support code in 3.2 and those got restored when Tarek replaced distutils by the version from the 3.1 branch

[issue9850] obsolete macpath module dangerously broken and should be removed

Ronald Oussoren added the comment: I'm -0 on removing the module wholesale because parts of OSX still use MacOS9 style paths (in particular some Carbon APIs and AppleScript). I'm +1 on removing all functions that aren't path manipulation code, that is 'macpath.join' would stay while 'macpath.

[issue9850] obsolete macpath module dangerously broken and should be removed

STINNER Victor added the comment: The solution may be different depending on Python version. I propose to keep macpath in Python 2.7, just because it's too late to change such thing in Python2. But we may mark macpath as deprecated, eg. "macpath will be removed in Python 3.2" (see above). I s

[issue9850] obsolete macpath module dangerously broken and should be removed

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg116365 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue9850] obsolete macpath module dangerously broken and should be removed

Ned Deily added the comment: The macpath module in the standard library purports to supply "the Mac OS 9 (and earlier) implementation of the os.path module. It can be used to manipulate old-style Macintosh pathnames on Mac OS X (or any other platform). The following functions are available

[issue9850] obsolete macpath module dangerously broken and should be removed

New submission from Ned Deily : The macpath module in the standard library purports to supply "the Mac OS 9 (and earlier) implementation of the os.path module. It can be used to manipulate old-style Macintosh pathnames on Mac OS X (or any other platform). The following functions are availabl