[issue9859] Add tests to verify API match of modules with 2 implementations

Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Berker Peksag added the comment: Thanks for the patch! I've reviewed it on Rietveld: http://bugs.python.org/review/9859/ -- nosy: +berker.peksag stage: needs patch - patch review versions: +Python 3.5 -Python 3.2 ___ Python tracker

[issue9859] Add tests to verify API match of modules with 2 implementations

Daniel Stutzbach added the comment: With regret, I have not had time to work on patches and am unlikely to have time in the near future. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859

[issue9859] Add tests to verify API match of modules with 2 implementations

Laura Rupprecht added the comment: Created a patch to check whether classes define the same attributes. This adds a test for RawIOBase, where Python and and C implementations are out of sync, but skips one of the tests as the issue (issue9858) is still outstanding. -- keywords:

[issue9859] Add tests to verify API match of modules with 2 implementations

Changes by Gregory P. Smith g...@krypto.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Berker Peksag added the comment: Thanks :) -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___ ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Laura Rupprecht added the comment: Thanks Berker! I've added some updates to the patch taking your suggestions into account. There is also a change from using detect_module_matches to detect_api_mismatch, as it is a more general (and accurate) description. Also, adding tests for the

[issue9859] Add tests to verify API match of modules with 2 implementations

Roundup Robot added the comment: New changeset 9903368b9d7b by Gregory P. Smith in branch 'default': issue9859: rename CPyMatchTest to APIMismatchTest and add @support.cpython_only. https://hg.python.org/cpython/rev/9903368b9d7b New changeset cbdd56d07123 by Gregory P. Smith in branch

[issue9859] Add tests to verify API match of modules with 2 implementations

Berker Peksag added the comment: I've added a couple of comments about the test: http://bugs.python.org/review/9859/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Roundup Robot added the comment: New changeset b42d1f2aa7a2 by Gregory P. Smith in branch 'default': issue9859: Adds a test.support.detect_api_mismatch function useful to https://hg.python.org/cpython/rev/b42d1f2aa7a2 New changeset 0b6c894c3c96 by Gregory P. Smith in branch 'default':

[issue9859] Add tests to verify API match of modules with 2 implementations

Gregory P. Smith added the comment: Thanks! Patch applied. I reworded one doc string slightly and fixed up a few lines that were longer than 80 characters. Berker's most recent comments are good ones and can be addressed in another patch. Laura, can you jump through the

[issue9859] Add tests to verify API match of modules with 2 implementations

Roundup Robot added the comment: New changeset 0316811f33b2 by Gregory P. Smith in branch 'default': issue9859: add the missing versionadded tag to the documentation. https://hg.python.org/cpython/rev/0316811f33b2 -- ___ Python tracker

[issue9859] Add tests to verify API match of modules with 2 implementations

Roundup Robot added the comment: New changeset c6df85e1d42e by Gregory P. Smith in branch 'default': issue9859: Use an expected failure rather than a skip. https://hg.python.org/cpython/rev/c6df85e1d42e -- ___ Python tracker rep...@bugs.python.org

[issue9859] Add tests to verify API match of modules with 2 implementations

Mark Lawrence added the comment: @Daniel do you intend putting forward a formal patch on this issue? I'm asking as I think issue9858 is effectively completed and I've just asked for a formal patch review on Issue9731. -- nosy: +BreamoreBoy ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Changes by Éric Araujo mer...@netwok.org: -- nosy: +belopolsky, brett.cannon, eric.araujo, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___

[issue9859] Add tests to verify API match of modules with 2 implementations

Terry J. Reedy tjre...@udel.edu added the comment: +1 I presume you can use the experience with #9858 to either refine the program to have fewer false positives or refine the program doc to explain the possibility where such are unavoidable. (And as a lint-like metatest, I think false

[issue9859] Add tests to verify API match of modules with 2 implementations

New submission from Daniel Stutzbach dan...@stutzbachenterprises.com: Recently it came to light that the classes in C and Python implementations of the io module have slightly different attributes (issue9858). I propose the addition of a helper function in Lib/test/support.py to verify that

[issue9859] Add tests to verify API match of modules with 2 implementations

R. David Murray rdmur...@bitdance.com added the comment: Shouldn't the test suite catch such discrepancies by testing all of the API? So your script catching something would be the equivalent of oops, we forgot a test (or oops, this name shouldn't be public). Which is not a bad thing to

[issue9859] Add tests to verify API match of modules with 2 implementations

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment: Yes, exactly. :-) (see also Issue9731, which has a similar flavor) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859