[issue1575] typo in README

2007-12-09 Thread Georg Brandl
Georg Brandl added the comment: Don't worry, this is what bots are here for :) Fixed in r59436. -- nosy: +georg.brandl resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1575

[issue1571] Better description of 'L' repr removal in What's New

2007-12-09 Thread Georg Brandl
Georg Brandl added the comment: Thanks, fixed in r59438. -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1571 __ ___

[issue1564547] Py_signal_pipe

2007-12-09 Thread Gustavo J. A. M. Carneiro
Gustavo J. A. M. Carneiro added the comment: Minimal patch that just adds the pipe but does not attempt to fix anything else. Added file: http://bugs.python.org/file8898/python-signals-minimal.diff _ Tracker [EMAIL PROTECTED]

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Christian Heimes
Changes by Christian Heimes: Removed file: http://bugs.python.org/file8896/py3k_optimize_set_unicode.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564 __ ___

[issue1573] Improper use of the keyword-only syntax makes the parser crash

2007-12-09 Thread Christian Heimes
Christian Heimes added the comment: I'm fine with your patch. Can you commit it please? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1573 __ ___ Python-bugs-list mailing list

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: The patch doesn't parallel what was done for dicts. The code in dictobject.c does not use a macro. It special cases for PyUnicode but not PyString. Please submit a patch that mirrors what was done for dicts. __ Tracker

[issue1564547] Py_signal_pipe

2007-12-09 Thread Adam Olsen
Adam Olsen added the comment: The minimal patch doesn't initialize dummy_char or dummy_c. It's harmless here, but please fix it. ;) sizeof(dummy_char) will always be 1 (C defines sizeof as multiples of char.) The convention seems to be hardcoding 1 instead.

[issue1564547] Py_signal_pipe

2007-12-09 Thread Gustavo J. A. M. Carneiro
Gustavo J. A. M. Carneiro added the comment: The minimal patch doesn't initialize dummy_char or dummy_c. It's harmless here, but please fix it. ;) The variable is called 'dummy' for a reason. The value written or read is irrevelant... _ Tracker [EMAIL

[issue1576] First draft of a post import hook

2007-12-09 Thread Christian Heimes
New submission from Christian Heimes: I've written a rough draft for a post import hook as discussed on the python 3000 mailing list. The implementation is far from perfect. It requires more unit tests, a code review and reference count checks. -- assignee: tiran components: Interpreter

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Skip Montanaro added the comment: Okay, here's my latest patch (datetime-f.diff). 2.6 only at this point. Added file: http://bugs.python.org/file8901/datetime-f.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1158

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Changes by Skip Montanaro: Removed file: http://bugs.python.org/file8438/dt-26.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1158 __ ___ Python-bugs-list mailing list

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Skip Montanaro added the comment: Actually, I think I will avoid the 3.0 patch altogether and let these changes propagate from trunk to py3k by whoever works that magic. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1158

[issue1677872] Efficient reverse line iterator

2007-12-09 Thread Mark Russell
-related stuff from the expected output, as currently these tests break whenever io.py is changed. Added file: http://bugs.python.org/file8902/reverse-file-iterator-20071209.diff _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1677872

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Changes by Skip Montanaro: Removed file: http://bugs.python.org/file8439/dt-30.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1158 __ ___ Python-bugs-list mailing list

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Changes by Skip Montanaro: Removed file: http://bugs.python.org/file8901/datetime-f.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1158 __ ___ Python-bugs-list mailing

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Christian Heimes
Christian Heimes added the comment: Updates: * Moved dictobject.c:unicode_eq() to unicodeobject.c:_PyUnicode_Eq() * Added another optimization step to _PyUnicode_Eq(). The hash is required later anyway and comparing two hashes is much faster than memcmp-ing the unicode objects. if

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Christian Heimes
Changes by Christian Heimes: Removed file: http://bugs.python.org/file8899/py3k_optimize_set_unicode.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564 __ ___

[issue1576] First draft of a post import hook

2007-12-09 Thread Phillip J. Eby
Phillip J. Eby added the comment: It also needs to hold the import lock during both the register and notify operations. In addition, the notify operation needs to be exposed for calling from Python (so that lazy module implementations can interop). Finally, it's not clear to me whether

[issue1573] Improper use of the keyword-only syntax makes the parser crash

2007-12-09 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Committed revision 59443. -- status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1573 __ ___ Python-bugs-list

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: Which is the common case in Py3k, to have strings or unicode? By trying to catch both, you slow down the optimization. Also, the new hash_fast introduces function call overhead in previously in- lined code. My preference is to knock-out the optimization

[issue1577] shutil.move() does not use os.rename() if dst is a directory

2007-12-09 Thread Ingemar Nilsson
New submission from Ingemar Nilsson: If you use shutil.move(src, dst) to move a file src to a directory dst, the file will not be renamed into the dst directory, but rather copied-then-removed, even if src and dst is on the same filesystem. There are several ways to fix this: * (The easiest)

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Christian Heimes
Changes by Christian Heimes: Added file: http://bugs.python.org/file8905/py3k_optimize_set_unicode3.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564 __ ___

[issue1576] First draft of a post import hook

2007-12-09 Thread Christian Heimes
Christian Heimes added the comment: I've moved the result = PyImport_NotifyPostImport(result); inside the protected block. It's now protected by the import lock. I've also added the lock protection to the register function. The notify method is now exposed through the imp module, too. I've

[issue1576] First draft of a post import hook

2007-12-09 Thread Christian Heimes
Changes by Christian Heimes: Removed file: http://bugs.python.org/file8900/py3k_post_import_hook.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1576 __ ___

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: Okay, then simply go back to the unaltered existing code and replace references to PyString with PyUnicode. Skip all the macros, new functions, factorings, etc. Just change strings to unicode and be done with it. IIRC, that was what was done for dicts.

[issue1202] zlib.crc32() and adler32() return value

2007-12-09 Thread Tim Lesher
Tim Lesher added the comment: Both CRC-32 and ADLER32 are standards (described in ISO 3309 and RFC 1950 respectively); whatever fix implemented should make sure that the output complies. ISO 3309 isn't available online as far as I can see, but CRC-32 reference code is published in RFC 1952;

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-09 Thread Christian Heimes
Christian Heimes added the comment: The latest patch does *NOT* add new macros, functions or other stuff. I simply replaced PyString_* with PyUnicode_* in setobject.c where appropriate. The only function I had to factor out is unicode_eq(). It's now in a new file stringlib/eq.h which is

[issue1578] Problems in win_getpass

2007-12-09 Thread vizcayno
New submission from vizcayno: .python Python 3.0a2 (r30a2:59397:59399, Dec 6 2007, 22:34:52) [MSC v.1500 32 bit (Intel)] on win32 Type help, copyright, credits or license for more information. import getpass clave = getpass.getpass('PASSWD= ').strip().upper() PASSWD= Traceback (most recent

[issue1158] %f format for datetime objects

2007-12-09 Thread Skip Montanaro
Skip Montanaro added the comment: Stop me before I update it again! This update touches up datetime_strptime a bit. It's more uniform and a bit faster. Added file: http://bugs.python.org/file8907/datetime-f.diff __ Tracker [EMAIL PROTECTED]

[issue1597850] Cross compiling patches for MINGW

2007-12-09 Thread John Stowers
John Stowers added the comment: Hello, I recently tried this in combination with jhbuild, cross compiling with mingw (to built some python gtk extensions). I tried you patch against the 2.5.1 version and recieved the following error: checking for /dev/ptmx... yes checking for /dev/ptc... no

[issue1597850] Cross compiling patches for MINGW

2007-12-09 Thread John Stowers
John Stowers added the comment: Sorry, I should have clarified further in my last comment. Looking over the configure script I don't recognize the %zd test as one that could be circumvented by supplying a config.cache file with the appropriate values. How do I escape this limitation?

[issue1597850] Cross compiling patches for MINGW

2007-12-09 Thread Scott Tsai
Scott Tsai added the comment: John, set ac_cv_printf_zd_format. In general, read the configure.in source. On Dec 10, 2007 1:17 PM, John Stowers [EMAIL PROTECTED] wrote: John Stowers added the comment: Sorry, I should have clarified further in my last comment. Looking over the configure