Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Georg, could you give this a once over before I commit? Thanks.
--
assignee: rhettinger - georg.brandl
nosy: +georg.brandl
Added file: http://bugs.python.org/file12695/counter5.diff
Martin v. Löwis mar...@v.loewis.de added the comment:
Thanks for the patch. Committed as r68540, r68541.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4915
Martin v. Löwis mar...@v.loewis.de added the comment:
I see. Whether the call to PyThread_get_thread_ident comes before the
access to errno (in the original version) depends on the compiler, of
course. Also, this function should be trusted to not affect the last
error, since it can't fail.
I've
Martin v. Löwis mar...@v.loewis.de added the comment:
Please add a Misc/NEWS entry for this change.
--
assignee: - krisvale
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3582
New submission from scott wedel taverng...@gmail.com:
The HUGE_VAL aka infinity issue is solved if the LIB is -lsunmath -lm
instead of just -lm
Sun Studio 12 compiler also seems to choke on the PyByteArray_GET_SIZE
and _AS_STRING because those macros use the ',' operator to stuff an
assert
Mark Dickinson dicki...@gmail.com added the comment:
Here's a patch against the py3k branch that gets rid of the two existing
uses of nb_long in the core:
- in PyNumber_Long, conversion was attempted first using nb_int and
then using nb_long. The patch simply removes the nb_long code, so
Mark Dickinson dicki...@gmail.com added the comment:
That was a pretty poor patch. Here's a better one:
- added Misc/NEWS entry
- added tests to check that __long__ is never called
- removed Modules/_struct.c change, in the interests of
keeping the patch focused.
Added file:
Guilherme Polo ggp...@gmail.com added the comment:
Documentation, tests and patch against trunk are needed to get this into
Python, but to me the request is fine.
--
title: wave.py writes 16 bit sample files of half the correct duration -
wave.py: add writesamples() and readsamples()
Georg Brandl ge...@python.org added the comment:
Yes, I'll have a look this evening.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1696199
___
___
Changes by Guilherme Polo ggp...@gmail.com:
--
type: - feature request
versions: +Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483545
___
Changes by Guilherme Polo ggp...@gmail.com:
--
versions: -Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4913
___
___
New submission from Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
1. collections.MutableSet refers to __next__() slot instead of next()
buildin.
2. collection.Iterator is not compatible with 2.6's iterators which
should have next() slot. Proposed solution: add a next() method to
Changes by Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
Removed file: http://bugs.python.org/file12699/example2.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4920
___
Changes by Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
Added file: http://bugs.python.org/file12700/example2.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4920
___
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:
Hello. Sorry if this is noise. I expected
__del__
out of function
__del__
out of function
__del__
out of function
on following code, but actually I got
out of function
out of function
out of function
__del__
__del__
__del__
Is
Changes by Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
--
keywords: +patch
Added file: http://bugs.python.org/file12701/_abcoll.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4920
___
Changes by Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
Added file: http://bugs.python.org/file12699/example2.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4920
___
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Attaching an update with improved docs. Thanks for looking at this.
Added file: http://bugs.python.org/file12702/counter6.diff
___
Python tracker rep...@bugs.python.org
New submission from Jaroslaw Rosiek jaroslaw.ros...@interia.pl:
Methods set.add and set.discard should return boolean values according
to collections.MutableSet but they are not.
print set().add(5)
None
print set().discard(5)
None
--
components: Library (Lib)
messages: 79665
nosy:
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Good catch!
--
nosy: +rhettinger
priority: - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4920
___
New submission from Riccardo Attilio Galli riqu...@gmail.com:
there are discrepancies in the online documentation of
strftime
in time.strftime http://docs.python.org/library/time.html
and datetime.strftime (http://docs.python.org/library/datetime.html)
In particular, seems like
Antoine Pitrou pit...@free.fr added the comment:
Since g calls itself in its own scope, it is stored as one of its own
cell vars, which creates a reference cycle. a is also part of its
reference cycle for the same reason, so it must wait for garbage
collection to be reclaimed.
If g didn't keep
Antoine Pitrou pit...@free.fr added the comment:
Looking at the patch, is there any reason it doesn't get rid of the
current _PyModule_Clear() implementation to replace it by a call to
PyDict_Clear() followed by PyGC_Collect()?
(the call to PyGC_Collect could be disabled while finalizing,
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:
Thank you for explanation. The combination of inner function + method
variable was very handy for me, but maybe I should refrain from using
it lightly. :-(
--
resolution: - invalid
status: open - closed
New submission from Antoine Pitrou pit...@free.fr:
I haven't verified this through any test (actually I'm wondering how to
deterministically reproduce it), but logically there are cases where
gc.collect() (and, similarly, PyGC_Collect()) won't work as advertised.
Specifically, when the GC is
Martin v. Löwis mar...@v.loewis.de added the comment:
It should be possible to trigger this by invoking gc.collect in an
__del__ implementation of an object that is attached to a cycle.
However, I don't think this is an important issue; +0 for resolving this
by documenting the status quo
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
on POSIX, clock() indeed wraps around after some time.
This was corrected with issue645894, and is available since python 2.5.
--
nosy: +amaury.forgeotdarc
resolution: - out of date
status: open - closed
superseder: - better
Ray rayjohnterr...@gmail.com added the comment:
The patch didn't install correctly using 'patch', but I manually merged
the changes into my environment (Ubuntu 8.10 running 2.5.2) - I'll
upload the diff rejections if they'll be helpful.
After installing, I attempted to use the new code to
Tarek Ziadé ziade.ta...@gmail.com added the comment:
yes the patch doesn't treat the eggs installed with easy_install yet,
just plain distutils
I'll let you know when EGG_INFO/PKG-INFO is ready (should be in the
coming days)
___
Python tracker
Alex Robinson alex_python_...@tranzoa.com added the comment:
Polo: I could do it, but I'm in disagreement with big part of your patch.
Why surely you can't mean the bug. :) (The test program has it fixed.)
What is the disagreement?
Apparently this bug system allows file attachments, so I will
Ray rayjohnterr...@gmail.com added the comment:
I've tested it out using the straight distutils installation, and it
works great!
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4908
___
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:
A little followup. Attached script q112.py (some puzzle program) ate up
my RAM (80MB) and never ran GC while solving. Current python GC looks
at the number of GC objects, but GC object like set object can contain
many non GC
Guilherme Polo ggp...@gmail.com added the comment:
Aren't 8 bit samples stored as unsigned bytes ? If yes, they don't range
between -128 and 127 (first disagreement). So this line: wav = [ s - 128
for s in wav ] and the respective one (that adds +128 in writesamples)
should go.
Why is this
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Newer versions of Purify seem to convert the file name to uppercase
letters (PYTHON27__D$Purify...), so the error is does not occur anymore.
The current code is fragile though...
--
resolution: - works for me
status: open -
New submission from Martin Mokrejs mmokr...@users.sourceforge.net:
I think the following error output unsatisfactory as it does not give me
any hint what file was not found:
$ fetch_quals.py blah.txt
Traceback (most recent call last):
File /home/mmokrejs/bin/fetch_quals.py, line 15, in
David W. Lambert lamber...@corning.com added the comment:
Related, but outside python realm, this error likewise confuses:
$ cat EOF s.sh
#! invalid path
echo hi
EOF
$ ./s.sh
zsh: no such file or directory: ./s.sh
--
nosy: +LambertDW
___
Python
Alex Robinson alex_python_...@tranzoa.com added the comment:
8 bit samples stored as unsigned bytes?
8 bit samples are 0..255 in the file. But to work with them, you'll want
them -128..127. The code assumes DC==0 sample values for simplicity.
if len(wavs) not in [ 1, 2, 4 ] ?
That way if you're
Fernando Gomes fgs...@gmail.com added the comment:
Dear Community,
I'd fronted problems to install Statistics module on my Ubuntu.
There are errors that are hard to solve without an expert help, such as
the one received from Michiel (Thank you again!!!).
Errors are listed below:
#
Jeffrey Yasskin jyass...@gmail.com added the comment:
Here's the vmgen-based patch for comparison. Again, it passes all the
tests, but isn't complete outside of that and (unless consensus develops
that a couple percent is worth requiring vmgen) shouldn't distract from
reviewing Antoine's patch.
Benjamin Peterson benja...@python.org added the comment:
The first installment looks good!
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4910
___
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
the typical usage is c=Counter(myseq) with no other non-dict accesses
(mostly just c[elem]+=1 and print c[elem])
Isn't collections.defaultdict(lambda:0) enough for this purpose?
--
nosy: +amaury.forgeotdarc
Guilherme Polo ggp...@gmail.com added the comment:
1) wave.py doesn't do assumptions about what the user wants, so I don't
think it is the place to put the DC (0 hz) assumption.
3) writesamples would raise an exception in the case of the current
number of channels set being wrong.
4) Well,
Guilherme Polo ggp...@gmail.com added the comment:
I was going to reply about your code layout answer but forgot. Well,
each one has their preferences so I'm not going to question yours.
The only problem is that there is no maintainer for wave.py, so, the
more you follow the rules for Python
Benjamin Peterson benja...@python.org added the comment:
I think PyObject_NextNotImplemented should be renamed to
_PyObject_NextNotImplemented. Aside from that, I think the patch is
ready for committing.
--
nosy: +benjamin.peterson
___
Python tracker
Steven Bethard steven.beth...@gmail.com added the comment:
The whole point was to have a function (or class) that accumulates a
sequence and counts it. collections.defaultdict(lambda: 0) doesn't
achieve this on its own because it only knows how to handle sequences of
(key, value):
d =
Paolo 'Blaisorblade' Giarrusso p.giarru...@gmail.com added the comment:
A couple percent maybe is not worth vmgen-ing. But even if I'm not a
vmgen expert, I read many papers from Ertl about superinstructions and
replication, so the expected speedup from vmgen'ing is much bigger.
Is there some
Georg Brandl ge...@python.org added the comment:
Attaching new patch with small changes:
* Don't describe a class with Returns ... as if it was a function.
* Indent interposed paragraphs so that the method descriptions still
belong to the .. class directive.
* Fixed Ned's typo.
* Note that
Jeffrey Yasskin jyass...@gmail.com added the comment:
I've left some line-by-line comments at
http://codereview.appspot.com/11905. Sorry if there was already a
Rietveld thread; I didn't see one.
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
Guess that makes this a bit of a wasted effort on my part, then. Darn.
a substantial portion of the module should be coded in C and
needs to function independently of Python, with accessors provided to
for Python to wrap around.
I'm
Mark Dickinson dicki...@gmail.com added the comment:
BTW, both those I'm not sures should be taken literally: I'm not a user
of the ast module, I don't know who the typical users are, and I don't
know what the typical uses for the literal_eval function are. The patch
just struck me as odd,
Nick Coghlan ncogh...@gmail.com added the comment:
FWIW, I actually prefer Mark's graduated approach to the Python-C
migration since we have a continuously working module that will get
incrementally faster over time. As profiling finds performance
bottlenecks in the Python code, those parts can
Guilherme Polo ggp...@gmail.com added the comment:
Not going to happen, python 2.5.4 is already out there.
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3038
Jason Tishler ja...@tishler.net added the comment:
Obviously not... :,(
It seems like we might have to go with your /./ workaround, but let
me see if I can come up with another approach.
___
Python tracker rep...@bugs.python.org
Changes by Martin v. Löwis mar...@v.loewis.de:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3582
___
___
Armin Ronacher armin.ronac...@active-4.com added the comment:
Here a patch with unittests to correctly handle complex numbers. This
does not allow the user of arbitrary add/sub expressions on complex numbers.
Added file: http://bugs.python.org/file12707/literal-eval.patch
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1479611
___
___
Antoine Pitrou pit...@free.fr added the comment:
Well, tracking memory consumption of each container would be better than
simpling couting them, but it's much more complicated as well (not to
mention that memory consumption can vary, so you must recalculate it
periodically...).
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Thanks for the review comments. Incorporated all suggested changes and
did some other minor tidying-up. Extended the update example to include
c.update(Counter('abcdee')). Committed as r68559 .
Decided to leave __repr__()
New submission from David Watson bai...@users.sourceforge.net:
One of these problems interacts with the other, and can cause
os.unsetenv() to free memory that's still in use. Firstly,
calling os.putenv(FOO=BAR, value) causes putenv(3) to be
called with the string FOO=BAR=value, which sets a
Changes by David Watson bai...@users.sourceforge.net:
Added file: http://bugs.python.org/file12709/2.x.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4926
___
Changes by David Watson bai...@users.sourceforge.net:
Added file: http://bugs.python.org/file12710/3.x.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4926
___
Gregory P. Smith g...@krypto.org added the comment:
Any crash is a potential security problem.
This needs to be fixed in 2.6.x without breaking 2.6.0 extension
compatibility. (requiring extensions to be recompiled to fix the
problem for an extension is fine, but they still need to load and
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Fixed in r68560 (trunk) and r68561 (py3k).
Difficult to backport: extensions compiled with 2.6.x would not run on
2.6.0.
--
keywords: -needs review
resolution: - fixed
status: open - pending
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Yes, a hack: What about setting tp_iternext to PyObject_GetIter? they happen
to have the same signature.
Yes, calling next() will call iter() instead; but an iterator is often its
own iterator, and more importantly, PyIter_Check() is
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
The patch looks fine to me
--
nosy: +gagenellina
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4905
___
Pablo Castagnino pablo.castagn...@gmail.com added the comment:
Ok, everything seems to be working now in Ubuntu. However, I can't get
it work in WIN XP (at work). :(
Thanks for all your help!
___
Python tracker rep...@bugs.python.org
Alex Robinson alex_python_...@tranzoa.com added the comment:
DC (0 hz) assumption?
wave.py makes the assumption that what the user wants is whatever
happens to be in the file, however arbitrary. (That 8 bit samples are
unsigned bytes is probably an artifact of early ADC logic. Typically you
got
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
Just a small note on the wording: will have and will always be look
too strong to me. I'd just use is, are. Present tense seems to be --in
general-- the preferred style in the documentation.
--
nosy: +gagenellina
Gregory P. Smith g...@krypto.org added the comment:
nice hack! :)
I'm going to guess that existing code in the wild setting tp_iternext =
PyObject_GetIter is rare. I certainly can not rule it entirely out but
I don't see anything in the open source world using
Changes by Gabriel Genellina gagsl-...@yahoo.com.ar:
--
nosy: +gagenellina
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4926
___
___
Andi Albrecht albrecht.a...@gmail.com added the comment:
Is it intended that when reading PKG-INFO files the PEP 314 attributes
(provides, requires, obsoletes) are only set if version is exactly 1.1?
I'd expected that those attributes are available regardless of the
metadata version of the
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
Lukas Lueg The default encoding is UTF8
What do you mean? Not inside a zip file. The default encoding is CP437
(the original IBM PC US character set).
A zipfile password is a sequence of bytes, not characters, as defined
in the
Changes by Paolo 'Blaisorblade' Giarrusso p.giarru...@gmail.com:
--
nosy: +blaisorblade
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4896
___
___
Jeffrey Yasskin jyass...@gmail.com added the comment:
@Paolo: I'm going to be looking into converting more common sequences
into superinstructions. We only have LOAD_CONST+XXX so far. The others
are difficult because vmgen doesn't provide easy ways to deal with error
handling, but Jakob and I
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
You (as a human) most likely parse these lines:
hostname vaijain123
hostname CAVANC1001CR1
as two words, the first one is the same, the second word changed.
But difflib sees them more or less as: 21 letters, 8 of them are the
same,
Paolo 'Blaisorblade' Giarrusso p.giarru...@gmail.com added the comment:
Ok, then vmgen adds almost just direct threading instead of indirect
threading.
Since the purpose of superinstructions is to eliminate dispatch
overhead, and that's more important when little actual work is done,
what about
76 matches
Mail list logo
