Serhiy Storchaka added the comment:
The patches LGTM. How about adding a test?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
___
___
danblack added the comment:
If it isn't very clear to you, I can still handle it myself, though. Those
docs aren't the best.
Not clear enough. Yes I'd appreciate you handling it. Thanks.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Patch updated with clarified comments.
Are the tests fail on non-fixed Python?
--
Added file: http://bugs.python.org/file28329/glob_magic_in_drive_2.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Add pure Python operator module
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16651
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
___
___
Antoine Pitrou added the comment:
Patch updated with clarified comments.
Are the tests fail on non-fixed Python?
Yes, they do.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16626
___
New submission from Hynek Schlawack:
See issue16664.
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 177584
nosy: Sebastian.Kreft, docs@python, hynek, pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: Clarify fnmatch glob docs
Changes by Antoine Pitrou pit...@free.fr:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14901
___
___
Serhiy Storchaka added the comment:
Here is a functional (and more effective) equivalent of attrgetter:
def attrgetter(attr, *attrs):
Return a callable object that fetches the given attribute(s) from its
operand.
After f=attrgetter('name'), the call f(r) returns r.name.
After
Hynek Schlawack added the comment:
Patch LGTM and will be applied, I have opened issue16695 for the related update
of the docs.
BTW how did you create the patch? The bugtracker/Rietveld didn't recognize it
for review and applying it took some effort too.
--
title: [PATCH] Test Glob:
Serhiy Storchaka added the comment:
Perhaps Modules/operator.c should be renamed to Modules/_operator.c.
Also note, that error messages in Python an C implementations sometimes differ.
--
___
Python tracker rep...@bugs.python.org
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset 028ecc3900f5 by Hynek Schlawack in branch '2.7':
#16664: Add regression tests for glob's behaviour concerning .-entries
http://hg.python.org/cpython/rev/028ecc3900f5
New changeset 29f0c45ce576 by Hynek Schlawack in branch '3.2':
#16664: Add
Hynek Schlawack added the comment:
Thank you for your patch and welcome to CPython core development!
Presuming you want to submit more patches in future, please take the time to
sign a Python contributor agreement: http://www.python.org/psf/contrib/ .
You'll get a pretty star next to your
Daniel Shahaf added the comment:
Haven't had a chance to look at the test___all__ -related failures yet. Still
planning to do so once I have some time.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16076
And Clover added the comment:
WSGI's usage of ISO-8859-1 for all HTTP-byte-originated strings is very much
deliberate; we needed a way to preserve the original input bytes whilst still
using unicode strings, and at the time surrogateescape was not available. The
result is counter-intuitive
Serhiy Storchaka added the comment:
1. Most data attributes cannot have individual docstrings, so I expect the
class docstring to list and possibly explain the data attributes.
But almost all PyStructSequence field have individual docstrings.
This does not create a second new class and is
Roundup Robot added the comment:
New changeset 4af260a54e05 by Antoine Pitrou in branch '3.2':
Issue #16626: Fix infinite recursion in glob.glob() on Windows when the pattern
contains a wildcard in the drive or UNC path.
http://hg.python.org/cpython/rev/4af260a54e05
New changeset b90aa7f66e4a
Roundup Robot added the comment:
New changeset b0935ef48186 by Antoine Pitrou in branch '2.7':
Issue #16626: Fix infinite recursion in glob.glob() on Windows when the pattern
contains a wildcard in the drive or UNC path.
http://hg.python.org/cpython/rev/b0935ef48186
--
Antoine Pitrou added the comment:
Patches now committed, thank you !
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16626
New submission from Antoine Pitrou:
This failure appeared on one of the Windows buildbots:
==
ERROR: test_glob_magic_in_drive (test.test_glob.GlobTests)
--
Antoine Pitrou added the comment:
See also issue16696.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
Apparently this also needs fixing on 2.7 and 3.2, see e.g.
http://buildbot.python.org/all/builders/AMD64%20Mountain%20Lion%20%5BSB%5D%203.2
--
nosy: +pitrou
status: closed - open
versions: +Python 2.7, Python 3.2
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Python-bugs-list mailing
New submission from wim glenn:
Any object that supports the in operator can be passed as the choices value, so
dict objects, set objects, custom containers, etc. are all supported. (from
http://docs.python.org/dev/library/argparse.html#choices )
Actual behaviour is contradicted by the docs
Ross Lagerwall added the comment:
getgrouplist() is new in 3.3. Those failures are from getgroups() failing. I'll
open a separate issue for that.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16661
New submission from Ross Lagerwall:
test_posix.test_getgroups() fails on some systems:
http://buildbot.python.org/all/builders/AMD64%20Mountain%20Lion%20%5BSB%5D%203.2
This could be related to #16661.
--
components: Tests
messages: 177601
nosy: rosslagerwall
priority: normal
severity:
R. David Murray added the comment:
This is a duplicate of issue issue 16468, which may get closed with either a
bug fix or a doc fix, depending on the outcome of the overall discussion.
--
nosy: +r.david.murray
resolution: - duplicate
stage: - committed/rejected
status: open - closed
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +wim.glenn
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16468
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
It should be if not basename:. No additional tests are possible except those
which added for issue16626.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16696
Roundup Robot added the comment:
New changeset 96f19274de18 by Antoine Pitrou in branch '3.2':
Issue #16696: fix comparison between bytes and string. Also, improve glob tests.
http://hg.python.org/cpython/rev/96f19274de18
New changeset ed8134df30e4 by Antoine Pitrou in branch '3.3':
Issue
Antoine Pitrou added the comment:
I've added some tests for patterns with a trailing slash.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 391bda06fa65 by Antoine Pitrou in branch '3.3':
Silence sporadic failure in RecvmsgSCTPStreamTest.testRecvmsgEOF (issue #13876)
- probably not Python-related.
http://hg.python.org/cpython/rev/391bda06fa65
New changeset 2d2d4807a3ed by Antoine
Antoine Pitrou added the comment:
I've now silenced the exception. Leaving this issue open in case someone wants
to investigate more.
--
resolution: - fixed
stage: needs patch - committed/rejected
versions: +Python 3.4
___
Python tracker
Serhiy Storchaka added the comment:
The first bug fixed in issue16696.
--
nosy: +pitrou, serhiy.storchaka
type: enhancement - behavior
versions: +Python 3.2, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15845
Serhiy Storchaka added the comment:
Looks as this is a duplicate of issue13247. And Victor submitted a patch with
approach similar to me (except that my patch does not raises an exception, but
returns an unicode for unencodable names).
It looks as longliving design bug and perhaps really be
Antoine Pitrou added the comment:
Indeed, os.listdir() should always be called with a unicode argument under
Windows (which is the natural thing to do in 3.x, anyway). The other issue
(with print() unable to display some symbols depending on the codepage) is
unrelated.
--
nosy:
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: pitrou
priority: normal
severity: normal
status: open
title: Mountain Lion buildbot lacks disk space
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16699
New submission from Antoine Pitrou:
==
ERROR: test_large_file_ops (test.test_io.CIOTest)
--
Traceback (most recent call last):
File
Changes by Antoine Pitrou pit...@free.fr:
--
components: +Windows
stage: committed/rejected -
title: os.path.abspath returns unicode paths as question marks - under
Windows, os.path.abspath returns non-ASCII bytes paths as question marks
type: enhancement - behavior
versions: +Python
Serhiy Storchaka added the comment:
See also issue16656 where another approach was proposed (unicode names returned
from Bytes API if result is not encodable). Actually I think now that there is
no right solution of this issue.
--
nosy: +serhiy.storchaka
New submission from Serhiy Storchaka:
Some OS functions which returns bytes (os.environb, os.getenvb(), os.getcwdb(),
os.listdir(), os.readlink(), os.walk(), os.path.abspath(),
os.path.expanduser(), os.path.expandvars(), os.path.realpath() and may be
other) can return unusable result on
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16700
___
___
Python-bugs-list mailing
Matthew Barnett added the comment:
Here are some tests for the issue.
--
Added file: http://bugs.python.org/file28330/issue16688#3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
Mark Dickinson added the comment:
Here's a possible fix for Python 2.7. Reviews from Windows experts would be
very much appreciated; I don't really know what I'm doing here.
I'm still trying to work out how to test this effectively.
--
___
Python
Changes by Mark Dickinson dicki...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file28331/pyc_mtime.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
Serhiy Storchaka added the comment:
The second test pass on unpatched Python.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
___
___
Antoine Pitrou added the comment:
The patch doesn't apply cleanly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list
Matthew Barnett added the comment:
Oops! :-( Now corrected.
--
Added file: http://bugs.python.org/file28332/issue16688#3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
___
Changes by Matthew Barnett pyt...@mrabarnett.plus.com:
Removed file: http://bugs.python.org/file28330/issue16688#3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
___
Serhiy Storchaka added the comment:
Patches updated to resolve conflicts with recent commits. Some minor test
errors fixed.
--
Added file: http://bugs.python.org/file28333/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28334/glob_tests-2.7_2.patch
Serhiy Storchaka added the comment:
LGTM.
Matthew, can you please submit a contributor form?
http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Patches updated. Unrelated changes removed.
--
Added file: http://bugs.python.org/file28335/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28336/glob_tests-2.7_2.patch
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28333/glob_dotfiles_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28334/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Mark Dickinson added the comment:
Updated patch, with a test.
--
Added file: http://bugs.python.org/file28337/pyc_mtime2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
Serhiy Storchaka added the comment:
Yet one attempt.
--
Added file: http://bugs.python.org/file28338/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28339/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
I don't remember il the deprecation of bytes filename is documented.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16700
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28335/glob_dotfiles_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28336/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
___
Roundup Robot added the comment:
New changeset 907d71668d3c by Stefan Krah in branch '3.3':
Issue #15783: Support None default values in the Context() constructor.
http://hg.python.org/cpython/rev/907d71668d3c
--
___
Python tracker
Stefan Krah added the comment:
I think I've found all of them now. Closing.
--
assignee: - skrah
components: +Library (Lib)
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
versions: +Python 3.4
___
Python tracker
New submission from Ashwini Chaudhary:
I think the python docs are missing the behavior of += for lists. It actually
calls list.extend() but can't find that anywhere in docs expect in source code,
http://hg.python.org/cpython/file/2d2d4807a3ed/Objects/listobject.c#l892.
--
assignee:
Stefan Krah added the comment:
``./configure --without-pymalloc'' fails here:
gcc -pthread -Xlinker -export-dynamic -o python Modules/python.o
libpython3.4.a -lpthread -ldl -lutil -lm
libpython3.4.a(sysmodule.o): In function `sys_getallocatedblocks':
Ned Deily added the comment:
The getgroups test failure on OS X is likely the known limitation documented in
issue10433.
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16661
Ned Deily added the comment:
The test failure on OS X is likely an instance of the platform limitation
documented in issue10433.
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16698
R. David Murray added the comment:
Well, it is effectively documented by the text here:
http://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements
since a + b is logically equivalent to a.extend(b) when a is being updated
in-place. The fact that it is in fact
Mark Dickinson added the comment:
Updated patch to address comments from Serhiy on Rietveld:
- use ' 0x' in the Python code that gets the mtime; only the
bottom 32 bits of the mtime are used.
- simplify line that reads mtime from .pyc file.
Also improved an error check in the C
Chris Jerdonek added the comment:
Could you mock or monkey-patch what you are getting a tool tip for (i.e. set
the external string you are checking for)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16655
Richard Oudkerk added the comment:
Here is a new version with tests and docs.
Note that the docs do not mention the bug mentioned in
http://daniel.haxx.se/blog/2012/10/10/wsapoll-is-broken/
Maybe they should?
Note that that bug makes it a bit difficult to use poll with tulip on Windows.
Brian Curtin added the comment:
Looks alright so far. I'm working on reviewing and applying it.
--
assignee: docs@python - brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14901
Roundup Robot added the comment:
New changeset 5edbd93509b8 by Brian Curtin in branch '3.2':
Fix #14901. Update the Windows FAQ.
http://hg.python.org/cpython/rev/5edbd93509b8
New changeset fe20d5bf0c93 by Brian Curtin in branch 'default':
Add Ashish Nitin Patil for work on Issue #14901
Brian Curtin added the comment:
Thanks for the patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14901
Lucas Maystre added the comment:
Sorry for the little glitches you had to fix, I wonder why I didn't catch them.
Anyways, thanks Petri!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11175
75 matches
Mail list logo
